Ok, thanks for clarifying, I agree and the current webrev looks good!
/Erik
On 2019-04-10 14:25, Alexandre (Shura) Iline wrote:
Erik,
JCOV_FILTERS variable is also used while building an instrumented image - with
"jcov-image” make target. To completely prevent make form complaining, it looks
Erik,
JCOV_FILTERS variable is also used while building an instrumented image - with
"jcov-image” make target. To completely prevent make form complaining, it looks
like the variable would need to be added it to MAKE_CONTROL_VARIABLES in
make/InitSupport.gmk. Which we could do, but, judging by
> On Apr 9, 2019, at 6:31 AM, Erik Joelsson wrote:
>
> Hello Shura,
>
> If JCOV_FILTERS is ever expected to be set on the make command line
> (typically when running make run-test-prebuilt), then it would be good if we
> could add a way to set it through TEST_OPTS=JCOV_FILTERS=... . Using t
Hello Shura,
If JCOV_FILTERS is ever expected to be set on the make command line
(typically when running make run-test-prebuilt), then it would be good
if we could add a way to set it through TEST_OPTS=JCOV_FILTERS=... .
Using the officially supported input variables like this avoids the
warn
Hi,
Could you please take a look on this enhancement which makes it easy to get
code coverage for a part of JDK code.
This change introduces “JCOV_FILTERS” make variable and also
"--with-jcov-filters” configuration option.
With that one is free to use any of JCov filtering options to limit
