bility-...@openjdk.java.net
*Subject:* Re: Code Review fix for 8005044 remove crufty '_g'
support from HS runtime code
Adding the other aliases back in...
Harold,
This question:
> Another nit: Is it worth checking that all of
> "/hotspot/libjvm.so" could get copied to buf? (i
Closing the loop on this question that I asked earlier:
Just curious, when gamma was renamed to hotspot on Windows, that
change wasn't made on Linux on Solaris. Any particular reason?
On Solaris there is a "hotspot" shell script and a "gamma" binary.
I suspect the same it true for Linux (and
On 19 dec 2012, at 16:22, Daniel D. Daugherty
wrote:
> On 12/19/12 1:27 AM, Staffan Larsen wrote:
>> On 18 dec 2012, at 22:11, Daniel D. Daugherty
>> wrote:
>>
>>> Just for the record: I have reviewed all of Ron's changes
>>> and I approve them.
>>>
>>> One thing I noticed of interest to la
ot;/hotspot/libjvm.so")
Thanks, Harold
On 12/19/2012 9:17 AM, Ron Durbin wrote:
Harold,
Did you have any more points or counter points to make on the use of snprintf
and strncpy ?
Ron
From: Ron Durbin
Sent: Tuesday, December 18, 2012 4:50 PM
To: Daniel Daugherty; HYPERLINK
"mai
/libjvm.so" could get
>> copied to buf? (i.e.: that buflen-len > strlen("/hotspot/libjvm.so")
>>
>> Thanks, Harold
>>
>> On 12/19/2012 9:17 AM, Ron Durbin wrote:
>>>
>>>
>>> Harold,
>>>
>>> Did y
uot;/hotspot/libjvm.so"
could get copied to buf? (i.e.: that buflen-len >
strlen("/hotspot/libjvm.so")
Thanks, Harold
On 12/19/2012 9:17 AM, Ron Durbin wrote:
Harold,
Did you have any more points or counter points to make on the use of
snprintf and strncpy ?
Ron
*From:*R
On 12/19/12 1:27 AM, Staffan Larsen wrote:
On 18 dec 2012, at 22:11, Daniel D. Daugherty
wrote:
Just for the record: I have reviewed all of Ron's changes
and I approve them.
One thing I noticed of interest to launcher folks that
is not due to any changes that Ron made:
src/os/windows/vm/os_
hotspot-runtime-...@openjdk.java.net"hotspot-runtime-...@openjdk.java.net;
build-dev; HYPERLINK
"mailto:serviceability-...@openjdk.java.net"serviceability-...@openjdk.java.net
Subject: Re: Code Review fix for 8005044 remove crufty '_g' support from HS
runtime code
Sorry, I
On 18 dec 2012, at 22:11, Daniel D. Daugherty
wrote:
> Just for the record: I have reviewed all of Ron's changes
> and I approve them.
>
> One thing I noticed of interest to launcher folks that
> is not due to any changes that Ron made:
>
> src/os/windows/vm/os_windows.cpp:
>
> 1718 // Find
8005044 remove crufty '_g' support from HS
runtime code
Sorry, I lost my manners somewhere... :-(
Thanks for the fast review!
Dan
On 12/18/12 3:57 PM, Daniel D. Daugherty wrote:
Adding back in the other aliases...
Harold,
The equivalent of:
snprintf(buf, n, str);
is:
Sorry, I lost my manners somewhere... :-(
Thanks for the fast review!
Dan
On 12/18/12 3:57 PM, Daniel D. Daugherty wrote:
Adding back in the other aliases...
Harold,
The equivalentof:
snprintf(buf, n, str);
is:
strncpy(buf, str, n - 1);
buf[n - 1] = '\0';
because snprintf()
Adding back in the other aliases...
Harold,
The equivalentof:
snprintf(buf, n, str);
is:
strncpy(buf, str, n - 1);
buf[n - 1] = '\0';
because snprintf() will only write out (n-1) bytes from
'str' to 'buf'and then write a NUL in the lastslot.
strncpy() copies up to 'n' bytes from'
Adding back in the other aliases...
Coleen, thanks for the fast review!
Dan
On 12/18/12 2:29 PM, Coleen Phillimore wrote:
This looks good. Thank you for doing this.
Coleen
On 12/18/2012 03:46 PM, Daniel D. Daugherty wrote:
Greetings,
I'm sponsoring this code review request from Ron Durb
view fix for 8005044 remove crufty '_g' support from HS
runtime code
Kelly,
The Makefile changes were reviewed under 7153050 last week and pushed to
RT_Baseline.
See the attached notification.
Dan
On 12/18/12 2:06 PM, Kelly O'Hair wrote:
I don't see any makefile chan
12 2:14 PM
> To: Kelly O'Hair
> Cc: serviceability-...@openjdk.java.net; build-dev;
> hotspot-runtime-...@openjdk.java.net
> Subject: Re: Code Review fix for 8005044 remove crufty '_g' support from HS
> runtime code
>
> Kelly,
>
> The Makefile ch
Dan is correct.
-Original Message-
From: Daniel D. Daugherty
Sent: Tuesday, December 18, 2012 2:14 PM
To: Kelly O'Hair
Cc: serviceability-...@openjdk.java.net; build-dev;
hotspot-runtime-...@openjdk.java.net
Subject: Re: Code Review fix for 8005044 remove crufty '_g'
Kelly,
The Makefile changes were reviewed under 7153050 last week and
pushed to RT_Baseline.
See the attached notification.
Dan
On 12/18/12 2:06 PM, Kelly O'Hair wrote:
I don't see any makefile changes.
-kto
On Dec 18, 2012, at 12:46 PM, Daniel D. Daugherty wrote:
Greetings,
I'm sponso
Just for the record: I have reviewed all of Ron's changes
and I approve them.
One thing I noticed of interest to launcher folks that
is not due to any changes that Ron made:
src/os/windows/vm/os_windows.cpp:
1718 // Find the full path to the current module, jvm.dll
1719 void os::jvm_path(char *
I don't see any makefile changes.
-kto
On Dec 18, 2012, at 12:46 PM, Daniel D. Daugherty wrote:
> Greetings,
>
> I'm sponsoring this code review request from Ron Durbin. This change
> is targeted at JDK8/HSX-25 in the RT_Baseline repo.
>
> Dan
>
> Sending again with correct subject line, bug
19 matches
Mail list logo
