+1
-- Jon
On 6/26/20 6:13 AM, Jan Lahoda wrote:
Hi,
I propose to split the data update (for JDK 15 and for backports) and
the tool/CreateSymbols update (for JDK 16+). So I've created:
https://bugs.openjdk.java.net/browse/JDK-8248405
for the latter. Lets keep JDK-8244763 only for the
Hi,
I propose to split the data update (for JDK 15 and for backports) and
the tool/CreateSymbols update (for JDK 16+). So I've created:
https://bugs.openjdk.java.net/browse/JDK-8248405
for the latter. Lets keep JDK-8244763 only for the former, i.e. for this
patch:
Further testing revealed some issues with the patch, especially:
-use of un-encoded version when deleting the old data for the version
(so the data deletion failed for versions > 9)
-need to delete old module data as well
-when searching for existing methods and fields, we need to continue the
Looks good to me.
-- Jon
On 5/18/20 9:36 AM, Jan Lahoda wrote:
I apologize, I used a wrong patch for the "data" webrev. The "class
name java/util/jar/Attributes$Name" entry in java.base-7.sym.txt is
first adding field descriptions, and then removing the old ones:
---
class name
Hi Brad,
Thanks for your review and comments. I'll see if we can indent the
innerclass entries in the header (i.e. option 1) separately.
Jan
On 18. 05. 20 19:47, Bradford Wetmore wrote:
Thanks again Jan for looking into and fixing this.
I looked over the new entries last week, and the new
Thanks again Jan for looking into and fixing this.
I looked over the new entries last week, and the new MR3 ALPN/PSS items
looked good.
My only comment is that as a newbie to this area, the "header" attribute
includes the "innerclass" parameters: innerclass isn't an attribute on
its own
I apologize, I used a wrong patch for the "data" webrev. The "class name
java/util/jar/Attributes$Name" entry in java.base-7.sym.txt is first
adding field descriptions, and then removing the old ones:
---
class name java/util/jar/Attributes$Name
field name EXTENSION_INSTALLATION descriptor
