> This completes the desktop module JNF removal
>
> * remove -framework JavaNativeFoundation from make files
>
> * remove #import from all
> source files. If needed add import of JNIUtilities.h to get jni.h definitions
> - better anyway since then it gets the current JDK ones not the ones fr
On Tue, 2 Feb 2021 23:22:12 GMT, Phil Race wrote:
>> This completes the desktop module JNF removal
>>
>> * remove -framework JavaNativeFoundation from make files
>>
>> * remove #import from all
>> source files. If needed add import of JNIUtilities.h to get jni.h
>> definitions - better any
On Tue, 2 Feb 2021 21:26:28 GMT, Kevin Rushforth wrote:
>> The changes look good to me, but please see my comment from my review about
>> documenting `NormalizedPathNSStringFromJavaString()` API.
>
> The following commit was integrated to jdk master since you created this
> branch:
>
> acbcde8
> This completes the desktop module JNF removal
>
> * remove -framework JavaNativeFoundation from make files
>
> * remove #import from all
> source files. If needed add import of JNIUtilities.h to get jni.h definitions
> - better anyway since then it gets the current JDK ones not the ones fr
On Tue, 2 Feb 2021 22:33:09 GMT, Phil Race wrote:
>> I read it and not sure that it is fine to ignore this error, why not throw
>> an exception and signal the CTextPipe_doDrawString that an error occurred
>> like InvalidPipeException or something(Sometimes we wrap other exception
>> like OOM i
On Tue, 2 Feb 2021 21:48:36 GMT, Sergey Bylokhov wrote:
>> Look a few lines further up at my reply 3 days ago Gerard about this.
>
> I read it and not sure that it is fine to ignore this error, why not throw an
> exception and signal the CTextPipe_doDrawString that an error occurred like
> Inva
On Tue, 2 Feb 2021 22:02:14 GMT, Sergey Bylokhov wrote:
>> I ran some tests embedding JavaFX into Swing and vice versa both with and
>> without `-Djavafx.embed.singleThread=true` and I don't see any regression in
>> behavior.
>
> I am mostly worried about the usage of JNF by someone else's nati
On Mon, 1 Feb 2021 23:47:06 GMT, Phil Race wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/CTextPipe.m line 611:
>>
>>> 609: const jchar *unichars = (*env)->GetStringChars(env, str, NULL);
>>> 610: if (unichars == NULL) {
>>> 611: return;
>>
>> Do not we ne
On Tue, 2 Feb 2021 21:18:42 GMT, Kevin Rushforth wrote:
>> We are just specifying an additional run mode for JDK internal use.
>> It means that when we are saying to process only events for that mode, then
>> only those will be processed.
>> And it is used only for nested event loops.
>> Nothing
On Mon, 1 Feb 2021 18:33:32 GMT, Gerard Ziemski wrote:
>> Marked as reviewed by gziemski (Committer).
>
> The changes look good to me, but please see my comment from my review about
> documenting `NormalizedPathNSStringFromJavaString()` API.
The following commit was integrated to jdk master sin
On Tue, 2 Feb 2021 00:30:07 GMT, Phil Race wrote:
>> src/java.desktop/macosx/native/libosxapp/ThreadUtilities.m line 53:
>>
>>> 51: @implementation ThreadUtilities
>>> 52:
>>> 53: + (void)initialize {
>>
>> I think we need to check how this new modes will work when the AWT is
>> embedded insi
On Mon, 1 Feb 2021 22:17:38 GMT, Sergey Bylokhov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8260616: Removing remaining JNF dependencies in the java.desktop module
>
> src/java.desktop/macosx/native/libawt_lwawt/
On Mon, 1 Feb 2021 19:09:59 GMT, Phil Race wrote:
>> This completes the desktop module JNF removal
>>
>> * remove -framework JavaNativeFoundation from make files
>>
>> * remove #import from all
>> source files. If needed add import of JNIUtilities.h to get jni.h
>> definitions - better any
I can confirm that the autoconf warning disabling is currently still
needed when building with our standard devkit.
It'll have to be removed at the very end.
In file included from
./open/src/java.security.jgss/macosx/native/libosxkrb5/SCDynamicStoreConfig.m:27:
.
/System/Library/Fram
> This completes the desktop module JNF removal
>
> * remove -framework JavaNativeFoundation from make files
>
> * remove #import from all
> source files. If needed add import of JNIUtilities.h to get jni.h definitions
> - better anyway since then it gets the current JDK ones not the ones fr
On Mon, 1 Feb 2021 18:31:23 GMT, Gerard Ziemski wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8260616: Removing remaining JNF dependencies in the java.desktop modul
>
> Marked as reviewed by gziemski (Committer).
T
On Fri, 29 Jan 2021 19:53:32 GMT, Phil Race wrote:
>> src/java.desktop/macosx/native/libosxapp/JNIUtilities.m line 83:
>>
>>> 81: stringWithFileSystemRepresentation:chs length:len];
>>> 82: return result;
>>> 83: }
>>
>> Why are we doing:
>>
>> `java_string -> chars -> NS
On Fri, 29 Jan 2021 17:24:05 GMT, Phil Race wrote:
>> This completes the desktop module JNF removal
>>
>> * remove -framework JavaNativeFoundation from make files
>>
>> * remove #import from all
>> source files. If needed add import of JNIUtilities.h to get jni.h
>> definitions - better an
Per my comment in the PR I am currently working on updating it to handle
the test update needed.
Once the other in-flight PRs are integrated, my grepping says that the
only remaining build change
needed after that is to remove one disabled warning in
make/autoconf/flags-cflags.m4
I am goin
On Mon, 1 Feb 2021 11:35:22 GMT, Magnus Ihse Bursie wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8260616: Removing remaining JNF dependencies in the java.desktop modul
>
> Build changes look good for this PR.
> *
On Fri, 29 Jan 2021 17:24:05 GMT, Phil Race wrote:
>> This completes the desktop module JNF removal
>>
>> * remove -framework JavaNativeFoundation from make files
>>
>> * remove #import from all
>> source files. If needed add import of JNIUtilities.h to get jni.h
>> definitions - better an
On 2021-01-29 17:41, Phil Race wrote:
But we can just remove it and prove it - but probably a separate PR since it is
nothing to do with the desktop module and the autoconf code needs to be updated
once everything else is in.
Fair enough. Do you have a JBS issue tracking the remaining build sys
On Fri, 29 Jan 2021 16:23:20 GMT, Gerard Ziemski wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8260616: Removing remaining JNF dependencies in the java.desktop modul
>
> src/java.desktop/macosx/native/libawt_lwawt/a
On Fri, 29 Jan 2021 17:02:30 GMT, Gerard Ziemski wrote:
>> Changes requested by gziemski (Committer).
>
> Lots of small changes you had to handle here. Thank you for doing it!
I pushed a commit with the remaining -lframework ... removals in the desktop
makefiles that I had somehow missed ...
-
> This completes the desktop module JNF removal
>
> * remove -framework JavaNativeFoundation from make files
>
> * remove #import from all
> source files. If needed add import of JNIUtilities.h to get jni.h definitions
> - better anyway since then it gets the current JDK ones not the ones fr
On Fri, 29 Jan 2021 16:57:09 GMT, Gerard Ziemski wrote:
>> This completes the desktop module JNF removal
>>
>> * remove -framework JavaNativeFoundation from make files
>>
>> * remove #import from all
>> source files. If needed add import of JNIUtilities.h to get jni.h
>> definitions - bett
On Fri, 29 Jan 2021 00:30:21 GMT, Phil Race wrote:
> This completes the desktop module JNF removal
>
> * remove -framework JavaNativeFoundation from make files
>
> * remove #import from all
> source files. If needed add import of JNIUtilities.h to get jni.h definitions
> - better anyway si
On Fri, 29 Jan 2021 10:53:42 GMT, Magnus Ihse Bursie wrote:
>> This completes the desktop module JNF removal
>>
>> * remove -framework JavaNativeFoundation from make files
>>
>> * remove #import from all
>> source files. If needed add import of JNIUtilities.h to get jni.h
>> definitions -
On 2021-01-29 02:56, Magnus Ihse Bursie wrote:
On Fri, 29 Jan 2021 00:30:21 GMT, Phil Race wrote:
This completes the desktop module JNF removal
* remove -framework JavaNativeFoundation from make files
* remove #import from all source
files. If needed add import of JNIUtilities.h to get
On Fri, 29 Jan 2021 00:30:21 GMT, Phil Race wrote:
> This completes the desktop module JNF removal
>
> * remove -framework JavaNativeFoundation from make files
>
> * remove #import from all
> source files. If needed add import of JNIUtilities.h to get jni.h definitions
> - better anyway si
30 matches
Mail list logo
