Re: RFR: 8276654: element-list order is non deterministic [v2]

2021-11-05 Thread Magnus Ihse Bursie
On Fri, 5 Nov 2021 19:36:34 GMT, Andrew Leonard wrote: >> yep, i'll have a look to see what I can do, not helped with existing >> variables being so long!! (GENERATE_SYMBOLS_FROM_JDK_VERSION) > > yep, split on CommaList seems better and works fine, see revision Does it work if you have space af

Re: RFR: 8276654: element-list order is non deterministic [v2]

2021-11-05 Thread Andrew Leonard
On Fri, 5 Nov 2021 19:26:56 GMT, Andrew Leonard wrote: >> make/modules/jdk.javadoc/Gendata.gmk line 75: >> >>> 73: $(call MakeTargetDir) >>> 74: $(call LogInfo, Creating javadoc element lists) >>> 75: $(RM) $(ELEMENT_LISTS_DIR)/element-list-{$(call >>> CommaList,$(call

Re: RFR: 8276654: element-list order is non deterministic [v2]

2021-11-05 Thread Andrew Leonard
On Fri, 5 Nov 2021 19:20:10 GMT, Erik Joelsson wrote: >> Andrew Leonard has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. > > make/modules/jdk.javadoc/Gendata.gmk

Re: RFR: 8276654: element-list order is non deterministic [v2]

2021-11-05 Thread Erik Joelsson
On Fri, 5 Nov 2021 18:46:26 GMT, Andrew Leonard wrote: >> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 >> >> A intermittent problem with the make dependencies means the jdk.javadoc >> element-list-.txt generation can remove the src defined >> element|package-list-<7,8,9,10>.txt file

Re: RFR: 8276654: element-list order is non deterministic [v2]

2021-11-05 Thread Andrew Leonard
> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 > > A intermittent problem with the make dependencies means the jdk.javadoc > element-list-.txt generation can remove the src defined > element|package-list-<7,8,9,10>.txt files. > Recreatable by using --with-jobs=1 causing jdk.javadoc "g