Re: RFR: Add s390(x) detection to platform.m4

2013-09-11 Thread Omair Majid
On 09/11/2013 06:22 AM, Erik Joelsson wrote: > On 2013-09-10 22:30, Omair Majid wrote: >> On 09/09/2013 01:40 PM, Omair Majid wrote: >>> http://cr.openjdk.java.net/~omajid/webrevs/s390-platform/01/ >> If there are no further concerns, shall I go ahead and push? > Looks good to me, feel free to push

Re: RFR: Add s390(x) detection to platform.m4

2013-09-11 Thread Erik Joelsson
On 2013-09-10 22:30, Omair Majid wrote: On 09/09/2013 01:40 PM, Omair Majid wrote: On 09/05/2013 05:10 AM, Magnus Ihse Bursie wrote: On 2013-09-04 21:26, Omair Majid wrote: Over in Fedora-land, we are trying to build OpenJDK (using zero) on s390(x) [1]. One of the changes needed is updating t

Re: RFR: Add s390(x) detection to platform.m4

2013-09-10 Thread Omair Majid
On 09/09/2013 01:40 PM, Omair Majid wrote: > On 09/05/2013 05:10 AM, Magnus Ihse Bursie wrote: >> On 2013-09-04 21:26, Omair Majid wrote: >>> Over in Fedora-land, we are trying to build OpenJDK (using zero) on >>> s390(x) [1]. One of the changes needed is updating the platform.m4 file >>> to teach

Re: RFR: Add s390(x) detection to platform.m4

2013-09-09 Thread Dmitry Samersoff
Omair, I'm OK with latest webrev. -Dmitry On 2013-09-09 21:34, Omair Majid wrote: > Hi, > > On 09/05/2013 05:43 AM, Dmitry Samersoff wrote: >> It might make sense to set >> >> VAR_CPU to ESA_390 >> >> VAR_CPU_ARCH to ESA_390 or ever to ESA_3xx >> >> for both s390 and s390x. >> >> s370 diverge

Re: RFR: Add s390(x) detection to platform.m4

2013-09-09 Thread Omair Majid
On 09/05/2013 05:10 AM, Magnus Ihse Bursie wrote: > On 2013-09-04 21:26, Omair Majid wrote: >> Over in Fedora-land, we are trying to build OpenJDK (using zero) on >> s390(x) [1]. One of the changes needed is updating the platform.m4 file >> to teach it about s390(x). The following webrev does that:

Re: RFR: Add s390(x) detection to platform.m4

2013-09-09 Thread Omair Majid
Hi, On 09/05/2013 05:43 AM, Dmitry Samersoff wrote: > It might make sense to set > > VAR_CPU to ESA_390 > > VAR_CPU_ARCH to ESA_390 or ever to ESA_3xx > > for both s390 and s390x. > > s370 diverged over time to a variety of more or less compatible series > and it's possible the same happens

Re: RFR: Add s390(x) detection to platform.m4

2013-09-05 Thread Dmitry Samersoff
Omair, It might make sense to set VAR_CPU to ESA_390 VAR_CPU_ARCH to ESA_390 or ever to ESA_3xx for both s390 and s390x. s370 diverged over time to a variety of more or less compatible series and it's possible the same happens (if not already happened) with s390. -Dmitry On 2013-09-04 23:2

Re: RFR: Add s390(x) detection to platform.m4

2013-09-05 Thread Magnus Ihse Bursie
On 2013-09-04 21:26, Omair Majid wrote: Over in Fedora-land, we are trying to build OpenJDK (using zero) on s390(x) [1]. One of the changes needed is updating the platform.m4 file to teach it about s390(x). The following webrev does that: http://cr.openjdk.java.net/~omajid/webrevs/s390-platform/0

Re: RFR: Add s390(x) detection to platform.m4

2013-09-05 Thread Erik Joelsson
Looks good to me. Created: 8024320: Add s390(x) detection to platform.m4 /Erik On 2013-09-04 21:26, Omair Majid wrote: Hi, Over in Fedora-land, we are trying to build OpenJDK (using zero) on s390(x) [1]. One of the changes needed is updating the platform.m4 file to teach it about s390(x). Th