Re: RFR: JDK-8199103 Can't use COMPARE_BUILD with PATCH from custom root

2018-03-06 Thread Magnus Ihse Bursie
On 2018-03-06 15:59, Erik Joelsson wrote: Looks good. When looking at this patch, I realized that topdir has a different meaning depending on if you are in the HAS_SPEC conditional or not. In the first section, topdir is always the open root dir, but in the else section it is set to CUSTOM_RO

Re: RFR: JDK-8199103 Can't use COMPARE_BUILD with PATCH from custom root

2018-03-06 Thread Erik Joelsson
Looks good. When looking at this patch, I realized that topdir has a different meaning depending on if you are in the HAS_SPEC conditional or not. In the first section, topdir is always the open root dir, but in the else section it is set to CUSTOM_ROOT if available. This is rather confusing.

Re: RFR: JDK-8199103 Can't use COMPARE_BUILD with PATCH from custom root

2018-03-06 Thread Erik Joelsson
Looks good. When looking at this patch, I realized that topdir has a different meaning depending on if you are in the HAS_SPEC conditional or not. In the first section, topdir is always the open root dir, but in the else section it is set to CUSTOM_ROOT if available. This is rather confusing.