Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

On 05/24/2018 03:01 PM, David Holmes wrote: >> I'm not building Zero in this case but Hotspot native for linux-sparc. > > Are you building an interpreter only version of linux-sparc? No, I don't think so: MAKE_VERBOSE=y QUIETLY= LOG=debug sh ./configure --with-jvm-variants=server

Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

On 05/24/2018 02:59 PM, John Paul Adrian Glaubitz wrote: > On 05/24/2018 02:57 PM, Aleksey Shipilev wrote: >> Oh. I am just confused you are replying to the stale review thread for >> "Minimal, Zero builds fail >> after JDK-8202377 (Modularize C2 barriers)". What you are seeing is >> something

Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

On 24/05/2018 10:55 PM, John Paul Adrian Glaubitz wrote: On 05/24/2018 02:53 PM, Aleksey Shipilev wrote: Yeah, but this issue dealt with: /pool/buildbot/slaves/sobornost/jdkX/build/src/hotspot/share/opto/optoreg.hpp:32:39: fatal error: adfiles/adGlobals_x86.hpp: No such file or directory

Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

On 05/24/2018 02:57 PM, Aleksey Shipilev wrote: > Oh. I am just confused you are replying to the stale review thread for > "Minimal, Zero builds fail > after JDK-8202377 (Modularize C2 barriers)". What you are seeing is something > else. As I said, "hg blame" indicates the change which probably

Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

On 05/24/2018 02:55 PM, John Paul Adrian Glaubitz wrote: > On 05/24/2018 02:53 PM, Aleksey Shipilev wrote: >> Yeah, but this issue dealt with: >> >> /pool/buildbot/slaves/sobornost/jdkX/build/src/hotspot/share/opto/optoreg.hpp:32:39: >> fatal error: >> adfiles/adGlobals_x86.hpp: No such file or

Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

On 05/24/2018 02:53 PM, Aleksey Shipilev wrote: > Yeah, but this issue dealt with: > > /pool/buildbot/slaves/sobornost/jdkX/build/src/hotspot/share/opto/optoreg.hpp:32:39: > fatal error: > adfiles/adGlobals_x86.hpp: No such file or directory > #include CPU_HEADER(adfiles/adGlobals) > > Let's

Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

On 05/24/2018 02:49 PM, John Paul Adrian Glaubitz wrote: > On 05/24/2018 02:42 PM, Aleksey Shipilev wrote: >>> Does SPARC have support for C2 on Solaris so that we need to >>> add it for linux-sparc as well or is this limited to x86_64 only? >> >> You must be seeing something new, because the fix

Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

On 05/24/2018 02:42 PM, Aleksey Shipilev wrote: >> Does SPARC have support for C2 on Solaris so that we need to >> add it for linux-sparc as well or is this limited to x86_64 only? > > You must be seeing something new, because the fix for Minimal and Zero was > pushed to jdk/jdk > already.

Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

On 05/24/2018 02:38 PM, John Paul Adrian Glaubitz wrote: > Hi! > > On 05/19/2018 11:20 AM, Aleksey Shipilev wrote: >> Other GCs that would eventually bring their own BarrierSetC2 files (e.g. >> Epsilon, Shenandoah, ZGC) >> would require excluding their "gc//c2" as well. > > I'm seeing this bug

Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

Hi! On 05/19/2018 11:20 AM, Aleksey Shipilev wrote: > Other GCs that would eventually bring their own BarrierSetC2 files (e.g. > Epsilon, Shenandoah, ZGC) > would require excluding their "gc//c2" as well. I'm seeing this bug on linux-sparc as well. Does SPARC have support for C2 on Solaris so

Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

Looks good. /Erik On 2018-05-19 04:57, Erik Österlund wrote: Hi Aleksey, Looks good. Thanks, /Erik On 2018-05-19 13:52, Aleksey Shipilev wrote: Okay, this also works for Zero, Minimal and server: diff -r 5ec7380f671d make/hotspot/lib/JvmFeatures.gmk --- a/make/hotspot/lib/JvmFeatures.gmk 

Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

Hi Aleksey, Looks good. Thanks, /Erik On 2018-05-19 13:52, Aleksey Shipilev wrote: Okay, this also works for Zero, Minimal and server: diff -r 5ec7380f671d make/hotspot/lib/JvmFeatures.gmk --- a/make/hotspot/lib/JvmFeatures.gmk Fri May 18 18:31:28 2018 -0700 +++

Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

Okay, this also works for Zero, Minimal and server: diff -r 5ec7380f671d make/hotspot/lib/JvmFeatures.gmk --- a/make/hotspot/lib/JvmFeatures.gmk Fri May 18 18:31:28 2018 -0700 +++ b/make/hotspot/lib/JvmFeatures.gmk Sat May 19 13:36:32 2018 +0200 @@ -41,7 +41,7 @@ else JVM_EXCLUDES += opto

Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

Hi Aleksey, Thanks for fixing. I wonder if /c2/ could be added to the exclude pattern instead though, instead of enumerating all GCs. Thanks, /Erik > On 19 May 2018, at 11:20, Aleksey Shipilev wrote: > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8203454 > > Other

Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

Hi Alexey, looks good and works. Thanks for fixing. ..Thomas On Sat, May 19, 2018 at 11:20 AM, Aleksey Shipilev wrote: > Bug: > https://bugs.openjdk.java.net/browse/JDK-8203454 > > Other GCs that would eventually bring their own BarrierSetC2 files (e.g. > Epsilon,