Looks good.
I filed https://bugs.openjdk.java.net/browse/JDK-8219394 for this bug.
Thanks!
/Claes
On 2019-02-19 18:04, Erik Joelsson wrote:
The problem with the jarfile looks to be a missing $(FIXPATH) when
running microbenchmarks. The java process is simply unable to understand
cygwin
Pushed here: http://hg.openjdk.java.net/jdk/jdk/rev/1b40a0178b2a
/Claes
On 2019-02-19 22:41, Jorn Vernee wrote:
Great! Thanks for picking this up.
Jorn
Thanks, looks good!
/Erik
On 2019-02-19 10:35, Jorn Vernee wrote:
Hi Erik,
I have included your suggestions:
http://cr.openjdk.java.net/~jvernee/micronative/webrev.01
I'm a committer on project Panama, but I'm not sure if I have write
access to jdk/jdk as well. If the new webrev looks good
Great! Thanks for picking this up.
Jorn
Claes Redestad schreef op 2019-02-19 22:36:
Hi Jorn,
I'll sponsor this for jdk/jdk. I'll file a RFE, test it and push it
seeing it's already reviewed.
Thanks!
/Claes
On 2019-02-19 19:35, Jorn Vernee wrote:
Hi Erik,
I have included your suggestions:
Hi Jorn,
I'll sponsor this for jdk/jdk. I'll file a RFE, test it and push it
seeing it's already reviewed.
Thanks!
/Claes
On 2019-02-19 19:35, Jorn Vernee wrote:
Hi Erik,
I have included your suggestions:
http://cr.openjdk.java.net/~jvernee/micronative/webrev.01
I'm a committer on project
On Tue, Feb 19, 2019 at 10:37 AM Jorn Vernee wrote:
>
> I'm a committer on project Panama, but I'm not sure if I have write
> access to jdk/jdk as well.
You don't
https://openjdk.java.net/census#jvernee
Hi Erik,
I have included your suggestions:
http://cr.openjdk.java.net/~jvernee/micronative/webrev.01
I'm a committer on project Panama, but I'm not sure if I have write
access to jdk/jdk as well. If the new webrev looks good I could give it
a try, but otherwise someone else would have to
Yes, that fixes the problem. Thanks!
Jorn
Erik Joelsson schreef op 2019-02-19 18:04:
The problem with the jarfile looks to be a missing $(FIXPATH) when
running microbenchmarks. The java process is simply unable to
understand cygwin paths. Does this patch solve the issue for you,
Jorn?
diff -r
Hello Jorn,
This looks pretty good and should probably be pushed to mainline. Some
minor nits.
In BuildMicrobenchmark.gmk:
Please base MICROBENCHMARK_IMAGE dir on TEST_IMAGE_DIR like in
RunTests.gmk.
Line 131, please add ", \" plus newline like on 123-124.
/Erik
On 2019-02-19 03:49,
The problem with the jarfile looks to be a missing $(FIXPATH) when
running microbenchmarks. The java process is simply unable to understand
cygwin paths. Does this patch solve the issue for you, Jorn?
diff -r 7c17199fa37d make/RunTests.gmk
--- a/make/RunTests.gmk
+++ b/make/RunTests.gmk
@@
Hi,
I've taken a first stab at adding support for native dependencies:
http://cr.openjdk.java.net/~jvernee/micronative/webrev.00/
With a small test benchmark:
http://cr.openjdk.java.net/~jvernee/micronative_test/webrev.00/
Please be aware that both are based on the Panama/foreign branch [1].
Hi,
1.) I did not get a warning when I was missing --with-jmh for
configure, although it looks like there is supposed to be one (without
--with-jmh I got the same access error, but the benchmarks.jar did not
exist).
--with-jmh is an optional configure flag, not sure what we could do to
http://mail.openjdk.java.net/pipermail/jdk-dev/2019-February/002624.html>
Hi,
On 2019-02-18 22:34, Jorn Vernee wrote:
Hi Claes,
1. Does running make test rather than make test-only work?
No. Same error there. Sorry, I tried that first and then re-ran with
`test-only`. I also tried with a
13 matches
Mail list logo
