Re: custom extension for make/SourceRevision.gmk

Done: https://bugs.openjdk.java.net/browse/JDK-8210008 > On Aug 23, 2018, at 4:56 PM, Erik Joelsson wrote: >

Re: custom extension for make/SourceRevision.gmk

On 2018-08-20 04:27, Christian Thalinger wrote: On Jul 19, 2018, at 9:17 PM, Christian Thalinger mailto:cthalin...@twitter.com>> wrote: On Jul 19, 2018, at 2:31 PM, Erik Joelsson > wrote: I can do that. Do you have a bug? No. Sorry, was on

Re: custom extension for make/SourceRevision.gmk

> On Jul 19, 2018, at 9:17 PM, Christian Thalinger > wrote: > > > >> On Jul 19, 2018, at 2:31 PM, Erik Joelsson > > wrote: >> >> I can do that. Do you have a bug? >> > No. Sorry, was on vacation… I don’t see the change in the repo. Did you file one? >>

Re: custom extension for make/SourceRevision.gmk

> On Jul 19, 2018, at 2:31 PM, Erik Joelsson wrote: > > I can do that. Do you have a bug? > No. > /Erik > > On 2018-07-19 10:57, Christian Thalinger wrote: >> >> >> On Thu, Jul 19, 2018 at 1:11 PM Erik Joelsson > > wrote: >> This looks good to me, but will

Re: custom extension for make/SourceRevision.gmk

I can do that. Do you have a bug? /Erik On 2018-07-19 10:57, Christian Thalinger wrote: On Thu, Jul 19, 2018 at 1:11 PM Erik Joelsson mailto:erik.joels...@oracle.com>> wrote: This looks good to me, but will need coordination when pushed as I said earlier. Do you want to push it

Re: custom extension for make/SourceRevision.gmk

On Thu, Jul 19, 2018 at 1:11 PM Erik Joelsson wrote: > This looks good to me, but will need coordination when pushed as I said > earlier. > Do you want to push it so it’s easier? /Erik > > On 2018-07-19 10:04, Christian Thalinger wrote: > > > > On Jul 19, 2018, at 12:57 PM, Erik Joelsson >

Re: custom extension for make/SourceRevision.gmk

This looks good to me, but will need coordination when pushed as I said earlier. /Erik On 2018-07-19 10:04, Christian Thalinger wrote: On Jul 19, 2018, at 12:57 PM, Erik Joelsson > wrote: On 2018-07-19 09:54, Christian Thalinger wrote: On Jul 19,

Re: custom extension for make/SourceRevision.gmk

> On Jul 19, 2018, at 12:57 PM, Erik Joelsson wrote: > > > > On 2018-07-19 09:54, Christian Thalinger wrote: >> >> >>> On Jul 19, 2018, at 12:44 PM, Erik Joelsson >> > wrote: >>> >>> >>> On 2018-07-19 09:16, Christian Thalinger wrote:

Re: custom extension for make/SourceRevision.gmk

On 2018-07-19 09:54, Christian Thalinger wrote: On Jul 19, 2018, at 12:44 PM, Erik Joelsson > wrote: On 2018-07-19 09:16, Christian Thalinger wrote: Well, the issue is this: exploded-image: exploded-image-base release-file   release-file:

Re: custom extension for make/SourceRevision.gmk

> On Jul 19, 2018, at 12:44 PM, Erik Joelsson wrote: > > > On 2018-07-19 09:16, Christian Thalinger wrote: >> >> >> Well, the issue is this: >> >> exploded-image: exploded-image-base release-file >> >> release-file: create-source-revision-tracker >> >> store-source-revision: >>

Re: custom extension for make/SourceRevision.gmk

> On Jul 19, 2018, at 12:46 PM, Erik Joelsson wrote: > > One thing though. Since you are renaming the top file, we need to coordinate > pushing of this change since we are relying on the old name. We can keep the old name, if you want, but that wouldn’t be very consistent with other files.

Re: custom extension for make/SourceRevision.gmk

One thing though. Since you are renaming the top file, we need to coordinate pushing of this change since we are relying on the old name. /Erik On 2018-07-19 09:44, Erik Joelsson wrote: On 2018-07-19 09:16, Christian Thalinger wrote: Well, the issue is this: exploded-image:

Re: custom extension for make/SourceRevision.gmk

On 2018-07-19 09:16, Christian Thalinger wrote: Well, the issue is this: exploded-image: exploded-image-base release-file   release-file: create-source-revision-tracker store-source-revision:       +($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f SourceRevision.gmk

Re: custom extension for make/SourceRevision.gmk

> On Jul 19, 2018, at 12:08 PM, Erik Joelsson wrote: > > Hello, > On 2018-07-19 07:43, Christian Thalinger wrote: >> >> >>> On Jul 18, 2018, at 3:28 PM, Christian Thalinger >> > wrote: >>> >>> >>> On Jul 18, 2018, at 1:46 PM, Erik Joelsson >>>

Re: custom extension for make/SourceRevision.gmk

Hello, On 2018-07-19 07:43, Christian Thalinger wrote: On Jul 18, 2018, at 3:28 PM, Christian Thalinger mailto:cthalin...@twitter.com>> wrote: On Jul 18, 2018, at 1:46 PM, Erik Joelsson > wrote: Hello Christian, Sometimes we need hooks both close to

Re: custom extension for make/SourceRevision.gmk

> On Jul 18, 2018, at 3:28 PM, Christian Thalinger > wrote: > > > >> On Jul 18, 2018, at 1:46 PM, Erik Joelsson wrote: >> >> Hello Christian, >> >> Sometimes we need hooks both close to the beginning and close to the end of >> the file, and in that case we create a

Re: custom extension for make/SourceRevision.gmk

> On Jul 18, 2018, at 1:46 PM, Erik Joelsson wrote: > > Hello Christian, > > Sometimes we need hooks both close to the beginning and close to the end of > the file, and in that case we create a SourceBundle-post.gmk. The recommended > position of the post inclusion is right before the

Re: custom extension for make/SourceRevision.gmk

Hello Christian, Sometimes we need hooks both close to the beginning and close to the end of the file, and in that case we create a SourceBundle-post.gmk. The recommended position of the post inclusion is right before the typical "all: $(TARGETS)" declaration. This file has the all target