On Apr 26, 2012, at 12:37 AM, Magnus Ihse Bursie wrote:
> On 2012-04-25 21:34, Kelly O'Hair wrote:
>> I of course approve. ;^)
>>
>> We need some code phrase for me when you want a patch integrated into the
>> jdk8/build forest.
>> I'll deal with the CR, make the owner you in this case, and add
On 2012-04-25 21:34, Kelly O'Hair wrote:
I of course approve. ;^)
We need some code phrase for me when you want a patch integrated into the
jdk8/build forest.
I'll deal with the CR, make the owner you in this case, and add any reviewers I
have seen in the email
thread. So how about a code phr
I of course approve. ;^)
We need some code phrase for me when you want a patch integrated into the
jdk8/build forest.
I'll deal with the CR, make the owner you in this case, and add any reviewers I
have seen in the email
thread. So how about a code phrase like "Kelly, Please integrate this patc
Magnus,
On 2012-04-25 20:31, Magnus Ihse Bursie wrote:
> Hence, every time configure.ac is modified, configure will be updated as
> well.
OK. Thank you for the explanation!
-Dmitry
>
> /Magnus
>>
>> -Dmitry
>>
>>
>> On 2012-04-25 17:32, Magnus Ihse Bursie wrote:
>>> On 2012-04-23 18:01, Dmit
25 apr 2012 kl. 17:23 skrev Dmitry Samersoff :
> Magnus,
>
> Fix looks good for me.
>
> The only question - why we should patch both configure.ac
> and configure ?
>
> I believe we generate configure from configure.ac
Yes we do, but we keep a generated configure checked in in the repo, so user
Magnus,
Fix looks good for me.
The only question - why we should patch both configure.ac
and configure ?
I believe we generate configure from configure.ac
-Dmitry
On 2012-04-25 17:32, Magnus Ihse Bursie wrote:
> On 2012-04-23 18:01, Dmitry Samersoff wrote:
>> Magnus,
>>
>> I'm second to Kelly
Looks much better, thanks Magnus.
-Chris.
On 25/04/2012 14:32, Magnus Ihse Bursie wrote:
On 2012-04-23 18:01, Dmitry Samersoff wrote:
Magnus,
I'm second to Kelly.
We shouldn't have executable scripts in repository.
Ok, so here comes a new, even simpler patch. :-)
http://cr.openjdk.java.net
On 2012-04-23 18:01, Dmitry Samersoff wrote:
Magnus,
I'm second to Kelly.
We shouldn't have executable scripts in repository.
Ok, so here comes a new, even simpler patch. :-)
http://cr.openjdk.java.net/~ihse/logger.sh-missing-x-permission/webrev.01/
/Magnus
Magnus,
I'm second to Kelly.
We shouldn't have executable scripts in repository.
-Dmitry
On 2012-04-23 10:16, Kelly O'Hair wrote:
If this file can never really have execute permission in the repositories, then
encouraging people to put
execute permission on it creates a risk that they might
If this file can never really have execute permission in the repositories, then
encouraging people to put
execute permission on it creates a risk that they might try to commit that
change, and then their changeset would get
rejected. A big annoyance.
So why not just always run $(SH) and skip th
On 21/04/2012 12:14 AM, Magnus Ihse Bursie wrote:
In the build-infra hg repo, we allowed execute permission to be set on
files, including common/bin/logger.sh, which is called by the Makefile.
The official hg repos strip this bit, so when integrating to the build
forest, this was lost, causing t
Looks good!
2012/4/20 Magnus Ihse Bursie :
> In the build-infra hg repo, we allowed execute permission to be set on
> files, including common/bin/logger.sh, which is called by the Makefile.
>
> The official hg repos strip this bit, so when integrating to the build
> forest, this was lost, causing
In the build-infra hg repo, we allowed execute permission to be set on
files, including common/bin/logger.sh, which is called by the Makefile.
The official hg repos strip this bit, so when integrating to the build
forest, this was lost, causing the Makefile to fail since it can't
execute logge
13 matches
Mail list logo
