Re: Request for Review: Fix sed expression in compare-images target

2012-05-11 Thread Erik Joelsson
Looks good to me On 2012-05-11 16:47, Magnus Ihse Bursie wrote: The Release Engineering team in Oracle encountered a problem when building in a path that contained the character "@". Normally, having strange names in the directory where you are building is not a good idea, but in this case the

Re: Request for Review: Fix sed expression in compare-images target

2012-05-11 Thread Kelly O'Hair
Done: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c2d9166f3284 To clarify, this is a surgical fix to one sed command to deal with Hudson adding @ characters to pathnames. I'm still of the opinion that adding @ characters to paths is a bad idea, but this change is harmless and helps the RE

Request for Review: Fix sed expression in compare-images target

2012-05-11 Thread Magnus Ihse Bursie
The Release Engineering team in Oracle encountered a problem when building in a path that contained the character "@". Normally, having strange names in the directory where you are building is not a good idea, but in this case the path was created by the Hudson CI system. The problem is a sing