Re: Review request: Build infra update

2012-10-12 Thread Kelly O'Hair
I'll see what I can do. I've almost crawled out from under the email pile, down to 500 emails... -kto On Oct 12, 2012, at 4:30 AM, Erik Joelsson wrote: > So far we have reviews from David and Magnus. Could use one more with > reviewer status. Kelly, could you start looking into submittin

Re: Review request: Build infra update

2012-10-12 Thread Erik Joelsson
So far we have reviews from David and Magnus. Could use one more with reviewer status. Kelly, could you start looking into submitting this? /Erik On 2012-10-08 17:09, Erik Joelsson wrote: After achieving the milestone of equivalent images from the new and old build, this is a good time to refr

Re: Review request: Build infra update

2012-10-09 Thread David Holmes
On 9/10/2012 9:13 PM, Erik Joelsson wrote: On 2012-10-09 12:59, David Holmes wrote: On 9/10/2012 6:06 PM, Erik Joelsson wrote: Not exactly sure what you mean with the duplication other than the comment in the last rule being wrong. One rule is for copying from jdk/lib and the other from images/

Re: Review request: Build infra update

2012-10-09 Thread Erik Joelsson
On 2012-10-09 12:59, David Holmes wrote: On 9/10/2012 6:06 PM, Erik Joelsson wrote: Not exactly sure what you mean with the duplication other than the comment in the last rule being wrong. One rule is for copying from jdk/lib and the other from images/lib. Both sources contain files that are g

Re: Review request: Build infra update

2012-10-09 Thread David Holmes
On 9/10/2012 6:06 PM, Erik Joelsson wrote: Not exactly sure what you mean with the duplication other than the comment in the last rule being wrong. One rule is for copying from jdk/lib and the other from images/lib. Both sources contain files that are going into the image. I thought you were on

Re: Review request: Build infra update

2012-10-09 Thread Magnus Ihse Bursie
On 2012-10-08 17:09, Erik Joelsson wrote: After achieving the milestone of equivalent images from the new and old build, this is a good time to refresh build-infra in jdk8. Here is a webrev with the proposed changes: http://cr.openjdk.java.net/~erikj/build-infra5/webrev.01/

Re: Review request: Build infra update

2012-10-09 Thread Erik Joelsson
Oh and thanks for the review of course! /Erik On 2012-10-09 10:06, Erik Joelsson wrote: Not exactly sure what you mean with the duplication other than the comment in the last rule being wrong. One rule is for copying from jdk/lib and the other from images/lib. Both sources contain files that a

Re: Review request: Build infra update

2012-10-09 Thread Erik Joelsson
Not exactly sure what you mean with the duplication other than the comment in the last rule being wrong. One rule is for copying from jdk/lib and the other from images/lib. Both sources contain files that are going into the image. /Erik On 2012-10-09 04:10, David Holmes wrote: Hi Erik, In I

Re: Review request: Build infra update

2012-10-08 Thread David Holmes
Hi Erik, In Images.gmk you seem to have duplicated the targets/instructions for copying rather than updating them ie: 197 $(JRE_IMAGE_DIR)/lib/%: $(JDK_OUTPUTDIR)/lib/% 198 $(ECHO) Copying $(patsubst $(OUTPUT_ROOT)/%,%,$@) 199 $(install-file) 200 ... 222 # Rules for copyi

Review request: Build infra update

2012-10-08 Thread Erik Joelsson
After achieving the milestone of equivalent images from the new and old build, this is a good time to refresh build-infra in jdk8. Here is a webrev with the proposed changes: http://cr.openjdk.java.net/~erikj/build-infra5/webrev.01/

Re: Review Request: Build-infra update

2012-06-07 Thread Kelly O'Hair
Looks good. I'm doing a separate changeset for the src changes. -kto On Jun 5, 2012, at 5:06 AM, Erik Joelsson wrote: > Here is the new webrev, against latest jdk8/build. Only the jdk repo needed > to be redone: > > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/webrev-jdk.2/ >

Re: Review Request: Build-infra update

2012-06-05 Thread Erik Joelsson
Here is the new webrev, against latest jdk8/build. Only the jdk repo needed to be redone: http://cr.openjdk.java.net/~erikj/build-infra-m1.1/webrev-jdk.2/ I added a comment explaining the usage of |. /Erik On 2012-06-04 16

Re: Review Request: Build-infra update

2012-06-05 Thread Alan Bateman
On 04/06/2012 17:52, Kelly O'Hair wrote: ./share/classes/sun/nio/ch/sctp/SctpStdSocketOption.java:@GenerateNativeHeader ./solaris/classes/sun/nio/ch/sctp/AssociationChange.java:@GenerateNativeHeader ./solaris/classes/sun/nio/ch/sctp/PeerAddrChange.java:@GenerateNativeHeader ./solaris/classes/sun

Re: Review Request: Build-infra update

2012-06-05 Thread Alan Bateman
On 04/06/2012 15:15, Erik Joelsson wrote: I have created a (hopefully temporary) hack to run javah manually for these 5 classes. This webrev is just against the build-infra repo. Unless anybody objects to this temporary solution, I will publish a new full webrev against the jdk8/build forest to

Re: Review Request: Build-infra update

2012-06-04 Thread Magnus Ihse Bursie
I had to ask Erik about it, too. :-) Since we are now a small crowd not knowing about it, I think that warrants a comment describing the purpose. Erik, can you fix that? /Magnus 4 jun 2012 kl. 22:22 skrev Tim Bell : > Looks good to me. Line 314 of CompileJavaClasses.gmk is an 'order-only'

Re: Review Request: Build-infra update

2012-06-04 Thread Tim Bell
Looks good to me. Line 314 of CompileJavaClasses.gmk is an 'order-only' prerequisite - I had to look it up as I have only seen it used one other time. http://www.gnu.org/software/make/manual/make.html#Prerequisite-Types Tim On 06/04/12 07:15, Erik Joelsson wrote: I have created a (hopefu

Re: Review Request: Build-infra update

2012-06-04 Thread Fredrik Öhrström
Nice! Just fix the spelling of "annotaion". //Fredrik 4 jun 2012 kl. 16:15 skrev Erik Joelsson: > I have created a (hopefully temporary) hack to run javah manually for these 5 > classes. This webrev is just against the build-infra repo. Unless anybody > objects to this temporary solution, I w

Re: Review Request: Build-infra update

2012-06-04 Thread Kelly O'Hair
On Jun 4, 2012, at 9:52 AM, Kelly O'Hair wrote: > although I was puzzled by the "| $(BUILD_JDK)" in > 314 $(JDK_OUTPUTDIR)/classes/_the.jdk.base.headers: > $(JDK_BASE_HEADER_JAVA_FILES) | $(BUILD_JDK) > Never seen a | character in the dependencies before, is that a valid syntax? > > -kto N

Re: Review Request: Build-infra update

2012-06-04 Thread Kelly O'Hair
Are these ok? ./share/classes/sun/nio/ch/DatagramChannelImpl.java:@GenerateNativeHeader ./share/classes/sun/nio/ch/IOStatus.java:@GenerateNativeHeader ./share/classes/sun/nio/ch/sctp/SctpStdSocketOption.java:@GenerateNativeHeader ./solaris/classes/sun/nio/ch/sctp/AssociationChange.java:@GenerateN

Re: Review Request: Build-infra update

2012-06-04 Thread Erik Joelsson
I have created a (hopefully temporary) hack to run javah manually for these 5 classes. This webrev is just against the build-infra repo. Unless anybody objects to this temporary solution, I will publish a new full webrev against the jdk8/build forest tomorrow. http://cr.openjdk.java.net/~erikj

Re: Review Request: Build-infra update

2012-05-24 Thread Fredrik Öhrström
But it has a meaning for JLS+JVMS, if you change the final static and the native code depends on its value, and you forget to rerun javah, then something will break. A final static field that is used from native, is as bound to the running Java program as any native method is. Change something with

Re: Review Request: Build-infra update

2012-05-24 Thread Jonathan Gibbons
The rationale for not allowing it is that it has no meaning at either the JLS or JVMS level. It would simply be a hint for tools, and hints for tools are best done by annotations. -- Jon On 05/24/2012 12:02 PM, Fredrik Öhrström wrote: Not by me anyway. In fact, I think that solution is the b

Re: Review Request: Build-infra update

2012-05-24 Thread Fredrik Öhrström
Not by me anyway. In fact, I think that solution is the best one! //Fredrik 2012/5/23 Jonathan Gibbons : > I wanted to be able to declare fields as native, but that was deemed > unacceptable. > > -- Jon > > > On 05/23/2012 10:05 AM, Alan Bateman wrote: >> >> On 23/05/2012 17:50, Kelly O'Hair wrot

Re: Review Request: Build-infra update

2012-05-23 Thread Jonathan Gibbons
I wanted to be able to declare fields as native, but that was deemed unacceptable. -- Jon On 05/23/2012 10:05 AM, Alan Bateman wrote: On 23/05/2012 17:50, Kelly O'Hair wrote: Has anyone tried creating an unused native method declaration in the class to trigger the native header generation?

Re: Review Request: Build-infra update

2012-05-23 Thread Alan Bateman
On 23/05/2012 17:50, Kelly O'Hair wrote: Has anyone tried creating an unused native method declaration in the class to trigger the native header generation? public native void GenerateNativeHeader(); ??? Is that too ugly? -kto As Jon put it, for the classes in the base module, "we are del

Re: Review Request: Build-infra update

2012-05-23 Thread Kelly O'Hair
Has anyone tried creating an unused native method declaration in the class to trigger the native header generation? public native void GenerateNativeHeader(); ??? Is that too ugly? -kto On May 23, 2012, at 8:01 AM, Jonathan Gibbons wrote: > On 05/23/2012 01:00 AM, Alan Bateman wrote: >> O

Re: Review Request: Build-infra update

2012-05-23 Thread Jonathan Gibbons
On 05/23/2012 01:00 AM, Alan Bateman wrote: On 23/05/2012 08:30, Erik Joelsson wrote: I'm also not sure if Alan's comment was a blocker. The idea with GenerateNativeHeader was approved by Jon Gibbon's initially at least. Alan? I don't like holding things up but I do think this needs wider co

Re: Review Request: Build-infra update

2012-05-23 Thread Alan Bateman
On 23/05/2012 08:30, Erik Joelsson wrote: I'm also not sure if Alan's comment was a blocker. The idea with GenerateNativeHeader was approved by Jon Gibbon's initially at least. Alan? I don't like holding things up but I do think this needs wider consideration. -Alan

Re: Review Request: Build-infra update

2012-05-23 Thread Erik Joelsson
On 2012-05-22 23:08, Kelly O'Hair wrote: Not sure where we are on these changes. I have made sure that they don't regress the old builds and am ready to integrate, but I'm concerned on Alan's modularity comment, and also who should I be adding to the "Reviewed-by" list. I'm also not sure if A

Re: Review Request: Build-infra update

2012-05-22 Thread Kelly O'Hair
Not sure where we are on these changes. I have made sure that they don't regress the old builds and am ready to integrate, but I'm concerned on Alan's modularity comment, and also who should I be adding to the "Reviewed-by" list. Also, I'm thinking I should separate the changes in the jdk repo

Re: Review Request: Build-infra update

2012-05-22 Thread Erik Joelsson
New webrevs published (those ending in .1): http://cr.openjdk.java.net/~erikj/build-infra-m1.1/ All issues below have been addressed. There are also some other improvements that we felt should get in now. /Erik On 2012-05-16 23:21, Fre

Re: Review Request: Build-infra update

2012-05-16 Thread Fredrik Öhrström
In configure.ac: Indententation looks odd where solaris optimizations settings for CC are calculated. Could someone enlighten this configure script with a comment about libCrun? In logger.sh: trap "rm -rf '$RCDIR'" EXIT The $RCDIR is not replaced with the contents of the variable RCDIR since it is

Re: Review Request: Build-infra update

2012-05-16 Thread Alan Bateman
On 16/05/2012 13:32, Erik Joelsson wrote: The build-infra project has been quite productive and would like to push an update to the new build in jdk8. All webrevs can be found here: http://cr.openjdk.java.net/~erikj/build-infra-m1.1/ W

Review Request: Build-infra update

2012-05-16 Thread Erik Joelsson
The build-infra project has been quite productive and would like to push an update to the new build in jdk8. All webrevs can be found here: http://cr.openjdk.java.net/~erikj/build-infra-m1.1/ What's new in this push? * Makefile conversi