Re: RFR: JDK-8244247: Build failures after sjavac cleanup

2020-05-05 Thread Magnus Ihse Bursie
On 2020-05-04 23:38, Erik Joelsson wrote: On 2020-05-04 02:51, Magnus Ihse Bursie wrote: On 2020-05-01 19:33, Erik Joelsson wrote: After the sjavac cleanup in JDK-8244036 (and the subsequent fix of the javac server usage in JDK-8244210), two more build failures have been noted. The bootcycle

Re: RFR: JDK-8244247: Build failures after sjavac cleanup

2020-05-04 Thread Erik Joelsson
On 2020-05-04 02:51, Magnus Ihse Bursie wrote: On 2020-05-01 19:33, Erik Joelsson wrote: After the sjavac cleanup in JDK-8244036 (and the subsequent fix of the javac server usage in JDK-8244210), two more build failures have been noted. The bootcycle build fails and the test-make target

Re: RFR: JDK-8244247: Build failures after sjavac cleanup

2020-05-04 Thread Magnus Ihse Bursie
On 2020-05-01 19:33, Erik Joelsson wrote: After the sjavac cleanup in JDK-8244036 (and the subsequent fix of the javac server usage in JDK-8244210), two more build failures have been noted. The bootcycle build fails and the test-make target fails the tests of SetupJavaCompilation

Re: RFR: JDK-8244247: Build failures after sjavac cleanup

2020-05-01 Thread Tim Bell
Erik: Looks good. Tim After the sjavac cleanup in JDK-8244036 (and the subsequent fix of the javac server usage in JDK-8244210), two more build failures have been noted. The bootcycle build fails and the test-make target fails the tests of SetupJavaCompilation. The bootcycle build fails

RFR: JDK-8244247: Build failures after sjavac cleanup

2020-05-01 Thread Erik Joelsson
After the sjavac cleanup in JDK-8244036 (and the subsequent fix of the javac server usage in JDK-8244210), two more build failures have been noted. The bootcycle build fails and the test-make target fails the tests of SetupJavaCompilation. The bootcycle build fails because a space has crept

Re: RFR: JDK-8244036 Refresh SetupJavaCompilation, and remove support for sjavac

2020-04-30 Thread Erik Joelsson
mpiler.interim -m jdk.compiler.interim/com.sun.tools.sjavac.Main --server:portfile=/mnt/scratch1/fw/jdk/make-support/javacservers/server.port,id=BUILD_TOOLS_JDK,sjavac=/usr/lib/jvm/java-14-openjdk-amd64/bin/java%20-Xms512M%20-Xmx2048M%20--limit-modules%20java.base%2Cjdk.zipfs%2Cjava.compiler.interim%2Cjdk.compiler

Re: RFR: JDK-8244036 Refresh SetupJavaCompilation, and remove support for sjavac

2020-04-30 Thread Florian Weimer
nterim --module-path /mnt/scratch1/fw/jdk/buildtools/interim_langtools_modules --add-exports java.base/sun.reflect.annotation=jdk.compiler.interim --add-exports java.base/jdk.internal.jmod=jdk.compiler.interim --add-exports java.base/jdk.internal.misc=jdk.compiler.interim -m jdk.compiler.interim/com.sun.tool

Re: RFR: JDK-8244036 Refresh SetupJavaCompilation, and remove support for sjavac

2020-04-30 Thread Magnus Ihse Bursie
On 2020-04-30 15:50, Florian Weimer wrote: * Magnus Ihse Bursie: I made sure that no build performances were measured on my system, and since I saw no such indication, I did not make any more systematic analysis. What is the difference if you run with or without the javac server? Thanks.

Re: RFR: JDK-8244036 Refresh SetupJavaCompilation, and remove support for sjavac

2020-04-30 Thread Florian Weimer
* Magnus Ihse Bursie: > I made sure that no build performances were measured on my system, and > since I saw no such indication, I did not make any more systematic analysis. > > What is the difference if you run with or without the javac server? Thanks. Which configure flags do you want me to

Re: RFR: JDK-8244036 Refresh SetupJavaCompilation, and remove support for sjavac

2020-04-30 Thread Magnus Ihse Bursie
On 2020-04-30 15:07, Magnus Ihse Bursie wrote: On 2020-04-30 14:55, Florian Weimer wrote: * Magnus Ihse Bursie: The code for setting up Java compilation has long been quite hard to understand, and has a tricky API. Part of this is due to the support for the sjavac ("smart javac&quo

Re: RFR: JDK-8244036 Refresh SetupJavaCompilation, and remove support for sjavac

2020-04-30 Thread Magnus Ihse Bursie
On 2020-04-30 14:55, Florian Weimer wrote: * Magnus Ihse Bursie: The code for setting up Java compilation has long been quite hard to understand, and has a tricky API. Part of this is due to the support for the sjavac ("smart javac") system. We do not use sjavac anymore, and it ha

Re: RFR: JDK-8244036 Refresh SetupJavaCompilation, and remove support for sjavac

2020-04-30 Thread Florian Weimer
* Magnus Ihse Bursie: > The code for setting up Java compilation has long been quite hard to > understand, and has a tricky API. Part of this is due to the support for > the sjavac ("smart javac") system. We do not use sjavac anymore, and it > has not been tested for lo

Re: RFR: JDK-8244036 Refresh SetupJavaCompilation, and remove support for sjavac

2020-04-29 Thread Magnus Ihse Bursie
o the support for the sjavac ("smart javac") system. We do not use sjavac anymore, and it has not been tested for long. Part of the sjavac effort was extracted into the "depend" javac plugin, and another part ended up as the java server, both of which we still use. This patch

Re: RFR: JDK-8244036 Refresh SetupJavaCompilation, and remove support for sjavac

2020-04-28 Thread Erik Joelsson
, Magnus Ihse Bursie wrote: The code for setting up Java compilation has long been quite hard to understand, and has a tricky API. Part of this is due to the support for the sjavac ("smart javac") system. We do not use sjavac anymore, and it has not been tested for long. Part of the sjava

RFR: JDK-8244036 Refresh SetupJavaCompilation, and remove support for sjavac

2020-04-28 Thread Magnus Ihse Bursie
The code for setting up Java compilation has long been quite hard to understand, and has a tricky API. Part of this is due to the support for the sjavac ("smart javac") system. We do not use sjavac anymore, and it has not been tested for long. Part of the sjavac effort was

Re: sjavac problems continue

2016-03-01 Thread Andreas Lundblad
On Wed, Feb 24, 2016 at 12:00:36PM +1000, David Holmes wrote: > I just had a failed JPRT build on Solaris sparc caused by: > > === Output from failing command(s) repeated here === > /usr/ccs/bin/printf "* For target >

Re: sjavac problems continue

2016-02-24 Thread Magnus Ihse Bursie
ust to add another small annoyance, it seems that if I build on Windows in >> cygwin and I cancel the build for whatever reason with CTRL+C, the sjavac >> server hangs and blocks the output directory. It takes some minutes for it >> to timeout, or I go hunting for the process in P

Re: sjavac problems continue

2016-02-24 Thread David Holmes
On 25/02/2016 4:14 AM, Andreas Lundblad wrote: On Wed, Feb 24, 2016 at 12:00:36PM +1000, David Holmes wrote: I just had a failed JPRT build on Solaris sparc caused by: Sorry to hear this. I've been ill today (not sure how I'll feel tomorrow) but I'll look into this issue before doing

Re: sjavac problems continue

2016-02-24 Thread Thomas Stüfe
l the build for whatever reason with CTRL+C, the sjavac > > server hangs and blocks the output directory. It takes some minutes for > it > > to timeout, or I go hunting for the process in Process Explorer. > > Interesting. I don't know if there's an easy solution to this one. (I.

Re: sjavac problems continue

2016-02-24 Thread Andreas Lundblad
On Wed, Feb 24, 2016 at 09:33:55AM +0100, Thomas Stüfe wrote: > Just to add another small annoyance, it seems that if I build on Windows in > cygwin and I cancel the build for whatever reason with CTRL+C, the sjavac > server hangs and blocks the output directory. It takes som

Re: sjavac problems continue

2016-02-24 Thread Andreas Lundblad
On Wed, Feb 24, 2016 at 12:00:36PM +1000, David Holmes wrote: > I just had a failed JPRT build on Solaris sparc caused by: Sorry to hear this. I've been ill today (not sure how I'll feel tomorrow) but I'll look into this issue before doing anything else. There's always the

Re: sjavac problems continue

2016-02-24 Thread Thomas Stüfe
Just to add another small annoyance, it seems that if I build on Windows in cygwin and I cancel the build for whatever reason with CTRL+C, the sjavac server hangs and blocks the output directory. It takes some minutes for it to timeout, or I go hunting for the process in Process Explorer. I

sjavac problems continue

2016-02-23 Thread David Holmes
I just had a failed JPRT build on Solaris sparc caused by: === Output from failing command(s) repeated here === /usr/ccs/bin/printf "* For target support_test_hotspot_closed_tonga_dist_java_classes__the.BUILD_JAVA_TOOLS_classes_batch:\n" * For target

Re: Sjavac build times

2016-02-21 Thread Andreas Lundblad
ava modules with > different settings. > > Attaching a chart of the result. > > Red bars: > - Plain old javac. Sjavac disabled. > > Green bars: > - Sjavac, without breaking up each module into multiple javac invocations. > (This is the default setting.) > >

Re: Sjavac build times

2016-02-20 Thread Erik Joelsson
some time measuring the build times of the java modules with different settings. Attaching a chart of the result. Red bars: - Plain old javac. Sjavac disabled. Green bars: - Sjavac, without breaking up each module into multiple javac invocations. (This is the default setting.) Blue bars

Re: Sjavac build times

2016-02-20 Thread Andreas Lundblad
ars: > - Plain old javac. Sjavac disabled. > > Green bars: > - Sjavac, without breaking up each module into multiple javac invocations. > (This is the default setting.) > > Blue bars: > - Sjavac where each module is split into three parallel javac invocations. > (Note

Sjavac build times

2016-02-19 Thread Andreas Lundblad
I spent some time measuring the build times of the java modules with different settings. Attaching a chart of the result. Red bars: - Plain old javac. Sjavac disabled. Green bars: - Sjavac, without breaking up each module into multiple javac invocations. (This is the default setting.) Blue

RFR: JDK-8147449: sjavac builds of jdk9/dev with closed sources broken

2016-01-19 Thread Erik Joelsson
Hello, Please review this fix in the makefiles for using sjavac. The include/exclude mechanism in sjavac has changed. We used to sometimes exclude files using a full absolute path. This no longer works. The same thing can be achieved by splitting up the source roots argument to sjavac

Re: RFR: JDK-8147449: sjavac builds of jdk9/dev with closed sources broken

2016-01-19 Thread Andreas Lundblad
On Tue, Jan 19, 2016 at 02:29:33PM +0100, Magnus Ihse Bursie wrote: > On 2016-01-19 11:31, Erik Joelsson wrote: > >Hello, > > > >Please review this fix in the makefiles for using sjavac. The > >include/exclude mechanism in sjavac has changed. We used to > >som

Re: RFR: JDK-8147449: sjavac builds of jdk9/dev with closed sources broken

2016-01-19 Thread Magnus Ihse Bursie
On 2016-01-19 11:31, Erik Joelsson wrote: Hello, Please review this fix in the makefiles for using sjavac. The include/exclude mechanism in sjavac has changed. We used to sometimes exclude files using a full absolute path. This no longer works. The same thing can be achieved by splitting up

RFR: JDK-8144172: Problem with bootcycle-images and sjavac

2015-11-27 Thread Erik Joelsson
Hello, The javac-server feature wasn't compatible with bootcycle-images. This fix is a bit of hack, but so was the original bootcycle implementation. We probably need to take a step back and figure out a better model for this later. Bug: https://bugs.openjdk.java.net/browse/JDK-8144172

Re: RFR: JDK-8144172: Problem with bootcycle-images and sjavac

2015-11-27 Thread Magnus Ihse Bursie
On 2015-11-27 14:28, Erik Joelsson wrote: Hello, The javac-server feature wasn't compatible with bootcycle-images. This fix is a bit of hack, but so was the original bootcycle implementation. We probably need to take a step back and figure out a better model for this later. I agree on that.

Re: RFR: JDK-8143296: javac-server/sjavac not compatible with LogFailures on Windows

2015-11-24 Thread Magnus Ihse Bursie
On 2015-11-19 12:10, Erik Joelsson wrote: On Windows, when trying to use the new javac-server mode (or sjavac), each java compilation process that spawns a javac server ends up waiting for that server to shut down before shutting down itself. This behavior is caused by the new LogFailure

RFR: JDK-8143296: javac-server/sjavac not compatible with LogFailures on Windows

2015-11-19 Thread Erik Joelsson
On Windows, when trying to use the new javac-server mode (or sjavac), each java compilation process that spawns a javac server ends up waiting for that server to shut down before shutting down itself. This behavior is caused by the new LogFailure feature, where each javac invocation is wrapped

Re: RFR: JDK-8140312: Enable new sjavac server only mode in jdk build

2015-10-27 Thread Magnus Ihse Bursie
On 2015-10-23 17:21, Magnus Ihse Bursie wrote: On 2015-10-22 12:38, Erik Joelsson wrote: In JDK-8135131, sjavac added a thin server mode, in which only the server part of sjavac is used for running plain javac. This patch adds a configure option to enable this mode of running to the jdk build

Re: RFR: JDK-8140312: Enable new sjavac server only mode in jdk build

2015-10-26 Thread Tim Bell
e wrote: On 2015-10-22 12:38, Erik Joelsson wrote: In JDK-8135131, sjavac added a thin server mode, in which only the server part of sjavac is used for running plain javac. This patch adds a configure option to enable this mode of running to the jdk build. Later, if it seems to work well, we

Re: RFR: JDK-8140312: Enable new sjavac server only mode in jdk build

2015-10-26 Thread Erik Joelsson
Erik Joelsson wrote: In JDK-8135131, sjavac added a thin server mode, in which only the server part of sjavac is used for running plain javac. This patch adds a configure option to enable this mode of running to the jdk build. Later, if it seems to work well, we will consider making it default.

Re: RFR: JDK-8140312: Enable new sjavac server only mode in jdk build

2015-10-23 Thread Magnus Ihse Bursie
On 2015-10-22 12:38, Erik Joelsson wrote: In JDK-8135131, sjavac added a thin server mode, in which only the server part of sjavac is used for running plain javac. This patch adds a configure option to enable this mode of running to the jdk build. Later, if it seems to work well, we

RFR: JDK-8140312: Enable new sjavac server only mode in jdk build

2015-10-22 Thread Erik Joelsson
In JDK-8135131, sjavac added a thin server mode, in which only the server part of sjavac is used for running plain javac. This patch adds a configure option to enable this mode of running to the jdk build. Later, if it seems to work well, we will consider making it default. On my workstation

Re: sjavac always compiled?

2015-06-10 Thread Alan Bateman
On 10/06/2015 09:00, Erik Joelsson wrote: Hello, Sjavac has always been compiled in the interim langtools step, the configure flag only affects using it to compile the rest of the java classes. Has a bug been created for this? I haven't created a bug for this as I wasn't sure

sjavac always compiled?

2015-06-10 Thread Alan Bateman
There was a sjavac update pushed to jdk9/dev yesterday (JDK-8054717). I seem to be running into build issues on OS X since then (clean build, not a reconfigure). My boot JDK is 8u31. My configure command does not specify --enable-sjavac so I'm surprised this code is being compiled. Anyone

Re: sjavac always compiled?

2015-06-10 Thread Andreas Lundblad
On Wed, Jun 10, 2015 at 09:06:44AM +0100, Alan Bateman wrote: On 10/06/2015 09:00, Erik Joelsson wrote: Hello, Sjavac has always been compiled in the interim langtools step, the configure flag only affects using it to compile the rest of the java classes. Has a bug been created

Re: sjavac always compiled?

2015-06-10 Thread Erik Joelsson
Hello, Sjavac has always been compiled in the interim langtools step, the configure flag only affects using it to compile the rest of the java classes. Has a bug been created for this? /Erik On 2015-06-10 09:53, Alan Bateman wrote: There was a sjavac update pushed to jdk9/dev yesterday

Re: RFR: 8054717: SJavac should track changes in the public apis of classpath classes!

2015-03-03 Thread Magnus Ihse Bursie
, which uses java.datatransfer (and re-exports it), where the missing class is. My best guess is that something in sjavac (API checking?) needs to traverse down into the transitive dependencies. This might be wrong, but as a workaround, it's easiest to fix in the makefiles so that we can have

Re: RFR: 8054717: SJavac should track changes in the public apis of classpath classes!

2015-03-03 Thread Erik Joelsson
I can tell, jdk.jconsole uses java.desktop, which uses java.datatransfer (and re-exports it), where the missing class is. My best guess is that something in sjavac (API checking?) needs to traverse down into the transitive dependencies. This might be wrong, but as a workaround, it's easiest

Re: RFR: 8054717: SJavac should track changes in the public apis of classpath classes!

2015-03-03 Thread Magnus Ihse Bursie
for java.awt.datatransfer.UnsupportedFlavorException not found From what I can tell, jdk.jconsole uses java.desktop, which uses java.datatransfer (and re-exports it), where the missing class is. My best guess is that something in sjavac (API checking?) needs to traverse down into the transitive dependencies. This might

Re: RFR: 8054717: SJavac should track changes in the public apis of classpath classes!

2015-03-03 Thread Erik Joelsson
it), where the missing class is. My best guess is that something in sjavac (API checking?) needs to traverse down into the transitive dependencies. This might be wrong, but as a workaround, it's easiest to fix in the makefiles so that we can have a working sjavac enabled jdk build. Here

Re: RFR: 8054717: SJavac should track changes in the public apis of classpath classes!

2015-03-03 Thread Erik Joelsson
Hello, Here is my suggestion for makefile changes to go with the sjavac changes. Adding build-dev to get review for my part. Webrev: http://cr.openjdk.java.net/~erikj/8054717/webrev.root.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8054717 /Erik On 2015-03-02 13:31, Andreas Lundblad

RFR: JDK-8069041: Bootcycle builds do not work with sjavac

2015-01-15 Thread Erik Joelsson
Hello, Please review this small patch which fixes bootcycle-images builds when enabling sjavac. The problem was that the directory where the portfile should be created is never created in the bootcycle-build output directory. I think the best and simplest solution is to just always create

RFR: JDK-8058797: Building with sjavac broken after JDK-8058118

2014-09-19 Thread Erik Joelsson
In JDK-8058118, a small java tool is compiled very early in the make process. This compilation cannot use sjavac since it's done with the boot javac. The fix is simple. Just add DISABLE_SJAVAC := true to the macro call. I also added a comment documenting this already existing feature. Bug

Re: RFR: JDK-8058797: Building with sjavac broken after JDK-8058118

2014-09-19 Thread David Holmes
Hi Erik, On 19/09/2014 6:45 PM, Erik Joelsson wrote: In JDK-8058118, a small java tool is compiled very early in the make process. This compilation cannot use sjavac since it's done with the boot javac. The fix is simple. Just add DISABLE_SJAVAC := true to the macro call. I also added a comment

Re: RFR: JDK-8058797: Building with sjavac broken after JDK-8058118

2014-09-19 Thread Erik Joelsson
On 2014-09-19 10:56, David Holmes wrote: Hi Erik, On 19/09/2014 6:45 PM, Erik Joelsson wrote: In JDK-8058118, a small java tool is compiled very early in the make process. This compilation cannot use sjavac since it's done with the boot javac. The fix is simple. Just add DISABLE_SJAVAC

Re: RFR: JDK-8058797: Building with sjavac broken after JDK-8058118

2014-09-19 Thread Magnus Ihse Bursie
On 2014-09-19 10:45, Erik Joelsson wrote: In JDK-8058118, a small java tool is compiled very early in the make process. This compilation cannot use sjavac since it's done with the boot javac. The fix is simple. Just add DISABLE_SJAVAC := true to the macro call. I also added a comment

Re: RFR: JDK-8055922: Work around sjavac limitation with public api tracking cross modules

2014-08-26 Thread Erik Joelsson
. /Erik On 2014-08-25 16:50, Erik Joelsson wrote: Hello, Please review this little workaround for a current shortcoming in Sjavac. See bug for more details. With this change, Sjavac will start acting correctly again and not miss any files that need to be recompiled. The approximation is course

Re: RFR: JDK-8055922: Work around sjavac limitation with public api tracking cross modules

2014-08-26 Thread Magnus Ihse Bursie
On 2014-08-26 11:58, Erik Joelsson wrote: Updated webrev: http://cr.openjdk.java.net/~erikj/8055922/webrev.root.02/ Some of the demos failed to compile because the javac_state file did not contain any public api and this caused grep to exit with code 1, which failed the build. I made exit

Re: RFR 8054717: SJavac should track changes in the public apis of classpath classes!

2014-08-26 Thread Fredrik Öhrström
It seems like the development speed for sjavac needs to be increased significantly, one JIRA bug, one 2 week review cycle, leads to one commit is much too slow. I belive it would be good to have a separate repository to do quicker development of sjavac, and test out all sorts of interesting stuff

RFR: JDK-8055922: Work around sjavac limitation with public api tracking cross modules

2014-08-25 Thread Erik Joelsson
Hello, Please review this little workaround for a current shortcoming in Sjavac. See bug for more details. With this change, Sjavac will start acting correctly again and not miss any files that need to be recompiled. The approximation is course however, we should still fix https

Re: RFR: 8014510: Fix sjavac on all platforms in jprt

2014-08-23 Thread Andreas Lundblad
construct, so I changed that into a simple MEMORY_SIZE/2 for sjavac server mx flag. Then I did some tests on my machine and with the modules build, sjavac really isn't that memory intensive anymore. I set a cap at 2GB (1,5 for 32 bit jvms) and also set a minimum of 512M, which I have verified

RFR: 8014510: Fix sjavac on all platforms in jprt

2014-08-20 Thread Andreas Lundblad
Hi build-dev, Please review the fix for JDK-8014510: Fix sjavac on all platforms in jprt Description: JPRT jobs fail (on Sparc) with sjavac enabled. This is because the JVM can't allocate the requested amount of memory upon launch. This patch changes the the -Xms setting (which ranges from 1G

RFR: 8037085: add support to sjavac to exclude/include directory names instead of only package names.

2014-04-16 Thread Fredrik Öhrström
The previous RFR tried to solve both this simple problem and the larger rewrite of the options but seems to be stalled due to problems with the Windows build. Since it is very inconvenient to have a broken sjavac in jdk9/jdk9, perhaps someone within Oracle could take this simple patch (almost

Re: RFR: 8035063: Option handling in sjavac needs to be rewritten

2014-03-21 Thread Joel Borggren-Franck
Hi, On 2014-03-19, Andreas Lundblad wrote: Hi compiler-dev + build-dev, Please review the fix for JDK-8035063 and JDK-8037085 which involves changes to sjavac (option handling) and dev/ + dev/jdk build files. Description: - Sjavac relied on passing around the main arg array

Re: RFR: 8035063: Option handling in sjavac needs to be rewritten

2014-03-20 Thread Fredrik Öhrström
Ok, Eriks explanation makes sense. There might also be situations where you want to exclude/include copying META-INF files and such, that reside in non-package directories. So, changing from . to / is ok. In particular since sjavac cleverly detects and reports an error, if a source file

RFR: 8035063: Option handling in sjavac needs to be rewritten

2014-03-19 Thread Andreas Lundblad
Hi compiler-dev + build-dev, Please review the fix for JDK-8035063 and JDK-8037085 which involves changes to sjavac (option handling) and dev/ + dev/jdk build files. Description: - Sjavac relied on passing around the main arg array to whatever part of the code that were potentially affected

Re: RFR: 8035063: Option handling in sjavac needs to be rewritten

2014-03-19 Thread Erik Joelsson
-8035063 and JDK-8037085 which involves changes to sjavac (option handling) and dev/ + dev/jdk build files. Description: - Sjavac relied on passing around the main arg array to whatever part of the code that were potentially affected by command line options. The patch restructures the code so

Re: RFR: 8035063: Option handling in sjavac needs to be rewritten

2014-03-19 Thread Andreas Lundblad
On Wed, Mar 19, 2014 at 10:03:33AM +0100, Erik Joelsson wrote: Hello, The input from our makefiles changes from -i some.package to -i some/package/*. IIRC the include flag works recursively for sub packages. Will the single * do the same? /Erik That's strange. What used to be -i

Re: RFR: 8035063: Option handling in sjavac needs to be rewritten

2014-03-19 Thread Erik Joelsson
Ah, I see now, it was -i some.package.* in the original code. Build part looks good to me now. /Erik On 2014-03-19 11:17, Andreas Lundblad wrote: On Wed, Mar 19, 2014 at 10:03:33AM +0100, Erik Joelsson wrote: Hello, The input from our makefiles changes from -i some.package to -i

Re: RFR: 8035063: Option handling in sjavac needs to be rewritten

2014-03-19 Thread Andreas Lundblad
will not find that source through -sourcepath, which means that you just broke sjavac ability to compile using multiple threads. This is just as bad as when Nashorn tried to insert $ into java source file names! The horror, the horror. I.e. do not replace . with /. Fix the problem in the jdk

Re: RFR: 8035063: Option handling in sjavac needs to be rewritten

2014-03-19 Thread Magnus Ihse Bursie
On 2014-03-19 09:49, Andreas Lundblad wrote: Hi compiler-dev + build-dev, Please review the fix for JDK-8035063 and JDK-8037085 which involves changes to sjavac (option handling) and dev/ + dev/jdk build files. The build part looks good to me. /Magnus

Re: RFR: 8035063: Option handling in sjavac needs to be rewritten

2014-03-19 Thread Erik Joelsson
\ sun/util/cldr/resources \ # When building with sjavac, these get translated to -e java.awt.doc-files.* which sjavac does not accept, because doc-files are not proper package names. Another possible fix would be to filter out non valid package names from the excludes sent to sjavac

Re: RFR: 8035063: Option handling in sjavac needs to be rewritten

2014-03-19 Thread Fredrik Öhrström
sjavac ability to compile using multiple threads. This is just as bad as when Nashorn tried to insert $ into java source file names! The horror, the horror. I.e. do not replace . with /. Fix the problem in the jdk. //Fredrik 2014-03-19 12:29 GMT+01:00 Erik Joelsson erik.joels...@oracle.com

hg: jdk8/build: 8014514: Fix jvm args for sjavac

2013-05-23 Thread erik . joelsson
Changeset: e247ee3924d5 Author:erikj Date: 2013-05-22 17:26 +0200 URL: http://hg.openjdk.java.net/jdk8/build/rev/e247ee3924d5 8014514: Fix jvm args for sjavac Reviewed-by: tbell ! common/autoconf/basics.m4 ! common/autoconf/build-performance.m4 ! common/autoconf/generated

Re: RFR: 8014514: Fix jvm args for sjavac

2013-05-15 Thread Erik Joelsson
On 2013-05-15 06:21, David Holmes wrote: On 15/05/2013 12:34 AM, Erik Joelsson wrote: This patch tries to be smarter when figuring out optimal jvm args for sjavac, especially if the jvm used is 32bit. http://cr.openjdk.java.net/~erikj/8014514/webrev.root.01/ For this to work properly, two

Re: RFR: 8014514: Fix jvm args for sjavac

2013-05-15 Thread Erik Joelsson
On 2013-05-15 09:01, Erik Joelsson wrote: On 2013-05-15 06:21, David Holmes wrote: On 15/05/2013 12:34 AM, Erik Joelsson wrote: This patch tries to be smarter when figuring out optimal jvm args for sjavac, especially if the jvm used is 32bit. http://cr.openjdk.java.net/~erikj/8014514

Re: RFR: 8014514: Fix jvm args for sjavac

2013-05-14 Thread Tim Bell
Erik: This patch tries to be smarter when figuring out optimal jvm args for sjavac, especially if the jvm used is 32bit. http://cr.openjdk.java.net/~erikj/8014514/webrev.root.01/ Looks good. Tim

Re: RFR: 8014514: Fix jvm args for sjavac

2013-05-14 Thread David Holmes
On 15/05/2013 12:34 AM, Erik Joelsson wrote: This patch tries to be smarter when figuring out optimal jvm args for sjavac, especially if the jvm used is 32bit. http://cr.openjdk.java.net/~erikj/8014514/webrev.root.01/ For this to work properly, two patches to the sjavac src langtools are also

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-11 Thread Naoto Sato
for clarifying that. Makes sense to me. The fix looks good to me, btw, although I'm not a build expert. Also, could you clarify why do Windows builds fail with sjavac? Is this a known bug in sjavac or the build system? It looks to me like a bug in sjavac. I have seen it work previously

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-11 Thread Jonathan Gibbons
/8/2013 5:21 PM, Erik Joelsson wrote: On 2013-04-08 15:17, Anthony Petrov wrote: Thanks for clarifying that. Makes sense to me. The fix looks good to me, btw, although I'm not a build expert. Also, could you clarify why do Windows builds fail with sjavac? Is this a known bug in sjavac

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-09 Thread Anthony Petrov
clarify why do Windows builds fail with sjavac? Is this a known bug in sjavac or the build system? It looks to me like a bug in sjavac. I have seen it work previously. /Erik -- best regards, Anthony On 04/08/13 17:03, Erik Joelsson wrote: Sjavac also enables parallel execution of java

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Erik Joelsson
Reminder that I would like this reviewed. /Erik On 2013-03-21 12:49, Erik Joelsson wrote: This patch makes it possible to enable sjavac in jprt runs. This is achieved by adding -buildenv ENABLE_SJAVAC=true to the jprt command line. http://cr.openjdk.java.net/~erikj/8010465/webrev.root.01

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Erik Joelsson
Sjavac also enables parallel execution of java compilation, speeding up full builds as well. But even if it didn't, being able to verify that sjavac builds work in jprt will be a must if we are to enable it by default. /Erik On 2013-04-08 14:56, Anthony Petrov wrote: Just curious: sjavac

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Anthony Petrov
Thanks for clarifying that. Makes sense to me. The fix looks good to me, btw, although I'm not a build expert. Also, could you clarify why do Windows builds fail with sjavac? Is this a known bug in sjavac or the build system? -- best regards, Anthony On 04/08/13 17:03, Erik Joelsson wrote

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Erik Joelsson
On 2013-04-08 15:17, Anthony Petrov wrote: Thanks for clarifying that. Makes sense to me. The fix looks good to me, btw, although I'm not a build expert. Also, could you clarify why do Windows builds fail with sjavac? Is this a known bug in sjavac or the build system? It looks to me like

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Alexander Scherbatiy
On 4/8/2013 5:21 PM, Erik Joelsson wrote: On 2013-04-08 15:17, Anthony Petrov wrote: Thanks for clarifying that. Makes sense to me. The fix looks good to me, btw, although I'm not a build expert. Also, could you clarify why do Windows builds fail with sjavac? Is this a known bug in sjavac

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Kelly O'Hair
Looks ok with me. ;^) -kto On 4/8/13 2:44 AM, Erik Joelsson erik.joels...@oracle.com wrote: Reminder that I would like this reviewed. /Erik On 2013-03-21 12:49, Erik Joelsson wrote: This patch makes it possible to enable sjavac in jprt runs. This is achieved by adding -buildenv

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Tim Bell
Hi Erik: This looks good - approved. Sorry for the delay. Tim Reminder that I would like this reviewed. /Erik On 2013-03-21 12:49, Erik Joelsson wrote: This patch makes it possible to enable sjavac in jprt runs. This is achieved by adding -buildenv ENABLE_SJAVAC=true to the jprt command

Re: sjavac

2013-03-15 Thread Andrew Hughes
- Original Message - The Nashorn team is wondering about the status of sjavac and the builds. Note: https://jbs.oracle.com/bugs/browse/JDK-8009788 . There are two occurances of -cp which should be convered to -classpath in makefiles/BuildNashorn.gmk . Cheers, -- Jim

Re: sjavac

2013-03-15 Thread Martin Buchholz
(As I've complained about recently) Not all jdk commands (e.g. javap, and apparently sjavac) consistently support either both or neither of '-cp' and '-classpath' as synonyms. But that's being fixed. On Fri, Mar 15, 2013 at 10:57 AM, Andrew Hughes gnu.and...@redhat.comwrote: - Original

sjavac

2013-03-11 Thread Jim Laskey (Oracle)
The Nashorn team is wondering about the status of sjavac and the builds. Note: https://jbs.oracle.com/bugs/browse/JDK-8009788 . There are two occurances of -cp which should be convered to -classpath in makefiles/BuildNashorn.gmk . Cheers, -- Jim

Re: sjavac

2013-03-11 Thread Jonathan Gibbons
On 03/11/2013 11:33 AM, Jim Laskey (Oracle) wrote: The Nashorn team is wondering about the status of sjavac and the builds. Note: https://jbs.oracle.com/bugs/browse/JDK-8009788 . There are two occurances of -cp which should be convered to -classpath in makefiles/BuildNashorn.gmk . Cheers

Re: sjavac

2013-03-11 Thread Jonathan Gibbons
On 03/11/2013 12:39 PM, Martin Buchholz wrote: While you're there, consider checking/modfying all of the jdk tools to accept either both or neither of -cp and -classpath. javap is the command I'm thinking of. Noted. -- Jon

Re: sjavac

2013-03-11 Thread Jonathan Gibbons
On 03/11/2013 11:33 AM, Jim Laskey (Oracle) wrote: The Nashorn team is wondering about the status of sjavac and the builds. Note: https://jbs.oracle.com/bugs/browse/JDK-8009788 . There are two occurances of -cp which should be convered to -classpath in makefiles/BuildNashorn.gmk . Cheers

build failure in nashorn with sjavac enabled

2013-03-01 Thread Maurizio Cimadamore
Hi, I was doing experiments with the recently added sjavac flag to enable smart recompilation of JDK classes. I got a failure in Nashorn (I'm building on linux x64, Ubuntu 11.10): ## Starting nashorn Compiling BUILD_NASHORN Compiling 106 files in 7 packages (jdk.internal.dynalink

Re: sjavac in jdk 8 builds

2013-02-11 Thread David Katleman
On 2/11/2013 1:56 PM, Vita Santrucek wrote: I see that sjavac was pushed in b75: but in our logs we seem to disable it: … checking whether to use sjavac… no ... [3] DISABLE_SJAVAC:=true ... Why don't we use it when building JDK 8? It's not that we disable it, autoconf does that for any

Re: sjavac in jdk 8 builds

2013-02-11 Thread Erik Joelsson
What David says is correct. We hope to enable it by default soon, but feel that it could use some hardening first. /Erik On 2013-02-11 23:42, David Katleman wrote: On 2/11/2013 1:56 PM, Vita Santrucek wrote: I see that sjavac was pushed in b75: but in our logs we seem to disable

Re: --enable-sjavac not enabled in tl repo yet?

2013-01-18 Thread Weijun Wang
On 01/18/2013 02:58 PM, Fredrik Öhrström wrote: 18 jan 2013 kl. 03:07 skrev Weijun Wang: Just tried on a latest jdk8/tl clone and The makefile listed source /space/repos/jdk8/tl/build/linux-x86_64-sjavac/langtools/gensrc/com/sun/tools/doclint/resources/doclint.java was not calculated

Re: --enable-sjavac not enabled in tl repo yet?

2013-01-18 Thread Fredrik Öhrström
2013/1/18 Weijun Wang weijun.w...@oracle.com: I just find something interesting. /space on my machine is a symlink to /home/more/space. If I cd to /home/more/space/repos/jdk8/tl/build/linux-x86_64-sjavac and configure/make there, everything is fine. Ah, then sjavac is probably doing canonical

--enable-sjavac not enabled in tl repo yet?

2013-01-17 Thread Weijun Wang
Just tried on a latest jdk8/tl clone and Building Java(TM) for target 'all' in configuration '/space/repos/jdk8/tl/build/linux-x86_64-sjavac' ## Starting langtools Compiling 2 files for BUILD_TOOLS Compiling 26 properties into resource bundles Compiling 720 files for BUILD_BOOTSTRAP_LANGTOOLS

Re: --enable-sjavac not enabled in tl repo yet?

2013-01-17 Thread Jonathan Gibbons
Anyone else having trouble deciphering the error message: The makefile listed source /space/repos/jdk8/tl/build/linux-x86_64-sjavac/langtools/gensrc/com/sun/tools/doclint/resources/doclint.java was not calculated by the smart javac wrapper! -- Jon On 01/17/2013 06:07 PM, Weijun Wang wrote

Re: --enable-sjavac not enabled in tl repo yet?

2013-01-17 Thread Fredrik Öhrström
18 jan 2013 kl. 03:07 skrev Weijun Wang: Just tried on a latest jdk8/tl clone and The makefile listed source /space/repos/jdk8/tl/build/linux-x86_64-sjavac/langtools/gensrc/com/sun/tools/doclint/resources/doclint.java was not calculated by the smart javac Ok, as the old saying goes

Re: --enable-sjavac not enabled in tl repo yet?

2013-01-17 Thread Fredrik Öhrström
The fix for moving a few source files for the awt bean info classes has not yet propagated into tl, from build. Until then, the tl with --enable-sjavac build will stop somewhere in the jdk when generating sources for awt bean infos. //Fredrik

  1   2   >