On 3/04/2013 1:03 PM, Mike Duigou wrote:
Hello all;
Further testing on JDK-8011342 revealed that hgforest.sh can fail if the sh
shell is not bash. The problem appears to be due to mixing of -o -a and ! in []
test expressions.
What a bizarre failure mode. In the tests I did:
/usr/local/bin/p
On 2013-04-02 18:56, Andrew Hughes wrote:
With the new build system, the availability of debugging information in the
JDK build is a complete mess, controlled by different flags from those that
control the HotSpot build.
Even when debugging is asked for, it is only turned on for a small number o
This looks good to me. Thanks!
/Erik
On 2013-04-02 23:17, Omair Majid wrote:
Hi,
Updated patch at:
http://cr.openjdk.java.net/~omajid/webrevs/zero-newbuild/02/
On 04/02/2013 05:21 AM, Erik Joelsson wrote:
I know it's not always obvious where things belong but I would put the
INCLUDE_SA logic
Tim,
Looks good to me.
/Erik
On 2013-04-03 04:42, Tim Bell wrote:
All -
I regret the fact that I did not test the fix for 8009988 (see below)
when I reviewed it. The script as written there assumes that the
'which' utility will return nothing if the command is not found. On
some platform
I'm all for requiring bash. We already did for configure and autogen.sh,
so the damage is already done.
/Erik
On 2013-04-03 09:21, David Holmes wrote:
On 3/04/2013 1:03 PM, Mike Duigou wrote:
Hello all;
Further testing on JDK-8011342 revealed that hgforest.sh can fail if
the sh shell is not
In IdlCompilation.gmk there is a cp line with the -p flag. I can see no
apparent reason for this flag and it was reported that it causes
problems when building over NFS in certain situations. This patch
removes the flag.
http://cr.openjdk.java.net/~erikj/8011372/webrev.01/
/Erik
Yup, fine for me as well! (I'm not a reviewer though... just an opinion)
Roman
Am Mittwoch, den 03.04.2013, 10:28 +0200 schrieb Erik Joelsson:
> This looks good to me. Thanks!
>
> /Erik
>
> On 2013-04-02 23:17, Omair Majid wrote:
> > Hi,
> >
> > Updated patch at:
> > http://cr.openjdk.java.net/
Looks good. Thanks for fixing this!
/Per
On 2013-04-03 12:02, Erik Joelsson wrote:
In IdlCompilation.gmk there is a cp line with the -p flag. I can see
no apparent reason for this flag and it was reported that it causes
problems when building over NFS in certain situations. This patch
removes
- Original Message -
> Yup, fine for me as well! (I'm not a reviewer though... just an opinion)
>
> Roman
>
> Am Mittwoch, den 03.04.2013, 10:28 +0200 schrieb Erik Joelsson:
> > This looks good to me. Thanks!
> >
> > /Erik
> >
> > On 2013-04-02 23:17, Omair Majid wrote:
> > > Hi,
> > >
- Original Message -
> On 2013-04-02 18:56, Andrew Hughes wrote:
> > With the new build system, the availability of debugging information in the
> > JDK build is a complete mess, controlled by different flags from those that
> > control the HotSpot build.
> >
> > Even when debugging is aske
On 2013-04-03 16:54, Andrew Hughes wrote:
- Original Message -
Yup, fine for me as well! (I'm not a reviewer though... just an opinion)
Roman
Am Mittwoch, den 03.04.2013, 10:28 +0200 schrieb Erik Joelsson:
This looks good to me. Thanks!
/Erik
On 2013-04-02 23:17, Omair Majid wrote:
An alternative has been suggested: convert the hgforest.sh script to a bash
script. I have tested this alternative on unbuntu linux 11.04, solaris 10u9,
MacOS 10.7 and cygwin 1.7.17. This seems like less risk and there doesn't seem
to be a compelling reason to stick with classic sh.
I have prep
Hi Erik:
In IdlCompilation.gmk there is a cp line with the -p flag. I can see
no apparent reason for this flag and it was reported that it causes
problems when building over NFS in certain situations. This patch
removes the flag.
http://cr.openjdk.java.net/~erikj/8011372/webrev.01/
Looks g
On Apr 3 2013, at 16:09 , David Holmes wrote:
> On 4/04/2013 1:56 AM, Mike Duigou wrote:
>> An alternative has been suggested: convert the hgforest.sh script to a bash
>> script. I have tested this alternative on unbuntu linux 11.04, solaris 10u9,
>> MacOS 10.7 and cygwin 1.7.17. This seems lik
On 4/04/2013 1:56 AM, Mike Duigou wrote:
An alternative has been suggested: convert the hgforest.sh script to a bash
script. I have tested this alternative on unbuntu linux 11.04, solaris 10u9,
MacOS 10.7 and cygwin 1.7.17. This seems like less risk and there doesn't seem
to be a compelling re
I've received some feedback from Tim Bell and David Katleman.
Here's an updated version of the patch.
http://cr.openjdk.java.net/~mduigou/JDK-8011350/2
It turns out the real shell incompatibility was more straightforward. The
outright conversion to bash isn't necessary. Replacement of '==' with
Looks good to me, Mike
Thanks - a seemingly simple change inflated into a small project when
tested on multiple O/S platforms.
Tim
On 04/03/13 16:30, Mike Duigou wrote:
I've received some feedback from Tim Bell and David Katleman.
Here's an updated version of the patch.
http://cr.openjdk.j
Approved.
Glad it was simple double quote and "==" usage, rather than requiring
substantial change.
Dave
On 4/3/2013 4:30 PM, Mike Duigou wrote:
I've received some feedback from Tim Bell and David Katleman.
Here's an updated version of the patch.
http://cr.openjdk.java.net/~mduigou
On 4/2/2013 7:42 PM, Tim Bell wrote:
All -
I regret the fact that I did not test the fix for 8009988 (see below)
when I reviewed it. The script as written there assumes that the
'which' utility will return nothing if the command is not found. On
some platforms (Solaris and Windows/Cygwin t
On 4/04/2013 9:30 AM, Mike Duigou wrote:
I've received some feedback from Tim Bell and David Katleman.
Here's an updated version of the patch.
http://cr.openjdk.java.net/~mduigou/JDK-8011350/2
It turns out the real shell incompatibility was more straightforward. The
outright conversion to bas
On Apr 3 2013, at 20:14 , David Holmes wrote:
> On 4/04/2013 9:30 AM, Mike Duigou wrote:
>> I've received some feedback from Tim Bell and David Katleman.
>>
>> Here's an updated version of the patch.
>>
>> http://cr.openjdk.java.net/~mduigou/JDK-8011350/2
>>
>> It turns out the real shell inco
On 4/04/2013 1:22 PM, Mike Duigou wrote:
On Apr 3 2013, at 20:14 , David Holmes wrote:
On 4/04/2013 9:30 AM, Mike Duigou wrote:
I've received some feedback from Tim Bell and David Katleman.
Here's an updated version of the patch.
http://cr.openjdk.java.net/~mduigou/JDK-8011350/2
It turns o
On 4/04/2013 11:45 AM, Tim Bell wrote:
Looks good to me, Mike
Thanks - a seemingly simple change inflated into a small project when
tested on multiple O/S platforms.
Indeed. A main take away from this exercise is that any changes to
scripts need extensive cross-platform testing before they ar
On 04/03/13 19:14, David Katleman wrote:
On 4/2/2013 7:42 PM, Tim Bell wrote:
All -
I regret the fact that I did not test the fix for 8009988 (see below)
when I reviewed it. The script as written there assumes that the
'which' utility will return nothing if the command is not found. On
so
24 matches
Mail list logo
