Yup, fine for me as well! (I'm not a reviewer though... just an opinion) Roman
Am Mittwoch, den 03.04.2013, 10:28 +0200 schrieb Erik Joelsson: > This looks good to me. Thanks! > > /Erik > > On 2013-04-02 23:17, Omair Majid wrote: > > Hi, > > > > Updated patch at: > > http://cr.openjdk.java.net/~omajid/webrevs/zero-newbuild/02/ > > > > On 04/02/2013 05:21 AM, Erik Joelsson wrote: > >> I know it's not always obvious where things belong but I would put the > >> INCLUDE_SA logic in jdk-options.m4 somewhere close after the JVM_VARIANT > >> variables have been assigned. > > How about right after it? :) > > > > Thanks, > > Omair > >
