Re: URGENT: Request for review: 7122222: GC log is limited to 2G for 32-bit

2013-06-05 Thread Mikael Gerdin
On 2013-06-05 02:21, Daniel D. Daugherty wrote: OK, based on the largefiles.pdf write-up, your use of _FILE_OFFSET_BITS=64 is going to cause ostream.o to bind to various 64-bit versions of some functions. Based on my very hazy memory of my days in file system code, this binding is going to affe

Re: Add optional support for using the system libicu

2013-06-05 Thread Erik Joelsson
Hello, Is it required to remove the font/layout dir to use the system version? I would expect USE_EXTERNAL_ICU_LE=true would add an exclude for that directory to SetupNativeCompilation,BUILD_LIBFONTMANAGER. If you expect to delete the source tree on your side, why not have configure check fo

Re: A small bug: F# in $PATH

2013-06-05 Thread David Chase
On 2013-06-04, at 11:22 PM, Tim Bell wrote: > Hi Max: > >> I'm trying to build 32-bit openjdk on a Windows machine. My Visual Studio >> 2010 installation includes F#, > > That is why the README [1] advises ''Only the C++ part of VS2010 is needed". That's a misleading instruction, since it se

Heads-up: Integration of Event-Based JVM Tracing

2013-06-05 Thread Staffan Larsen
All, We are planning to integrate "Event-Based JVM Tracing" into hotspot-rt next week. This is (more or less) a forward port of the implementation that already exists in jdk7u. The main difference compared to jdk7u is the adaptations made to support metaspace instead of permgen. The changes hav

Re: URGENT: Request for review: 7122222: GC log is limited to 2G for 32-bit

2013-06-05 Thread Tao Mao
Thank you for comments. One thing I want to point out is that the current change has not touched on Windows code. Please see inline. Tao On 6/5/13 1:19 AM, Mikael Gerdin wrote: On 2013-06-05 02:21, Daniel D. Daugherty wrote: OK, based on the largefiles.pdf write-up, your use of _FILE_OFFSE

Re: URGENT: Request for review: 7122222: GC log is limited to 2G for 32-bit

2013-06-05 Thread Mikael Gerdin
Tao, On 2013-06-05 17:48, Tao Mao wrote: Thank you for comments. One thing I want to point out is that the current change has not touched on Windows code. Please see inline. Tao On 6/5/13 1:19 AM, Mikael Gerdin wrote: On 2013-06-05 02:21, Daniel D. Daugherty wrote: OK, based on the largef

Re: URGENT: Request for review: 7122222: GC log is limited to 2G for 32-bit

2013-06-05 Thread Daniel D. Daugherty
On 6/5/13 10:02 AM, Mikael Gerdin wrote: Tao, On 2013-06-05 17:48, Tao Mao wrote: Thank you for comments. One thing I want to point out is that the current change has not touched on Windows code. Please see inline. Tao On 6/5/13 1:19 AM, Mikael Gerdin wrote: On 2013-06-05 02:21, Daniel D.

Re: URGENT: Request for review: 7122222: GC log is limited to 2G for 32-bit

2013-06-05 Thread Tao Mao
Hi Mikael, Let me explain the changeset first before I go into your comments. (1) make/linux/makefiles/vm.make # Large File Support ifneq ($(LP64), 1) CXXFLAGS/ostream.o += -D_FILE_OFFSET_BITS=64 endif # ifneq ($(LP64), 1) For "Linux" code, set _FILE_OFFSET_BITS=64 "only" to ostream.o (i.e. o

Re: Add optional support for using the system libicu

2013-06-05 Thread Phil Race
Omair, Since this entirely affects a 2D component, please include 2d-dev in this discussion. I would have been 'surprised' to see this change if I hadn't just spotted this thread. And I believe this change should be integrated via the 2D forest. Yes, please support the old build system. I am no

Re: Add optional support for using the system libicu

2013-06-05 Thread Alan Bateman
On 05/06/2013 19:02, Phil Race wrote: Yes, please support the old build system. Is this really necessary? The old build is a tax and we really need it to die. In this case, it's a new feature and I don't see any point in anyone spending time adding this support to the old build. -Alan

Re: Add optional support for using the system libicu

2013-06-05 Thread Phil Race
Heavens no. Its a blessing. I sometimes do development work in 7 because I can't get the new build to work, or to work the way I want. I don't think I've ever gotten it to build on Windows. The old build saves me time, disk space and repo maintenance headaches. -phil. On 6/5/2013 1:40 PM, Alan B

Re: Add optional support for using the system libicu

2013-06-05 Thread Joe Darcy
I don't think it is tenable to have long-term maintenance of two build systems. Any remaining blockers in the new build should be addressed so the old build can be put out to pasture. -Joe On 6/5/2013 1:50 PM, Phil Race wrote: Heavens no. Its a blessing. I sometimes do development work in 7 b

Re: Add optional support for using the system libicu

2013-06-05 Thread Jonathan Gibbons
On 06/05/2013 02:50 PM, Joe Darcy wrote: I don't think it is tenable to have long-term maintenance of two build systems. Any remaining blockers in the new build should be addressed so the old build can be put out to pasture. -Joe ... implying that we should make sure that blockers are filed

hg: jdk8/build: 6983966: remove lzma and upx from repository JDK8

2013-06-05 Thread david . katleman
Changeset: 27c51c6e31c1 Author:katleman Date: 2013-06-05 15:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/27c51c6e31c1 6983966: remove lzma and upx from repository JDK8 Reviewed-by: tbell, paulk, ngthomas ! common/autoconf/generated-configure.sh ! common/makefiles/Jprt.gm

hg: jdk8/build/jdk: 6983966: remove lzma and upx from repository JDK8

2013-06-05 Thread david . katleman
Changeset: 691d6c6cd332 Author:katleman Date: 2013-06-05 15:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/691d6c6cd332 6983966: remove lzma and upx from repository JDK8 Reviewed-by: tbell, paulk, ngthomas ! make/common/Defs-windows.gmk

INFO: ENABLE_FULL_DEBUG_SYMBOLS=1, etc., in build log

2013-06-05 Thread mark . reinhold
The following lines are repeated over and over when building JDK 8: INFO: ENABLE_FULL_DEBUG_SYMBOLS=1 INFO: ALT_OBJCOPY=/usr/bin/objcopy INFO: /usr/bin/objcopy cmd found so will create .debuginfo files. INFO: STRIP_POLICY=min_strip INFO: ZIP_DEBUGINFO_FILES=1 It seems like a lot of noi

Re: INFO: ENABLE_FULL_DEBUG_SYMBOLS=1, etc., in build log

2013-06-05 Thread David Holmes
Hi Mark, On 6/06/2013 8:40 AM, mark.reinh...@oracle.com wrote: The following lines are repeated over and over when building JDK 8: INFO: ENABLE_FULL_DEBUG_SYMBOLS=1 INFO: ALT_OBJCOPY=/usr/bin/objcopy INFO: /usr/bin/objcopy cmd found so will create .debuginfo files. INFO: STRIP_POLIC

Re: INFO: ENABLE_FULL_DEBUG_SYMBOLS=1, etc., in build log

2013-06-05 Thread mark . reinhold
2013/6/5 10:22 -0700, david.hol...@oracle.com: > This comes from hotspot build. The FDS processing happens in a file that > is included a number of times due to the nested make invocations that > happen with hotspot. Consequently this gets repeated a few times > (actually fewer than it used to)