I thought one was sufficient, but you have an OK from me too.
/Erik
On 2013-08-20 21:32, Omair Majid wrote:
Hi,
On 08/15/2013 12:46 AM, David Holmes wrote:
On 14/08/2013 1:53 AM, Omair Majid wrote:
Updated webrev:
http://cr.openjdk.java.net/~omajid/webrevs/zero-jvm-config/01/
That looks goo
Looks good.
/Staffan
On 20 aug 2013, at 23:11, Ioi Lam wrote:
> Please review a very small fix:
>
> http://cr.openjdk.java.net/~iklam/8023406/windows_build_vm_def_slow_001/
>
> Bug: make/windows/build_vm_def.sh takes too long even when BUILD_WIN_SA != 1
>
> http://bugs.sun.com/bugdat
Thanks, updated webrev:
http://cr.openjdk.java.net/~erikj/8023216/webrev.root.02/
/Erik
On 2013-08-19 16:38, Dalibor Topic wrote:
On 8/19/13 2:43 PM, Erik Joelsson wrote:
And again, here we go:
http://cr.openjdk.java.net/~erikj/8023216/webrev.root.01/
A few typos:
javascript -> JavaScript
Nice, thanks.
On 8/21/13 2:53 PM, Erik Joelsson wrote:
> Thanks, updated webrev:
>
> http://cr.openjdk.java.net/~erikj/8023216/webrev.root.02/
>
> /Erik
>
> On 2013-08-19 16:38, Dalibor Topic wrote:
>> On 8/19/13 2:43 PM, Erik Joelsson wrote:
>>> And again, here we go:
>>>
>>> http://cr.openjdk
Looks good to me as well.
Tim
On 08/21/13 05:55 AM, Dalibor Topic wrote:
Nice, thanks.
On 8/21/13 2:53 PM, Erik Joelsson wrote:
Thanks, updated webrev:
http://cr.openjdk.java.net/~erikj/8023216/webrev.root.02/
/Erik
On 2013-08-19 16:38, Dalibor Topic wrote:
On 8/19/13 2:43 PM, Erik Joelss
On 08/21/2013 04:16 AM, Erik Joelsson wrote:
> I thought one was sufficient, but you have an OK from me too.
>
Whoops. Did I confuse the hotspot reviewer requirements with build-dev
reviewer requrirements?
Can I get a bug id?
Thanks,
Omair
> On 2013-08-20 21:32, Omair Majid wrote:
>> Hi,
>>
>>
On 2013-08-21 16:03, Omair Majid wrote:
On 08/21/2013 04:16 AM, Erik Joelsson wrote:
I thought one was sufficient, but you have an OK from me too.
Whoops. Did I confuse the hotspot reviewer requirements with build-dev
reviewer requrirements?
As I understand the OpenJDK requirements, it's just
Hello all;
This review is for changes related to Alan's change JDK-8023351. This changeset
removes knowledge of the test suites from the root repo test/Makefile and
merely runs the sub-repo test/Makefile with the matching selection of targets.
It also corrects issues with running the the langto
Good catch! I tried to sneak this in :-)
SKIP_GENERATED can be set as an environment variable to skip the
'generated' directory. I have an external script that checks if the file
generated/_build_pch_file.cpp already exists. If so, it will set
SKIP_GENERATED=1 before calling build.bat. This wo
build-dev folks, any comments?
I have updated the patch to remove the SKIP_GENERATED changes:
http://cr.openjdk.java.net/~iklam/8023406/windows_build_vm_def_slow_002/
Thanks
- Ioi
On 08/21/2013 09:57 AM, Ioi Lam wrote:
Good catch! I tried to sneak this in :-)
SKIP_GENERATED can be set as an
My Win 7 x 64 showed it had approx 2GB (out of 6GB) memory free when I
got this message
doing an incremental build :-
## Starting langtools
/cygdrive/c/jdks/jdk8_2d/common/bin/logger.sh: fork: retry: Resource
temporarily unavailable
/cygdrive/c/jdks/jdk8_2d/common/bin/logger.sh: fork: retry: Re
Hello Ioi:
build-dev folks, any comments?
I have updated the patch to remove the SKIP_GENERATED changes:
http://cr.openjdk.java.net/~iklam/8023406/windows_build_vm_def_slow_002/
make/windows/build_vm_def.sh
Seems as if line 86:
86 "$CAT" vm1.def vm2.def > vm.def
Will clobber the friendly
On 08/21/13 12:34 PM, Tim Bell wrote:
Hello Ioi:
build-dev folks, any comments?
I have updated the patch to remove the SKIP_GENERATED changes:
http://cr.openjdk.java.net/~iklam/8023406/windows_build_vm_def_slow_002/
make/windows/build_vm_def.sh
Seems as if line 86:
86 "$CAT" vm1.def vm2.d
On 8/21/13 11:22 AM, Ioi Lam wrote:
build-dev folks, any comments?
I have updated the patch to remove the SKIP_GENERATED changes:
http://cr.openjdk.java.net/~iklam/8023406/windows_build_vm_def_slow_002/
Thumbs up.
make/windows/build_vm_def.sh
No comments.
make/windows/makefiles/debug.ma
Hi Ioi,
I've tried your patch on vs2010 and it seems working fine.
I was able to generate a project file and used vs2010 to open the
project file.
So I think your fix is good. (I'm not a Reviewer)
Calvin
On 8/9/2013 5:39 PM, Ioi Lam wrote:
|Please review a very small fix:||
||
||http://cr.op
Thanks Dan!
Harold
On 8/21/2013 6:27 PM, Daniel D. Daugherty wrote:
On 8/21/13 3:19 PM, harold seigel wrote:
Hi,
Please review this small fix for bug 8022183. This fix is needed in
order to build hotspot on 32-bit Linux with newer versions of gcc.
The fix explicitly specifies "-fno-omit-fra
16 matches
Mail list logo
