Hello David,
I like that you incorporate the existing sysroot settings for this. I
wonder though, what is the difference between --with-macosx-sdk-path and
--with-sysroot? Do we really need two parameters for this? If it's
actually a sysroot, couldn't we replace all uses of this variable with
Hello,
This patch attempts to fix a build problem in accessbridge. Two compile
jobs are both trying to create the same header file. The fix is to
separate the output directories of these jobs so that they do not
interfere with each other.
Bug: https://bugs.openjdk.java.net/browse/JDK-8043160
* Andrew Hughes [2014-05-22 16:10]:
> - Original Message -
> > On 2014-05-22 02:49, Omair Majid wrote:
> > > Would you mind if I did this as a separate patch? I will need to fix
> > > other libraries too (libzip, and libgif).
> > >
>
> Ok, I thought the other ones were already in this for
Now that my mind is fresher and I've had my coffee... (and someones poked me in
the ribs ;)
MACOSX_SDK_PATH should be SDKROOT, which is what Apple uses when building via
Xcode or xcodebuild, which would also promote that setting to the few remaining
Xcode projects we have hanging around. We ca
Kumar, David - thanks for the reviews!
Cheers,
Mikael
On 2014-05-22 19:37, David Holmes wrote:
Looks good.
David
On 23/05/2014 6:13 AM, Mikael Vidstedt wrote:
Please review the following change, destined for jdk7u-dev. The zip
implementation in unpack200 depends on _BIG_ENDIAN being define
Nobody should be using this any more, can I nuke it?
BASIC_DEPRECATED_ARG_ENABLE(macosx-runtime-support, macosx_runtime_support)
That hasn't done anything since JDK7, it was deprecated in 8 and shouldn't even
be used in 8.
-DrD-
>
> Now that my mind is fresher and I've had my coffee... (and
I'm combining this fix with another as it was starting to make my head split
trying to keep the two separate, they're just too closely related. I'll start
another review thread for the combined patches.
-DrD-
>
> Nobody should be using this any more, can I nuke it?
>
> BASIC_DEPRECATED_ARG_E
