Re: RFR: JDK-8087193: Support building with devkits on Macosx

2015-06-12 Thread Erik Joelsson
On the machine I'm trying this on, without any C compiler on the path, this is what I get with the patch. Note that "uname -p" is what autoconf-config.guess is using. > uname -m x86_64 > uname -p i386 > bash common/autoconf/build-aux/autoconf-config.guess i386-apple-darwin13.4.0 > bash common

Re: RFR: JDK-8087195: Support building hotspot with devkits on Macosx

2015-06-12 Thread David Holmes
On 12/06/2015 4:35 PM, Erik Joelsson wrote: Hello David, On 2015-06-12 04:20, David Holmes wrote: Hi Erik, On 11/06/2015 11:11 PM, Erik Joelsson wrote: Hello again, I missed cleaning the path correctly when testing this so missed another needed change. When calling "lipo", the hotspot makefi

Re: RfR JDK-8055160

2015-06-12 Thread Magnus Ihse Bursie
On 2015-06-11 00:33, Pete Brunet wrote: Due to some other priorities it's been over 2 months since the last webrev. An update is here: http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.03 Build changes look good. /Magnus The changes from webrev.02 are: 1) The test was changed to not

Re: RFR: 8087156: SetupNativeCompilation ignores CFLAGS_release for cpp files

2015-06-12 Thread Magnus Ihse Bursie
On 2015-06-11 08:51, Erik Joelsson wrote: Hello Omair, This looks good to me, thanks for catching it! Looks good to me too. However, this is not the first time we've encountered a problem like this. I ran into a similar problem some time ago. It's a very brittle system we have. I believe we

Re: RFR: JDK-8087208: Add devkit creation script for windows

2015-06-12 Thread Magnus Ihse Bursie
On 2015-06-11 15:23, Erik Joelsson wrote: For reference, I would like to add the script used to create the devkit on Windows to the source tree. Bug: https://bugs.openjdk.java.net/browse/JDK-8087208 Webrev: http://cr.openjdk.java.net/~erikj/8087208/webrev.01/ /Erik Looks good to me. /Magnus

Re: RFR: JDK-8087193: Support building with devkits on Macosx

2015-06-12 Thread Magnus Ihse Bursie
On 2015-06-12 09:05, Erik Joelsson wrote: On the machine I'm trying this on, without any C compiler on the path, this is what I get with the patch. Note that "uname -p" is what autoconf-config.guess is using. > uname -m x86_64 > uname -p i386 > bash common/autoconf/build-aux/autoconf-config.g

Re: question on checking dependencies across modules

2015-06-12 Thread Magnus Ihse Bursie
On 2015-06-11 01:38, Maurizio Cimadamore wrote: On 10/06/15 17:27, Mandy Chung wrote: On Jun 10, 2015, at 6:25 AM, Maurizio Cimadamore wrote: Hi, In the context of the IntelliJ project support for JDK, I have a question on the very last step of 'make images' : ## Starting verify-modules

Re: RFR: JDK-8087195: Support building hotspot with devkits on Macosx

2015-06-12 Thread Magnus Ihse Bursie
On 2015-06-12 08:35, Erik Joelsson wrote: Hello David, On 2015-06-12 04:20, David Holmes wrote: Hi Erik, On 11/06/2015 11:11 PM, Erik Joelsson wrote: Hello again, I missed cleaning the path correctly when testing this so missed another needed change. When calling "lipo", the hotspot makefil

Re: RfR JDK-8055160

2015-06-12 Thread Pete Brunet
Thanks Mandy. I need one more review from the awt-dev team. Pete On 6/10/15 6:29 PM, Mandy Chung wrote: >> On Jun 10, 2015, at 3:33 PM, Pete Brunet wrote: >> >> Due to some other priorities it's been over 2 months since the last webrev. >> An update is here: >> http://cr.openjdk.java.net/~ptb

Re: RfR JDK-8055160

2015-06-12 Thread Sergey Bylokhov
Looks fine. On 12.06.2015 17:36, Pete Brunet wrote: Thanks Mandy. I need one more review from the awt-dev team. Pete On 6/10/15 6:29 PM, Mandy Chung wrote: On Jun 10, 2015, at 3:33 PM, Pete Brunet wrote: Due to some other priorities it's been over 2 months since the last webrev. An updat

Re: RFR: 8087156: SetupNativeCompilation ignores CFLAGS_release for cpp files

2015-06-12 Thread Omair Majid
* Magnus Ihse Bursie [2015-06-12 09:02]: > Looks good to me too. Thanks for the review! Sorry I was unable to credit you since I already pushed the patch. > However, this is not the first time we've encountered a problem like this. I > ran into a similar problem some time ago. It's a very brittl

Re: RfR JDK-8055160

2015-06-12 Thread Pete Brunet
Thanks Mandy, The new patch is at http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.04 On 6/10/15 6:29 PM, Mandy Chung wrote: >> On Jun 10, 2015, at 3:33 PM, Pete Brunet wrote: >> >> Due to some other priorities it's been over 2 months since the last webrev. >> An update is here: >> http:

Re: RfR JDK-8055160

2015-06-12 Thread Mandy Chung
> On Jun 12, 2015, at 1:07 PM, Pete Brunet wrote: > > Thanks Mandy, The new patch is at > http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.04 > Looks good. Thanks. > On 6/10/15 6:29 PM, Mandy Chung wrote: >>> On Jun 10, 2015, at 3:33 PM, Pete Brunet wrote: >>> >>> Due to some other