Hello,
The variable ARCH_DATA_MODEL is not initialized anywhere. I know JPRT
sets it, but I don't think we should rely on that.
/Erik
On 2016-10-08 03:34, Tim Bell wrote:
Hi Jon
On 10/07/16 15:48, Jonathan Gibbons wrote:
Tim,
The problem only appears on 32-bit Windows, but the fix appear
This is a collection of various trivial fixes on stuff I noticed when
reviewing the accumulated changes in the build system the last months.
The majority of the fixes is updating the copyright year for modified
files. On top of this, there's also a few other fixes:
* Fix spaces and indentatio
Looks good.
/Erik
On 2016-10-10 11:22, Magnus Ihse Bursie wrote:
This is a collection of various trivial fixes on stuff I noticed when
reviewing the accumulated changes in the build system the last months.
The majority of the fixes is updating the copyright year for modified
files. On top o
Hi,
Please review the following small patch to make the output from jtreg
for langtools testing through make to be saved in output.txt, just like
in other repos.
Webrev:
http://cr.openjdk.java.net/~mlarsson/8167354/webrev.00
Issue:
https://bugs.openjdk.java.net/browse/JDK-8167354
Thanks,
Ma
Looks ok to me.
/Erik
On 2016-10-10 12:46, Marcus Larsson wrote:
Hi,
Please review the following small patch to make the output from jtreg
for langtools testing through make to be saved in output.txt, just
like in other repos.
Webrev:
http://cr.openjdk.java.net/~mlarsson/8167354/webrev.00
Thanks Erik!
On 10/10/2016 01:00 PM, Erik Joelsson wrote:
Looks ok to me.
/Erik
On 2016-10-10 12:46, Marcus Larsson wrote:
Hi,
Please review the following small patch to make the output from jtreg
for langtools testing through make to be saved in output.txt, just
like in other repos.
W
Looks good!
Thanks,
/Staffan
> On 10 Oct 2016, at 12:46, Marcus Larsson wrote:
>
> Hi,
>
> Please review the following small patch to make the output from jtreg for
> langtools testing through make to be saved in output.txt, just like in other
> repos.
>
> Webrev:
> http://cr.openjdk.java.n
Thanks Staffan!
On 10/10/2016 01:30 PM, Staffan Larsen wrote:
Looks good!
Thanks,
/Staffan
On 10 Oct 2016, at 12:46, Marcus Larsson wrote:
Hi,
Please review the following small patch to make the output from jtreg for
langtools testing through make to be saved in output.txt, just like in
On 10/10/2016 6:53 PM, Erik Joelsson wrote:
Hello,
The variable ARCH_DATA_MODEL is not initialized anywhere. I know JPRT
sets it, but I don't think we should rely on that.
./autoconf/buildjdk-spec.gmk.in:ARCH_DATA_MODEL := $(OPENJDK_BUILD_CPU_BITS)
David
/Erik
On 2016-10-08 03:34, Tim Bel
On 2016-10-10 14:56, David Holmes wrote:
On 10/10/2016 6:53 PM, Erik Joelsson wrote:
Hello,
The variable ARCH_DATA_MODEL is not initialized anywhere. I know JPRT
sets it, but I don't think we should rely on that.
./autoconf/buildjdk-spec.gmk.in:ARCH_DATA_MODEL :=
$(OPENJDK_BUILD_CPU_BITS)
Hello,
Please review this change, which reorganizes src.zip into modules
directories. It also includes the source of any imported modules into
src.zip.
If an imported modules contains both sources and classes, the java
sources are not recompiled, except for module-info.java. This mimics the
Magnus
Looks good to me as well.
/Tim
On 10/10/16 02:31, Erik Joelsson wrote:
Looks good.
/Erik
On 2016-10-10 11:22, Magnus Ihse Bursie wrote:
This is a collection of various trivial fixes on stuff I noticed when
reviewing the accumulated changes in the build system the last months.
The m
Erik:
On 2016-10-10 14:56, David Holmes wrote:
On 10/10/2016 6:53 PM, Erik Joelsson wrote:
Hello,
The variable ARCH_DATA_MODEL is not initialized anywhere. I know JPRT
sets it, but I don't think we should rely on that.
./autoconf/buildjdk-spec.gmk.in:ARCH_DATA_MODEL :=
$(OPENJDK_BUILD_CPU_B
On Solaris libjimage.so has a weird extra runpath set, pointing into the
install directory of Solaris Studio.
JDK-8160630 changed libjimage to be compiled as C++ library as it should
be. I forgot to add the linker flags LDFLAGS_CXX_JDK to the LDFLAGS of
that library. All other C++ libraries in
Erik:
On Solaris libjimage.so has a weird extra runpath set, pointing into the
install directory of Solaris Studio.
JDK-8160630 changed libjimage to be compiled as C++ library as it should
be. I forgot to add the linker flags LDFLAGS_CXX_JDK to the LDFLAGS of
that library. All other C++ librari
Is there a compelling reason to use .txt as the extension, instead of
something more conventional, like .log?
-- Jon
On 10/10/2016 04:35 AM, Marcus Larsson wrote:
Thanks Staffan!
On 10/10/2016 01:30 PM, Staffan Larsen wrote:
Looks good!
Thanks,
/Staffan
On 10 Oct 2016, at 12:46, Marcus La
On 10/10/2016 11:12 PM, Erik Joelsson wrote:
On 2016-10-10 14:56, David Holmes wrote:
On 10/10/2016 6:53 PM, Erik Joelsson wrote:
Hello,
The variable ARCH_DATA_MODEL is not initialized anywhere. I know JPRT
sets it, but I don't think we should rely on that.
./autoconf/buildjdk-spec.gmk.in:A
The reason is to use the same name as is currently used in the jdk, hotspot,
nashorn and jaxp makefiles. Having a common name makes it much easier for
outside tools to find the file.
> On 10 Oct 2016, at 19:31, Jonathan Gibbons
> wrote:
>
> Is there a compelling reason to use .txt as the exte
18 matches
Mail list logo
