RE: Building OpenJDK9 on MSYS2

2017-10-15 Thread Peter Budai
A quick status update: * Hotspot successfully compiled without warnings * I’d like to run the unit tests, but as I see ‘make check’ does not work, and gtestlauncher expects a command line parameter jdk. Tried to look up some documentation on this, but have not found. So the question is:

Re: Building OpenJDK9 on MSYS2

2017-10-15 Thread David Holmes
On 16/10/2017 12:41 AM, Peter Budai wrote: A quick status update: * Hotspot successfully compiled without warnings * I’d like to run the unit tests, but as I see ‘make check’ does not work, and gtestlauncher expects a command line parameter jdk. Tried to look up some documentation on

Re: RFR: 8171853: Remove Shark compiler

2017-10-15 Thread David Holmes
Hi Roman, The build changes must be reviewed on build-dev - now cc'd. Thanks, David On 15/10/2017 8:41 AM, Roman Kennke wrote: The JEP to remove the Shark compiler has received exclusively positive feedback (JDK-8189173) on zero-dev. So here comes the big patch to remove it. What I have don

Re: RFR: 8171853: Remove Shark compiler

2017-10-15 Thread Roman Kennke
Hi David, thanks! I'm uploading a 2nd revision of the patch that excludes the generated-configure.sh part, and adds a smallish Zero-related fix. http://cr.openjdk.java.net/~rkennke/8171853/webrev.01/ Thanks, Roman Hi Roman, The

Re: RFR: 8171853: Remove Shark compiler

2017-10-15 Thread David Holmes
Hi Roman, I've looked at all the changes for the build and hotspot and everything appears okay to me. Still need someone from compiler team and build team to sign off on this though. One observation in src/hotspot/cpu/zero/sharedRuntime_zero.cpp, these includes would seem to be impossible:

Re: RFR: 8171853: Remove Shark compiler

2017-10-15 Thread David Holmes
On 16/10/2017 7:01 AM, Roman Kennke wrote: Hi David, thanks! I'm uploading a 2nd revision of the patch that excludes the generated-configure.sh part, and adds a smallish Zero-related fix. http://cr.openjdk.java.net/~rkennke/8171853/webrev.01/

Re: RFR: 8171853: Remove Shark compiler

2017-10-15 Thread David Holmes
Just spotted this: ./hotspot/jtreg/compiler/whitebox/CompilerWhiteBoxTest.java:/** {@code CompLevel::CompLevel_full_optimization} -- C2 or Shark */ David On 16/10/2017 7:25 AM, David Holmes wrote: On 16/10/2017 7:01 AM, Roman Kennke wrote: Hi David, thanks! I'm uploading a 2nd revisio

Re: RFR: 8171853: Remove Shark compiler

2017-10-15 Thread Roman Kennke
Hi David, thanks for reviewing! One observation in src/hotspot/cpu/zero/sharedRuntime_zero.cpp, these includes would seem to be impossible:   38 #ifdef COMPILER1   39 #include "c1/c1_Runtime1.hpp"   40 #endif   41 #ifdef COMPILER2   42 #include "opto/runtime.hpp"   43 #endif no? I have n

Re: RFR: 8171853: Remove Shark compiler

2017-10-15 Thread David Holmes
On 16/10/2017 7:31 AM, Roman Kennke wrote: Hi David, thanks for reviewing! One observation in src/hotspot/cpu/zero/sharedRuntime_zero.cpp, these includes would seem to be impossible:   38 #ifdef COMPILER1   39 #include "c1/c1_Runtime1.hpp"   40 #endif   41 #ifdef COMPILER2   42 #include "o

Re: RFR: 8171853: Remove Shark compiler

2017-10-15 Thread Roman Kennke
Am 15.10.2017 um 23:25 schrieb David Holmes: On 16/10/2017 7:01 AM, Roman Kennke wrote: Hi David, thanks! I'm uploading a 2nd revision of the patch that excludes the generated-configure.sh part, and adds a smallish Zero-related fix. http://cr.openjdk.java.net/~rkennke/8171853/webrev.01/

Re: RFR: 8171853: Remove Shark compiler

2017-10-15 Thread David Holmes
On 16/10/2017 7:39 AM, Roman Kennke wrote: Am 15.10.2017 um 23:25 schrieb David Holmes: On 16/10/2017 7:01 AM, Roman Kennke wrote: Hi David, thanks! I'm uploading a 2nd revision of the patch that excludes the generated-configure.sh part, and adds a smallish Zero-related fix. http://cr.open

Re: RFR: 8171853: Remove Shark compiler

2017-10-15 Thread Roman Kennke
Ok, I fixed all the comments you mentioned. Differential (against webrev.01): http://cr.openjdk.java.net/~rkennke/8171853/webrev.03.diff/ Full webrev: http://cr.openjdk.java.net/~rkennke/8171853/webrev.03/

Re: RFR: 8171853: Remove Shark compiler

2017-10-15 Thread David Holmes
Looks good. Thanks, David On 16/10/2017 8:00 AM, Roman Kennke wrote: Ok, I fixed all the comments you mentioned. Differential (against webrev.01): http://cr.openjdk.java.net/~rkennke/8171853/webrev.03.diff/ Full webrev: http://

Re: RFR: 8171853: Remove Shark compiler

2017-10-15 Thread Vladimir Kozlov
+1 Thanks, Vladimir On 10/15/17 3:08 PM, David Holmes wrote: Looks good. Thanks, David On 16/10/2017 8:00 AM, Roman Kennke wrote: Ok, I fixed all the comments you mentioned. Differential (against webrev.01): http://cr.openjdk.java.net/~rkennke/8171853/webrev.03.diff/

Re: RFR: 8171853: Remove Shark compiler

2017-10-15 Thread David Holmes
My internal JPRT run went fine. So this just needs a build team signoff from the perspective of the patch. However, as this has had a JEP submitted for it, the code changes can not be pushed until the JEP has been targeted. Thanks, David On 16/10/2017 8:08 AM, David Holmes wrote: Looks good

Re: RFR: 8171853: Remove Shark compiler

2017-10-15 Thread Roman Kennke
Hi David, thanks for reviewing and testing! The interaction between JEPs and patches going in is not really clear to me, nor is it well documented. For example, we're already pushing patches for JEP 304: Garbage Collection Interface, even though it's only in 'candidate' state... In any cas

Re: RFR: 8171853: Remove Shark compiler

2017-10-15 Thread David Holmes
On 16/10/2017 3:49 PM, Roman Kennke wrote: Hi David, thanks for reviewing and testing! The interaction between JEPs and patches going in is not really clear to me, nor is it well documented. For example, we're already pushing patches for JEP 304: Garbage Collection Interface, even though it'