On 2017-12-01 18:16, Volker Simonis wrote:
Hi Rajan,
great to see this finally happen!
I have just a quick question related to the tests. As far as I can
see, the tests will only succeed if the OpenJDK will be build with the
new open sourced, Oracle root certificates. But what if somebody is
bu
On Tue, Dec 5, 2017 at 9:19 AM, Magnus Ihse Bursie
wrote:
> On 2017-12-01 18:16, Volker Simonis wrote:
>>
>> Hi Rajan,
>>
>> great to see this finally happen!
>>
>> I have just a quick question related to the tests. As far as I can
>> see, the tests will only succeed if the OpenJDK will be build w
On 2017-12-05 09:44, Volker Simonis wrote:
On Tue, Dec 5, 2017 at 9:19 AM, Magnus Ihse Bursie
wrote:
On 2017-12-01 18:16, Volker Simonis wrote:
Hi Rajan,
great to see this finally happen!
I have just a quick question related to the tests. As far as I can
see, the tests will only succeed if t
JDK-8190484 modifies how the copy step of the build process works.
Unfortunately, this broke building on Windows in jdk.accessibility.
Since JDK-8190484 was pushed to jdk/hs, I intend to push this to jdk/hs
as well.
Bug: https://bugs.openjdk.java.net/browse/JDK-8193045
WebRev:
http://cr.open
Hi Magnus,
On 5/12/2017 7:12 PM, Magnus Ihse Bursie wrote:
JDK-8190484 modifies how the copy step of the build process works.
Unfortunately, this broke building on Windows in jdk.accessibility.
Since JDK-8190484 was pushed to jdk/hs, I intend to push this to jdk/hs
as well.
Bug: https://bug
On Tue, Dec 5, 2017 at 10:08 AM, Magnus Ihse Bursie
wrote:
> On 2017-12-05 09:44, Volker Simonis wrote:
>>
>> On Tue, Dec 5, 2017 at 9:19 AM, Magnus Ihse Bursie
>> wrote:
>>>
>>> On 2017-12-01 18:16, Volker Simonis wrote:
Hi Rajan,
great to see this finally happen!
I
On 2017-12-05 10:21, David Holmes wrote:
Hi Magnus,
On 5/12/2017 7:12 PM, Magnus Ihse Bursie wrote:
JDK-8190484 modifies how the copy step of the build process works.
Unfortunately, this broke building on Windows in jdk.accessibility.
Since JDK-8190484 was pushed to jdk/hs, I intend to push t
On 2017-12-05 10:25, Volker Simonis wrote:
On Tue, Dec 5, 2017 at 10:08 AM, Magnus Ihse Bursie
wrote:
On 2017-12-05 09:44, Volker Simonis wrote:
On Tue, Dec 5, 2017 at 9:19 AM, Magnus Ihse Bursie
wrote:
On 2017-12-01 18:16, Volker Simonis wrote:
Hi Rajan,
great to see this finally happen!
On 05.12.2017 10:08, Magnus Ihse Bursie wrote:
I think the folks from the AdoptOpenJDK project are using this option
(CC-ed adoption-discuss). I'm not sure if they want to drop their root
certificates in favor of the new ones.
Maybe they can upstream their root certs as well, if it seems prude
On 5/12/2017 7:30 PM, Magnus Ihse Bursie wrote:
On 2017-12-05 10:21, David Holmes wrote:
Hi Magnus,
On 5/12/2017 7:12 PM, Magnus Ihse Bursie wrote:
JDK-8190484 modifies how the copy step of the build process works.
Unfortunately, this broke building on Windows in jdk.accessibility.
Since JDK
We mistakenly use -XX:-UnlockDiagnosticVMOptions instead of
-XX:+UnlockDiagnosticVMOptions in a ADD_JVM_ARG_IF_OK call. This means
that the test will always fail and the arguments will never be added to
the command line.
Since this has been the case all time along, it's probably not that
impo
Hi Magnus,
On 5/12/2017 8:49 PM, Magnus Ihse Bursie wrote:
We mistakenly use -XX:-UnlockDiagnosticVMOptions instead of
-XX:+UnlockDiagnosticVMOptions in a ADD_JVM_ARG_IF_OK call. This means
that the test will always fail and the arguments will never be added to
the command line.
Since this h
On 2017-12-05 13:03, David Holmes wrote:
Hi Magnus,
On 5/12/2017 8:49 PM, Magnus Ihse Bursie wrote:
We mistakenly use -XX:-UnlockDiagnosticVMOptions instead of
-XX:+UnlockDiagnosticVMOptions in a ADD_JVM_ARG_IF_OK call. This
means that the test will always fail and the arguments will never be
On 5/12/2017 10:27 PM, Magnus Ihse Bursie wrote:
On 2017-12-05 13:03, David Holmes wrote:
Hi Magnus,
On 5/12/2017 8:49 PM, Magnus Ihse Bursie wrote:
We mistakenly use -XX:-UnlockDiagnosticVMOptions instead of
-XX:+UnlockDiagnosticVMOptions in a ADD_JVM_ARG_IF_OK call. This
means that the test
A small addition to jib-profiles.js to set the MAKE environment variable
for gnumake. (Used when running tests without configure)
Bug: https://bugs.openjdk.java.net/browse/JDK-8193060
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8193060-set-MAKE-env-in-jib-profile/webrev.01
/Magnus
This addition makes it possible to run tests using the normal
RunTests.gmk framework, even if configure has not been run. The typical
use case is for automated testing, where a test machine can download a
prebuilt JDK image and test image, and the source tree, and then start
executing tests as
Magnus:
A small addition to jib-profiles.js to set the MAKE environment variable
for gnumake. (Used when running tests without configure)
Bug: https://bugs.openjdk.java.net/browse/JDK-8193060
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8193060-set-MAKE-env-in-jib-profile/webrev.01
Looks good
Hi Rajan,
'cacerts' is a binary file and I thought we have at least the
convention in the OpenJDK project that we don't want to check in
binary artefact's if possible.
One problem with 'cacerts' being a binary file is that we can not add
a license and copyright to it. Another one is that it is ha
Looks good.
/Erik
On 2017-12-05 04:27, Magnus Ihse Bursie wrote:
On 2017-12-05 13:03, David Holmes wrote:
Hi Magnus,
On 5/12/2017 8:49 PM, Magnus Ihse Bursie wrote:
We mistakenly use -XX:-UnlockDiagnosticVMOptions instead of
-XX:+UnlockDiagnosticVMOptions in a ADD_JVM_ARG_IF_OK call. This
On 12/5/17 12:01 PM, Volker Simonis wrote:
Hi Rajan,
'cacerts' is a binary file and I thought we have at least the
convention in the OpenJDK project that we don't want to check in
binary artefact's if possible.
One problem with 'cacerts' being a binary file is that we can not add
a license and
On 2017-12-05 18:33, Sean Mullan wrote:
On 12/5/17 12:01 PM, Volker Simonis wrote:
Hi Rajan,
'cacerts' is a binary file and I thought we have at least the
convention in the OpenJDK project that we don't want to check in
binary artefact's if possible.
One problem with 'cacerts' being a binary
Looks good.
/Erik
On 2017-12-05 04:47, Magnus Ihse Bursie wrote:
A small addition to jib-profiles.js to set the MAKE environment
variable for gnumake. (Used when running tests without configure)
Bug: https://bugs.openjdk.java.net/browse/JDK-8193060
WebRev:
http://cr.openjdk.java.net/~ihse/J
Looks pretty good, only some minor notes:
* RunTestsPrebuilt.gmk:72: indentation
* 95: You could use the sequence macro to generate a large set of
increasing numbers here.
* 182: "... all others use uname -m"
/Erik
On 2017-12-05 05:02, Magnus Ihse Bursie wrote:
This addition makes it possi
On 2017-12-05 21:05, Erik Joelsson wrote:
Looks pretty good, only some minor notes:
* RunTestsPrebuilt.gmk:72: indentation
Fixed.
* 95: You could use the sequence macro to generate a large set of
increasing numbers here.
Unfortunately, it's not available since I can't read MakeBase.gmk yet
Looks good.
On 2017-12-05 12:14, Magnus Ihse Bursie wrote:
On 2017-12-05 21:05, Erik Joelsson wrote:
Looks pretty good, only some minor notes:
* RunTestsPrebuilt.gmk:72: indentation
Fixed.
* 95: You could use the sequence macro to generate a large set of
increasing numbers here.
Unfortun
25 matches
Mail list logo
