Re: Choosing which Visual Studio installation to use

2018-02-14 Thread John Paul Adrian Glaubitz
On 02/14/2018 02:07 PM, Thomas Stüfe wrote: Does it have to be Cygwin though? Yes. I love cygwin. You can put it into fullscreen and pretend you have a very slow Linux machine :) But seriously, it is very stable and mature, would not like at all to change my environment. Yes, but, if I

Re: Choosing which Visual Studio installation to use

2018-02-14 Thread Thomas Stüfe
Hi Adrian, On Wed, Feb 14, 2018 at 12:29 PM, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > Hi Thomas! > > On 02/14/2018 12:24 PM, Thomas Stüfe wrote: > >> On Windows, if one has multiple VS installations side by side, is it >> possible to choose which Visual Studio

Choosing which Visual Studio installation to use

2018-02-14 Thread Thomas Stüfe
Hi all, On Windows, if one has multiple VS installations side by side, is it possible to choose which Visual Studio installation to use? Note that I start the configure script from within the cygwin shell. Thanks, Thomas

Re: Choosing which Visual Studio installation to use

2018-02-14 Thread Thomas Stüfe
On Wed, Feb 14, 2018 at 12:45 PM, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > On 02/14/2018 12:42 PM, Thomas Stüfe wrote: > >> Yes, that is normally the way - that or just starting the corresponding >> "visual studio command prompt" shell. That is why I was specifying that

Re: Choosing which Visual Studio installation to use

2018-02-14 Thread John Paul Adrian Glaubitz
Hi Thomas! On 02/14/2018 12:24 PM, Thomas Stüfe wrote: On Windows, if one has multiple VS installations side by side, is it possible to choose which Visual Studio installation to use? From my slightly rusted memory regarding Visual Studio, isn't the regular way to choose a certain VS

Re: Choosing which Visual Studio installation to use

2018-02-14 Thread John Paul Adrian Glaubitz
On 02/14/2018 12:42 PM, Thomas Stüfe wrote: Yes, that is normally the way - that or just starting the corresponding "visual studio command prompt" shell. That is why I was specifying that I am running from cygwin shell - the openjdk build somehow chooses that batch script for you, and it would

Re: RFR(S): 8197906: Enable CDS mode execution of jtreg tests via make

2018-02-14 Thread Mikhailo Seledtsov
Hi Igor, Thank you for review. This is what I see from the test execution logs on Windows: // At archive creation time: > -XX:SharedArchiveFile=T:/testoutput/jtreg/cds_archive.jsa -Xshare:dump // At archive use time: >-vmoption:-XX:+UnlockDiagnosticVMOptions

Proposal: make/Main.gmk Add extra extension/override points to the make file

2018-02-14 Thread Steve Groeger
Hi Erik, Sorry these updates have take a while to make but here is there latest diff for my proposed changes to make/Main.gmk to allow extension/override points in that make file to enable someone to provide an alternate JVM. Please could you take another look at these and let me know if they

Re: Choosing which Visual Studio installation to use

2018-02-14 Thread Michal Vala
Hi, On 02/14/2018 12:24 PM, Thomas Stüfe wrote: Hi all, On Windows, if one has multiple VS installations side by side, is it possible to choose which Visual Studio installation to use? Note that I start the configure script from within the cygwin shell. OpenJDK configure is reading VS

Re: Choosing which Visual Studio installation to use

2018-02-14 Thread Thomas Stüfe
On Wed, Feb 14, 2018 at 2:16 PM, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > On 02/14/2018 02:07 PM, Thomas Stüfe wrote: > >> Does it have to be Cygwin though? >> >> >> Yes. I love cygwin. You can put it into fullscreen and pretend you have a >> very slow Linux machine

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-14 Thread jesper . wilhelmsson
Looks good! /Jesper > On 14 Feb 2018, at 22:45, sangheon.kim wrote: > > Hi all, > > Could I have some reviews for CMM removal? > This is closed CR but some public codes also need small modifications. This > CR is for removing stuff related to an Oracle JDK

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-14 Thread sangheon.kim
Hi David and Jesper, Thank you for the review. Sangheon On 02/14/2018 02:53 PM, jesper.wilhelms...@oracle.com wrote: Looks good! /Jesper On 14 Feb 2018, at 22:45, sangheon.kim wrote: Hi all, Could I have some reviews for CMM removal? This is closed CR but some

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-14 Thread mandy chung
+1 Mandy On 2/14/18 1:45 PM, sangheon.kim wrote: Hi all, Could I have some reviews for CMM removal? This is closed CR but some public codes also need small modifications. This CR is for removing stuff related to an Oracle JDK module/package. Changes are just removing CMM from lists or in a

Re: RFR(S): 8197906: Enable CDS mode execution of jtreg tests via make

2018-02-14 Thread Igor Ignatyev
[1] and [2] are equivalent for cygwin, but it doesn't mean they are equivalent JVM. I recall there were some problems when cygwin paths passed to JVM. so to be on the safe side, I'd use mixed or windows path to the archive in JVM flags. Thanks, -- Igor > On Feb 14, 2018, at 7:26 AM, Mikhailo

Re: RFR: JDK-8153294: Solaris devkit uses linker from system instead of in devkit

2018-02-14 Thread Magnus Ihse Bursie
On 2018-02-14 01:50, Erik Joelsson wrote: The current devkit I created for Solaris has a flaw in that CC will still call the system linker instead of the one in the devkit. I have finally figured out a solution for this, while working on the next devkit with upgraded compiler versions, but

Re: RFR(S): 8197906: Enable CDS mode execution of jtreg tests via make

2018-02-14 Thread Magnus Ihse Bursie
On 2018-02-14 16:26, Mikhailo Seledtsov wrote: Hi Igor,   Thank you for review. This is what I see from the test execution logs on Windows: // At archive creation time:  > -XX:SharedArchiveFile=T:/testoutput/jtreg/cds_archive.jsa -Xshare:dump // At archive use time:  >   

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-14 Thread David Holmes
That all seems trivially fine. Thanks, David On 15/02/2018 7:45 AM, sangheon.kim wrote: Hi all, Could I have some reviews for CMM removal? This is closed CR but some public codes also need small modifications. This CR is for removing stuff related to an Oracle JDK module/package. Changes are

RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-14 Thread sangheon.kim
Hi all, Could I have some reviews for CMM removal? This is closed CR but some public codes also need small modifications. This CR is for removing stuff related to an Oracle JDK module/package. Changes are just removing CMM from lists or in a test to skip the testing logic. CR:

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-14 Thread sangheon.kim
Hi Mandy, Thank you for the review! Sangheon On 02/14/2018 03:45 PM, mandy chung wrote: +1 Mandy On 2/14/18 1:45 PM, sangheon.kim wrote: Hi all, Could I have some reviews for CMM removal? This is closed CR but some public codes also need small modifications. This CR is for removing

Re: macOS High Sierra, version 10.13.2 configure: error: Couldnotfind freetype! You might be able to fix this by running 'brewinstallfreetype'

2018-02-14 Thread mbl
Thank you to let me know, You are right, i see my Xcode 4 is , so what can I do if I still want to build openjdk on my macos? I really don not want to downgrade my Mac OS. > On 14 Feb 2018, at 00:55, Erik Joelsson wrote: > > Hello, > > My guess would be that Xcode 4

JDK10 build problem: "--module-path"?

2018-02-14 Thread Ted Neward
I’m getting a weird error in my OpenJDK 10 (tip) build, where after pulling source and configure, I get a build error about the Java compiler being executed with “--module-path” as a parameter, which obviously isn’t a legitimate javac flag. Is this just me? Is anybody else able to repro

Re: JDK10 build problem: "--module-path"?

2018-02-14 Thread Ted Neward
Really?!? I thought the javac -help only listed -modulepath. Not to disbelieve you *grin*, but are you sure? The reason I ask is (barring some really bizarre misconfiguration) I should be using the OpenJDK9 as the boot JDK for this, and I'm getting the error. Ted Neward Author, Speaker, Mentor

Re: JDK10 build problem: "--module-path"?

2018-02-14 Thread Jonathan Gibbons
On 2/14/18 4:38 PM, Ted Neward wrote: I’m getting a weird error in my OpenJDK 10 (tip) build, where after pulling source and configure, I get a build error about the Java compiler being executed with “--module-path” as a parameter, which obviously isn’t a legitimate javac flag. I can't

Re: Choosing which Visual Studio installation to use

2018-02-14 Thread Thomas Stüfe
Hi Michael, On Wed, Feb 14, 2018 at 4:20 PM, Michal Vala wrote: > Hi, > > On 02/14/2018 12:24 PM, Thomas Stüfe wrote: > >> Hi all, >> >> On Windows, if one has multiple VS installations side by side, is it >> possible to choose which Visual Studio installation to use? >> >>

Re: JDK10 build problem: "--module-path"?

2018-02-14 Thread David Holmes
On 15/02/2018 10:38 AM, Ted Neward wrote: I’m getting a weird error in my OpenJDK 10 (tip) build, where after pulling source and configure, I get a build error about the Java compiler being executed with “--module-path” as a parameter, which obviously isn’t a legitimate javac flag. Is this