RFR: JDK-8199052 Configure broken on aarch64
Thanks for the quick fix Magnus! * Derek White
Re: RFR: JDK-8199125: --disable-warnings-as-errors does not work for native jtreg test code
On 2018-03-06 17:06, Erik Joelsson wrote: In TestFilesCompilation.gmk we still add $(CFLAGS_WARNINGS_ARE_ERRORS) explicitly to CFLAGS. This is both redundant and wrong since we are now handling these flags automatically in the macro SetupNativeCompilation. The consequence is that --disable-warnings-as-errors won't work for jtreg tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8196458 Webrev: http://cr.openjdk.java.net/~erikj/8199125/webrev.01/ Looks good to me. /Magnus /Erik
Re: RFR: JDK-8199103 Can't use COMPARE_BUILD with PATCH from custom root
On 2018-03-06 15:59, Erik Joelsson wrote: Looks good. When looking at this patch, I realized that topdir has a different meaning depending on if you are in the HAS_SPEC conditional or not. In the first section, topdir is always the open root dir, but in the else section it is set to CUSTOM_ROOT if available. This is rather confusing. Could we unify the value of this variable? I don't think we can unify them, since topdir in the first section is really TOPDIR (i.e. never the custom root), but found out differently than normal. (It is possible that it could be renamed TOPDIR, but I wanted to make it clear that it is not the "normal" value of TOPDIR). The second section has the meaning "TOPDIR or CUSTOM_ROOT", and is used only for COMPARE_BUILD. Do you have any suggestion on a good name? (TOPDIR_OR_CUSTOM_ROOT does not qualify as "good name", imho.) /Magnus /Erik On 2018-03-06 01:23, Magnus Ihse Bursie wrote: This fix will enable patch files for COMPARE_BUILD to be hosted in a custom root. Bug: https://bugs.openjdk.java.net/browse/JDK-8199103 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8199103-use-PATCH-in-COMPARE_BUILD-custom-root/webrev.01 /Magnus
RFR: JDK-8199125: --disable-warnings-as-errors does not work for native jtreg test code
In TestFilesCompilation.gmk we still add $(CFLAGS_WARNINGS_ARE_ERRORS) explicitly to CFLAGS. This is both redundant and wrong since we are now handling these flags automatically in the macro SetupNativeCompilation. The consequence is that --disable-warnings-as-errors won't work for jtreg tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8196458 Webrev: http://cr.openjdk.java.net/~erikj/8199125/webrev.01/ /Erik
Re: RFR: JDK-8199103 Can't use COMPARE_BUILD with PATCH from custom root
Looks good. When looking at this patch, I realized that topdir has a different meaning depending on if you are in the HAS_SPEC conditional or not. In the first section, topdir is always the open root dir, but in the else section it is set to CUSTOM_ROOT if available. This is rather confusing. Could we unify the value of this variable? /Erik On 2018-03-06 01:23, Magnus Ihse Bursie wrote: This fix will enable patch files for COMPARE_BUILD to be hosted in a custom root. Bug: https://bugs.openjdk.java.net/browse/JDK-8199103 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8199103-use-PATCH-in-COMPARE_BUILD-custom-root/webrev.01 /Magnus
Re: RFR: JDK-8199103 Can't use COMPARE_BUILD with PATCH from custom root
Looks good. When looking at this patch, I realized that topdir has a different meaning depending on if you are in the HAS_SPEC conditional or not. In the first section, topdir is always the open root dir, but in the else section it is set to CUSTOM_ROOT if available. This is rather confusing. Could we unify the value of this variable? /Erik On 2018-03-06 01:23, Magnus Ihse Bursie wrote: This fix will enable patch files for COMPARE_BUILD to be hosted in a custom root. Bug: https://bugs.openjdk.java.net/browse/JDK-8199103 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8199103-use-PATCH-in-COMPARE_BUILD-custom-root/webrev.01 /Magnus
Re: RFR: JDK-8199118 Filtering of filename for microsoft CL broken on newer Cygwin
Looks good. /Erik On 2018-03-06 05:37, Magnus Ihse Bursie wrote: The code in NativeCompilation.gmk that was supposed to filter out CL's printing of the file being compiled has stopped working on modern Cygwin, since Cygwin grep is broken and cannot handle Windows line endings. We've seen this in multiple places, but has not been able to provide a generic solution, so we need to fix it in place for every occasion. Bug: https://bugs.openjdk.java.net/browse/JDK-8199118 Patch inline: diff --git a/make/common/NativeCompilation.gmk b/make/common/NativeCompilation.gmk --- a/make/common/NativeCompilation.gmk +++ b/make/common/NativeCompilation.gmk @@ -321,7 +321,7 @@ $$(call ExecuteWithLog, $$@, \ $$($1_$2_COMP) $$($1_$2_FLAGS) -showIncludes $$($1_$2_DEBUG_OUT_FLAGS) \ $(CC_OUT_OPTION)$$($1_$2_OBJ) $2) \ - | $(GREP) -v -e "^Note: including file:" \ + | $(TR) -d '\r' | $(GREP) -v -e "^Note: including file:" \ -e "^$(notdir $2)" || test "?" = "1" ; \ $(ECHO) $$@: \\ > $$($1_$2_DEP) ; \ $(SED) $(WINDOWS_SHOWINCLUDE_SED_PATTERN) $$($1_$2_OBJ).log \ /Magnus
RFR: JDK-8199103 Can't use COMPARE_BUILD with PATCH from custom root
This fix will enable patch files for COMPARE_BUILD to be hosted in a custom root. Bug: https://bugs.openjdk.java.net/browse/JDK-8199103 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8199103-use-PATCH-in-COMPARE_BUILD-custom-root/webrev.01 /Magnus
