Hi Aleksey!
Please remember to include build-dev whenever you make changes to the
build system.
Build part of your webrev looks good.
/Magnus
On 2018-05-21 15:07, Aleksey Shipilev wrote:
Hi,
This is third (and hopefully final) round of code review for Epsilon GC changes.
JEP, targeted to
From the bug report:
This line in Docs.gmk is incorrect, and should be removed.
-tag version \
It incorrectly enables support for the @version tag, which should only
be enabled by the (poorly-named) -version option. (@version and
-version are a similar pair to @author and -author).
A small
Hi!
On 05/19/2018 11:20 AM, Aleksey Shipilev wrote:
> Other GCs that would eventually bring their own BarrierSetC2 files (e.g.
> Epsilon, Shenandoah, ZGC)
> would require excluding their "gc//c2" as well.
I'm seeing this bug on linux-sparc as well.
Does SPARC have support for C2 on Solaris so t
On 05/24/2018 02:38 PM, John Paul Adrian Glaubitz wrote:
> Hi!
>
> On 05/19/2018 11:20 AM, Aleksey Shipilev wrote:
>> Other GCs that would eventually bring their own BarrierSetC2 files (e.g.
>> Epsilon, Shenandoah, ZGC)
>> would require excluding their "gc//c2" as well.
>
> I'm seeing this bug o
On 2018-05-24 06:52, Weijun Wang wrote:
Good. It's now simply
$(GENDATA_PUBLICSUFFIXLIST): $(GENDATA_PUBLICSUFFIXLIST_SRC) $(BUILD_TOOLS)
$(call LogInfo, Generating public suffix list)
$(call MakeDir, $(@D))
$(RM) $@
$(TOOL_PUBLICSUFFIXLIST) $< $@
$(CHMOD) 444 $@
Thanks
Max
On 05/24/2018 02:42 PM, Aleksey Shipilev wrote:
>> Does SPARC have support for C2 on Solaris so that we need to
>> add it for linux-sparc as well or is this limited to x86_64 only?
>
> You must be seeing something new, because the fix for Minimal and Zero was
> pushed to jdk/jdk
> already. Submit
On 05/24/2018 02:49 PM, John Paul Adrian Glaubitz wrote:
> On 05/24/2018 02:42 PM, Aleksey Shipilev wrote:
>>> Does SPARC have support for C2 on Solaris so that we need to
>>> add it for linux-sparc as well or is this limited to x86_64 only?
>>
>> You must be seeing something new, because the fix f
On 05/24/2018 02:53 PM, Aleksey Shipilev wrote:
> Yeah, but this issue dealt with:
>
> /pool/buildbot/slaves/sobornost/jdkX/build/src/hotspot/share/opto/optoreg.hpp:32:39:
> fatal error:
> adfiles/adGlobals_x86.hpp: No such file or directory
> #include CPU_HEADER(adfiles/adGlobals)
>
> Let's no
On 05/24/2018 02:55 PM, John Paul Adrian Glaubitz wrote:
> On 05/24/2018 02:53 PM, Aleksey Shipilev wrote:
>> Yeah, but this issue dealt with:
>>
>> /pool/buildbot/slaves/sobornost/jdkX/build/src/hotspot/share/opto/optoreg.hpp:32:39:
>> fatal error:
>> adfiles/adGlobals_x86.hpp: No such file or di
On 05/24/2018 02:09 PM, Magnus Ihse Bursie wrote:
> Please remember to include build-dev whenever you make changes to the build
> system.
Yeah, this was by accident: the prior webrevs had no changes in the build
system, and only after GC
modularization uptake some of them emerged.
> Build part
On 05/24/2018 02:57 PM, Aleksey Shipilev wrote:
> Oh. I am just confused you are replying to the stale review thread for
> "Minimal, Zero builds fail
> after JDK-8202377 (Modularize C2 barriers)". What you are seeing is something
> else.
As I said, "hg blame" indicates the change which probably
On 24/05/2018 10:55 PM, John Paul Adrian Glaubitz wrote:
On 05/24/2018 02:53 PM, Aleksey Shipilev wrote:
Yeah, but this issue dealt with:
/pool/buildbot/slaves/sobornost/jdkX/build/src/hotspot/share/opto/optoreg.hpp:32:39:
fatal error:
adfiles/adGlobals_x86.hpp: No such file or directory
#in
On 05/24/2018 02:59 PM, John Paul Adrian Glaubitz wrote:
> On 05/24/2018 02:57 PM, Aleksey Shipilev wrote:
>> Oh. I am just confused you are replying to the stale review thread for
>> "Minimal, Zero builds fail
>> after JDK-8202377 (Modularize C2 barriers)". What you are seeing is
>> something el
On 05/24/2018 03:01 PM, David Holmes wrote:
>> I'm not building Zero in this case but Hotspot native for linux-sparc.
>
> Are you building an interpreter only version of linux-sparc?
No, I don't think so:
MAKE_VERBOSE=y QUIETLY= LOG=debug sh ./configure --with-jvm-variants=server
Looks good to me.
-- Jon
On 5/24/18 5:32 AM, Magnus Ihse Bursie wrote:
From the bug report:
This line in Docs.gmk is incorrect, and should be removed.
-tag version \
It incorrectly enables support for the @version tag, which should only
be enabled by the (poorly-named) -version option. (@
This looks ok to me.
/Erik
On 2018-05-23 18:08, Ao Qi wrote:
Hi Erik,
Thanks for your comments. I made a new patch:
$ hg diff
diff -r 31361382634b make/autoconf/build-aux/config.guess
--- a/make/autoconf/build-aux/config.guess Tue May 22 10:08:04 2018 -0700
+++ b/make/autoconf/build-aux/conf
Looks good.
/Erik
On 2018-05-24 05:32, Magnus Ihse Bursie wrote:
From the bug report:
This line in Docs.gmk is incorrect, and should be removed.
-tag version \
It incorrectly enables support for the @version tag, which should only
be enabled by the (poorly-named) -version option. (@versio
Now that we have support for building with VS2017, it's time to change
the default compiler picked up by the configure script to VS2017.
Oracle is also changing the version used internally, by updating
jib-profiles.js
Webrev: http://cr.openjdk.java.net/~erikj/8203795/webrev.01/
Bug: https://
# The order of these defines the priority by which we try to find them.
-VALID_VS_VERSIONS="2013 2012 2010 2015 2017"
+VALID_VS_VERSIONS="2017 2015 2013 2012 2010"
I think it better to have VS2013 as the 2nd option since 2015
was never an official compiler and people might have 2015 configs that
Hi Igor,
It looks good to me.
Thanks,
Serguei
On 5/22/18 16:35, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8199383/webrev.00/index.html
308253 lines changed: 308253 ins; 0 del; 0 mod;
Hi all,
could you please review this patch which open sources JVMTI tests from VM
testba
Hi Erik,
will Oracle change the jdk-submit builds to VS2017? Most of our guys
still work with VS2013, so we may miss build errors on our machines.
Thanks, Thomas
On Fri, May 25, 2018 at 12:26 AM, Erik Joelsson
wrote:
> Now that we have support for building with VS2017, it's time to change the
>
21 matches
Mail list logo
