Re: RFR: 8210416: [linux] Poor StrictMath performance due to non-optimized compilation

2018-09-11 Thread Severin Gehwolf
On Mon, 2018-09-10 at 09:29 -0700, Erik Joelsson wrote: > I see. I was not aware of that issue, but we clearly need to file a bug > for it and fix it. In this case I think it's fine to us the macro however. OK. Update webrev, which now uses FLAGS_COMPILER_CHECK_ARGUMENTS. http://cr.openjdk.java.

Re: RFR: 8210416: [linux] Poor StrictMath performance due to non-optimized compilation

2018-09-11 Thread Erik Joelsson
Hello Severin, Even if using the macro, I still think you need to add a condition on the compiler types where the switch can be reasonably expected to exist. /Erik On 2018-09-11 05:02, Severin Gehwolf wrote: On Mon, 2018-09-10 at 09:29 -0700, Erik Joelsson wrote: I see. I was not aware of

Re: [llvm-dev] OpenJDK8 failed to work after compiled by LLVM 8 for X86

2018-09-11 Thread Leslie Zhai
Hi Dimitry, Thank you so much for the reduced testcase!  It is able to reproduce after compiled with clang-8 optimized for X86: $ clang++ -O3 -S -c JDK-8205969.cpp -o JDK-8205969-opt-8.0.s $ clang++ -O3 -c JDK-8205969.cpp -o JDK-8205969-opt-8.0.o $ clang++ -o JDK-8205969-opt-8.0.out JDK-820596

Re: RFR: 8210416: [linux] Poor StrictMath performance due to non-optimized compilation

2018-09-11 Thread Severin Gehwolf
Hi Erik, Thanks for the review! On Tue, 2018-09-11 at 08:57 -0700, Erik Joelsson wrote: > Hello Severin, > > Even if using the macro, I still think you need to add a condition on > the compiler types where the switch can be reasonably expected to exist. How about this? http://cr.openjdk.java.n

Re: RFR: 8210416: [linux] Poor StrictMath performance due to non-optimized compilation

2018-09-11 Thread Erik Joelsson
Looks good, thanks! /Erik On 2018-09-11 09:14, Severin Gehwolf wrote: Hi Erik, Thanks for the review! On Tue, 2018-09-11 at 08:57 -0700, Erik Joelsson wrote: Hello Severin, Even if using the macro, I still think you need to add a condition on the compiler types where the switch can be reas

Re: RFR: JDK-8210519: build/releaseFile/CheckSource.java failed additional sources found

2018-09-11 Thread Mikael Vidstedt
Looks good, thanks for fixing. Arguably the ":((hg)|(git)):[a-z0-9]*\\+?” string could be a constant (re-)used in the two places it occurs, and the nested if statements inside checking the Oracle specific part could be turned around to check "if (isOpenJDK)” first to avoid the negation, but t

Re: RFR: JDK-8210519: build/releaseFile/CheckSource.java failed additional sources found

2018-09-11 Thread Erik Joelsson
Hello, I do agree with your points. http://cr.openjdk.java.net/~erikj/8210519/webrev.02/ On 2018-09-11 11:32, Mikael Vidstedt wrote: Looks good, thanks for fixing. Arguably the ":((hg)|(git)):[a-z0-9]*\\+?” string could be a constant (re-)used in the two places it occurs, and the nested if

Re: [llvm-dev] OpenJDK8 failed to work after compiled by LLVM 8 for X86

2018-09-11 Thread Martin Buchholz
https://openjdk.markmail.org/thread/rwfcd6df6vhzli5m

Re: RFR: JDK-8210519: build/releaseFile/CheckSource.java failed additional sources found

2018-09-11 Thread Mikael Vidstedt
Beautiful, thanks for fixing! Cheers, Mikael > On Sep 11, 2018, at 11:39 AM, Erik Joelsson wrote: > > Hello, > > I do agree with your points. > > http://cr.openjdk.java.net/~erikj/8210519/webrev.02/ > > > On 2018-09-11 11:32, Mikael Vidstedt wrote: >> Looks good, thanks for fixing. >> >>

Re: [llvm-dev] OpenJDK8 failed to work after compiled by LLVM 8 for X86

2018-09-11 Thread David Holmes
Or to be a little less obscure, this is a known issue and you should look into backporting: https://bugs.openjdk.java.net/browse/JDK-8205965 David On 12/09/2018 5:03 AM, Martin Buchholz wrote: https://openjdk.markmail.org/thread/rwfcd6df6vhzli5m

Re: [llvm-dev] OpenJDK8 failed to work after compiled by LLVM 8 for X86

2018-09-11 Thread Leslie Zhai
Hi, Thanks for your kind response! 在 2018年09月12日 10:58, David Holmes 写道: Or to be a little less obscure, this is a known issue and you should look into backporting: https://bugs.openjdk.java.net/browse/JDK-8205965 Already known :) http://mail.openjdk.java.net/pipermail/build-dev/2018-Septem

Re: RFR: 8210416: [linux] Poor StrictMath performance due to non-optimized compilation

2018-09-11 Thread Gustavo Romero
Hi Severin, On 09/11/2018 09:02 AM, Severin Gehwolf wrote: Micro-benchmark results from running [1] for x86_64 and ppc64le are here (-O2 is sufficient it seems): http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210416/microbenchmarks_results/ More thoughts? Thanks a lot for checking it on P

Re: RFR: 8210416: [linux] Poor StrictMath performance due to non-optimized compilation

2018-09-11 Thread David Holmes
Hi Severin, Sorry I'm a bit confused now. Originally for ppc/s390x/aarch64 the optimization level for fdlibm was HIGH. But now it will be LOW due to: 45 ifneq ($(FDLIBM_CFLAGS), ) 46 BUILD_LIBFDLIBM_OPTIMIZATION := LOW as those platforms will use gcc/clang with support for -ffp-contrac

Re: RFR: JDK-8210519: build/releaseFile/CheckSource.java failed additional sources found

2018-09-11 Thread David Holmes
Looks okay to me too. Thanks, David On 12/09/2018 4:39 AM, Erik Joelsson wrote: Hello, I do agree with your points. http://cr.openjdk.java.net/~erikj/8210519/webrev.02/ On 2018-09-11 11:32, Mikael Vidstedt wrote: Looks good, thanks for fixing. Arguably the ":((hg)|(git)):[a-z0-9]*\\+?” st

Re: [llvm-dev] OpenJDK8 failed to work after compiled by LLVM 8 for X86

2018-09-11 Thread David Holmes
On 12/09/2018 1:18 PM, Leslie Zhai wrote: Hi, Thanks for your kind response! 在 2018年09月12日 10:58, David Holmes 写道: Or to be a little less obscure, this is a known issue and you should look into backporting: https://bugs.openjdk.java.net/browse/JDK-8205965 Already known :) http://mail.openj