Hi Pengfei,
On 29/11/2019 03:56, Pengfei Li (Arm Technology China) wrote:
> Please help review this small fix for 64-bit client build.
>
> Webrev: http://cr.openjdk.java.net/~pli/rfr/8234791/webrev.00/
> JBS: https://bugs.openjdk.java.net/browse/JDK-8234791
>
> Current 64-bit client VM build fa
Hi Andrew Dinn,
> Your explanation sounds correct and the change to arguments.cpp looks
> good.
>
> Can you explain why you have modified sharedRuntime_aarch64.cpp to
> include nativeInst_aarch64.hpp? I don't see any other change in the source
> file that would make this necessary.
Thanks for re
On 11/29/19 10:01 AM, Pengfei Li (Arm Technology China) wrote:
> Thanks for review. There is another build error below after I fixed
> arguments.cpp.
>
> For target hotspot_variant-client_libjvm_objs_sharedRuntime_aarch64.o:
> ../src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp:2836:22: erro
HiPengfei,
On 29/11/2019 10:01, Pengfei Li (Arm Technology China) wrote:
>> Can you explain why you have modified sharedRuntime_aarch64.cpp to
>> include nativeInst_aarch64.hpp? I don't see any other change in the source
>> file that would make this necessary.
>
> Thanks for review. There is anot
Hi Pengfei,
I have cc-ed hotspot-compiler-...@openjdk.java.net.
Please do not push the patch until someone from hotspot-compiler-dev has
looked at it.
Many people are away due to Thanksgiving in the US.
Thanks
- Ioi
On 11/28/19 7:56 PM, Pengfei Li (Arm Technology China) wrote:
Hi,
Please
On 11/27/19 10:03 AM, Doerr, Martin wrote:
Hi Claes,
that kind of surprises me. I'd expect files which rather benefit from -O3 to be
far less than those which benefit from -Os.
Most performance critical code lives inside the code cache and is not dependent
on C++ compiler optimizations.
I'd
