Re: JDK 16 RFR of JDK-8251549: Update docs on building for Git

2020-08-14 Thread Magnus Ihse Bursie
On 2020-08-13 19:40, Joe Darcy wrote: Hello, Ahead of the JDK switching to Git, please review the updates to the build docs:     JDK-8251549: Update docs on building for Git     http://cr.openjdk.java.net/~darcy/8251549.0/ This would be pushed shortly *after* the transition to Git. Once the

Re: JDK 16 RFR of JDK-8251549: Update docs on building for Git

2020-08-14 Thread Magnus Ihse Bursie
On 2020-08-13 19:40, Joe Darcy wrote: Hello, Ahead of the JDK switching to Git, please review the updates to the build docs:     JDK-8251549: Update docs on building for Git     http://cr.openjdk.java.net/~darcy/8251549.0/ Also (more a stylistic thing): +    `git clone https://git.openjdk.ja

Re: RFR: JDK-8251541 "no symbols" printed when building hotspot

2020-08-14 Thread Erik Joelsson
On 2020-08-13 08:26, Magnus Ihse Bursie wrote: Recently a lot of "no symbols" is shown when building hotspot, at least on macOS. This comes from the new/delete operator check which uses nm. I have checked the source of these problems. Several files are now empty due to refactoring and the use

Re: RFR: JDK-8251541 "no symbols" printed when building hotspot

2020-08-14 Thread Magnus Ihse Bursie
On 2020-08-14 14:49, Erik Joelsson wrote: On 2020-08-13 08:26, Magnus Ihse Bursie wrote: Recently a lot of "no symbols" is shown when building hotspot, at least on macOS. This comes from the new/delete operator check which uses nm. I have checked the source of these problems. Several files ar

Re: RFR: JDK-8251541 "no symbols" printed when building hotspot

2020-08-14 Thread Erik Joelsson
Ok by me. /Erik On 2020-08-14 06:21, Magnus Ihse Bursie wrote: On 2020-08-14 14:49, Erik Joelsson wrote: On 2020-08-13 08:26, Magnus Ihse Bursie wrote: Recently a lot of "no symbols" is shown when building hotspot, at least on macOS. This comes from the new/delete operator check which uses