Re: [aarch64-port-dev ] RFR(L): 8231441: AArch64: Initial SVE backend support

2020-08-19 Thread Ningsheng Jian
Hi Andrew, I have updated the patch based on the review comments. Would you mind taking another look? Thanks! Full: http://cr.openjdk.java.net/~njian/8231441/webrev.04/ Incremental: http://cr.openjdk.java.net/~njian/8231441/webrev.04-vs-03/ Also add build-dev, as there's a makefile change.

Re: [aarch64-port-dev ] RFR(L): 8231441: AArch64: Initial SVE backend support

2020-08-19 Thread Magnus Ihse Bursie
On 2020-08-19 11:53, Ningsheng Jian wrote: Hi Andrew, I have updated the patch based on the review comments. Would you mind taking another look? Thanks! Full: http://cr.openjdk.java.net/~njian/8231441/webrev.04/ Build changes look good. Thank you for remembering to cc build-dev! This is may

Re: [aarch64-port-dev ] RFR(L): 8231441: AArch64: Initial SVE backend support

2020-08-19 Thread Ningsheng Jian
Hi Magnus, Thanks for the review! On 8/19/20 6:05 PM, Magnus Ihse Bursie wrote: On 2020-08-19 11:53, Ningsheng Jian wrote: Hi Andrew, I have updated the patch based on the review comments. Would you mind taking another look? Thanks! Full: http://cr.openjdk.java.net/~njian/8231441/webrev.04/

Re: [aarch64-port-dev ] RFR(L): 8231441: AArch64: Initial SVE backend support

2020-08-19 Thread Andrew Haley
On 19/08/2020 11:05, Magnus Ihse Bursie wrote: > This is maybe not relevant, but I was surprised to find > src/hotspot/cpu/aarch64/aarch64-asmtest.py, because a) it's python code, > and b) the name implies that it is a test, even though that it resides > in src. Is this really proper? I have no id

Re: [aarch64-port-dev ] RFR(L): 8231441: AArch64: Initial SVE backend support

2020-08-19 Thread Andrew Dinn
Hi Ningsheng, On 19/08/2020 10:53, Ningsheng Jian wrote: > I have updated the patch based on the review comments. Would you mind > taking another look? Thanks! > > Full: > http://cr.openjdk.java.net/~njian/8231441/webrev.04/ > > Incremental: > http://cr.openjdk.java.net/~njian/8231441/webrev.04-

Re: [aarch64-port-dev ] RFR(L): 8231441: AArch64: Initial SVE backend support

2020-08-19 Thread Ningsheng Jian
Hi Andrew, On 8/19/20 9:01 PM, Andrew Dinn wrote: Hi Ningsheng, On 19/08/2020 10:53, Ningsheng Jian wrote: I have updated the patch based on the review comments. Would you mind taking another look? Thanks! Full: http://cr.openjdk.java.net/~njian/8231441/webrev.04/ Incremental: http://cr.open

Re: [aarch64-port-dev ] RFR(L): 8231441: AArch64: Initial SVE backend support

2020-08-19 Thread Nick Gasson
On 08/19/20 19:10 pm, Andrew Haley wrote: > On 19/08/2020 11:05, Magnus Ihse Bursie wrote: >> This is maybe not relevant, but I was surprised to find >> src/hotspot/cpu/aarch64/aarch64-asmtest.py, because a) it's python code, >> and b) the name implies that it is a test, even though that it resides