On 08/19/20 19:10 pm, Andrew Haley wrote: > On 19/08/2020 11:05, Magnus Ihse Bursie wrote: >> This is maybe not relevant, but I was surprised to find >> src/hotspot/cpu/aarch64/aarch64-asmtest.py, because a) it's python code, >> and b) the name implies that it is a test, even though that it resides >> in src. Is this really proper? > > I have no idea whether it's really proper, but it allows us to check > that instructions are encoded correctly by cross-checking with the > system's assembler. There might well be a more hygienic way to do > that, but I don't want to be without it.
It is perhaps a bit strange to have the test code under src/ and embedded in the assembler implementation. How about we move it under test/ using the existing gtest framework for native code tests? That runs in tier1 and also for release builds. I tried this just now and it's easy to do. -- Thanks, Nick
