Integrated: 8256393: Github Actions build on Linux should define OS and GCC versions

2020-11-20 Thread Robin Westberg
On Mon, 16 Nov 2020 12:51:25 GMT, Robin Westberg wrote: > We should be more explicit about OS and compiler versions used in the GitHub > Actions builds, to avoid problems caused by unexpected changes to the > defaults. This patch changes the OS and GCC versions used from ubuntu-latest > (curre

Integrated: 8255526: Enable jcheck whitespace checking of build system files

2020-11-20 Thread Magnus Ihse Bursie
On Wed, 28 Oct 2020 10:16:36 GMT, Magnus Ihse Bursie wrote: > With the new Skara tooling, we can finally enable whitespace testing for > build system files (makefiles and autoconf files). This pull request has now been integrated. Changeset: 8e7a855e Author:Magnus Ihse Bursie URL: h

Re: RFR: 8256240: Reproducible builds should turn on the "deterministic" flag for Visual Studio

2020-11-20 Thread Erik Joelsson
On Wed, 18 Nov 2020 10:35:58 GMT, Magnus Ihse Bursie wrote: > The microsoft toolchain now supports a new "deterministic" build mode. This > goes a long way towards building properly deterministic. Another important > feature is that with the deterministic build mode enabled, the -pathmap flag,

RFR: 8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing

2020-11-20 Thread Robin Westberg
Currently Linux x64 testing in GitHub Actions depends on a few non-relevant hotspot build-only jobs (such as zero) that prevents testing from being run if those build were to fail. As the tests only require the x64 release and debug builds to run and provide interesting feedback, we should separ

RFR: JDK-8256751: Incremental rebuild with precompiled header fails when touching a header file

2020-11-20 Thread Erik Joelsson
When building with --disable-absolute-paths-in-output and precompiled header enabled (both of which are default in release builds), then incremental builds of Hotspot fails if a header file is touched. This is caused by the deps file the compiler generates is now containing relative paths, but

Re: RFR: 8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing

2020-11-20 Thread Aleksey Shipilev
On Fri, 20 Nov 2020 14:24:12 GMT, Robin Westberg wrote: > Currently Linux x64 testing in GitHub Actions depends on a few non-relevant > hotspot build-only jobs (such as zero) that prevents testing from being run > if those build were to fail. As the tests only require the x64 release and > deb

Re: RFR: 8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing [v2]

2020-11-20 Thread Robin Westberg
> Currently Linux x64 testing in GitHub Actions depends on a few non-relevant > hotspot build-only jobs (such as zero) that prevents testing from being run > if those build were to fail. As the tests only require the x64 release and > debug builds to run and provide interesting feedback, we shou

Re: RFR: 8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing [v2]

2020-11-20 Thread Robin Westberg
On Fri, 20 Nov 2020 14:39:54 GMT, Aleksey Shipilev wrote: >> Robin Westberg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Improve naming, fix style issues > > .github/workflows/submit.yml line 380: > >> 378: continue-on-error:

Re: RFR: JDK-8256751: Incremental rebuild with precompiled header fails when touching a header file

2020-11-20 Thread Magnus Ihse Bursie
On Fri, 20 Nov 2020 14:35:27 GMT, Erik Joelsson wrote: > When building with --disable-absolute-paths-in-output and precompiled header > enabled (both of which are default in release builds), then incremental > builds of Hotspot fails if a header file is touched. > > This is caused by the deps

Re: RFR: 8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing [v2]

2020-11-20 Thread Aleksey Shipilev
On Fri, 20 Nov 2020 16:14:19 GMT, Robin Westberg wrote: >> Currently Linux x64 testing in GitHub Actions depends on a few non-relevant >> hotspot build-only jobs (such as zero) that prevents testing from being run >> if those build were to fail. As the tests only require the x64 release and >>

Re: RFR: 8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing [v2]

2020-11-20 Thread Aleksey Shipilev
On Fri, 20 Nov 2020 16:09:59 GMT, Robin Westberg wrote: >> .github/workflows/submit.yml line 469: >> >>> 467: name: transient_jdk-linux-x64_${{ >>> needs.prerequisites.outputs.bundle_id }} >>> 468: path: ~/jdk-linux-x64 >>> 469: if: steps.build_restore.outcome == 'fa

Re: RFR: 8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing [v2]

2020-11-20 Thread Aleksey Shipilev
On Fri, 20 Nov 2020 17:31:51 GMT, Aleksey Shipilev wrote: >> Robin Westberg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Improve naming, fix style issues > > Looks good! A few minor nits, if you want to address them. Ah wait, I now s

RFR: 8247432: Update IANA Language Subtag Registry to Version 2020-09-29

2020-11-20 Thread Naoto Sato
Hi, Please review the changes to the subject issue. This is to incorporate the latest language subtag registry definition into the JDK. - Commit messages: - LSR 2020-09-29 - LSR 2020-07-17 Changes: https://git.openjdk.java.net/jdk/pull/1357/files Webrev: https://webrevs.openjdk.

Integrated: JDK-8256751: Incremental rebuild with precompiled header fails when touching a header file

2020-11-20 Thread Erik Joelsson
On Fri, 20 Nov 2020 14:35:27 GMT, Erik Joelsson wrote: > When building with --disable-absolute-paths-in-output and precompiled header > enabled (both of which are default in release builds), then incremental > builds of Hotspot fails if a header file is touched. > > This is caused by the deps

Re: RFR: 8247432: Update IANA Language Subtag Registry to Version 2020-09-29

2020-11-20 Thread Joe Wang
On Fri, 20 Nov 2020 17:55:55 GMT, Naoto Sato wrote: > Hi, > > Please review the changes to the subject issue. This is to incorporate the > latest language subtag registry definition into the JDK. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/

RFR: JDK-8256810: Incremental rebuild broken on Macosx

2020-11-20 Thread Erik Joelsson
After fixing JDK-8256751, I noticed that the fix-deps-file macro isn't actually doing the right thing at all. It seems clang on Macosx is inconsistent with outputting relative or absolute paths in the deps files, so some files end up with double WORKSPACE_ROOT in the paths. It's also not handlin

Re: RFR: JDK-8256810: Incremental rebuild broken on Macosx

2020-11-20 Thread Mikael Vidstedt
On Sat, 21 Nov 2020 00:12:30 GMT, Erik Joelsson wrote: > After fixing JDK-8256751, I noticed that the fix-deps-file macro isn't > actually doing the right thing at all. It seems clang on Macosx is > inconsistent with outputting relative or absolute paths in the deps files, so > some files end