RFR: JDK-8269031: linux x86_64 check for binutils 2.25 or higher after 8265783

2021-06-22 Thread Matthias Baesken
This change adds a check for binutils 2.25 or higher after 8265783. The change 8265783 introduced on linux x86_64 a minimum requirement for binutils : "Minimum required would be binutils 2.25 where AVX512 support was added for Skylake." (see https://bugs.openjdk.java.net/browse/JDK-8265783 ) I

Re: RFR: JDK-8269031: linux x86_64 check for binutils 2.25 or higher after 8265783

2021-06-22 Thread Magnus Ihse Bursie
On Tue, 22 Jun 2021 07:39:28 GMT, Matthias Baesken wrote: > This change adds a check for binutils 2.25 or higher after 8265783. The > change 8265783 introduced on linux x86_64 a minimum requirement for binutils > : "Minimum required would be binutils 2.25 where AVX512 support was added for > S

Re: RFR: JDK-8269031: linux x86_64 check for binutils 2.25 or higher after 8265783 [v2]

2021-06-22 Thread Matthias Baesken
> This change adds a check for binutils 2.25 or higher after 8265783. The > change 8265783 introduced on linux x86_64 a minimum requirement for binutils > : "Minimum required would be binutils 2.25 where AVX512 support was added for > Skylake." (see https://bugs.openjdk.java.net/browse/JDK-8265

Re: RFR: JDK-8269031: linux x86_64 check for binutils 2.25 or higher after 8265783

2021-06-22 Thread Matthias Baesken
On Tue, 22 Jun 2021 10:30:28 GMT, Magnus Ihse Bursie wrote: > The test should really be on as version, but I agree that it does not seem > worth the hassle to add another version check, when in practice ld and as are > bundled together as binutils. > > However, I would appreciate a comment cla

Re: RFR: JDK-8269031: linux x86_64 check for binutils 2.25 or higher after 8265783 [v2]

2021-06-22 Thread Erik Joelsson
On Tue, 22 Jun 2021 11:18:47 GMT, Matthias Baesken wrote: >> This change adds a check for binutils 2.25 or higher after 8265783. The >> change 8265783 introduced on linux x86_64 a minimum requirement for binutils >> : "Minimum required would be binutils 2.25 where AVX512 support was added >> f

Integrated: JDK-8269031: linux x86_64 check for binutils 2.25 or higher after 8265783

2021-06-22 Thread Matthias Baesken
On Tue, 22 Jun 2021 07:39:28 GMT, Matthias Baesken wrote: > This change adds a check for binutils 2.25 or higher after 8265783. The > change 8265783 introduced on linux x86_64 a minimum requirement for binutils > : "Minimum required would be binutils 2.25 where AVX512 support was added for > S

[jdk17] RFR: 8269148: Update minor GCC version in GitHub Actions pipeline

2021-06-22 Thread Aleksey Shipilev
It seems Ubuntu had bumped the version for GCC, so GHA started to fail with e.g.: The following packages have unmet dependencies: g++-10-s390x-linux-gnu : Depends: gcc-10-s390x-linux-gnu-base (= 10.2.0-5ubuntu1~20.04cross1) but 10.3.0-1ubuntu1~20.04cross1 is to be installed gcc-10-s390x-linux

Re: [jdk17] RFR: 8269148: Update minor GCC version in GitHub Actions pipeline

2021-06-22 Thread Erik Joelsson
On Tue, 22 Jun 2021 17:20:14 GMT, Aleksey Shipilev wrote: > It seems Ubuntu had bumped the version for GCC, so GHA started to fail with > e.g.: > > > The following packages have unmet dependencies: > g++-10-s390x-linux-gnu : Depends: gcc-10-s390x-linux-gnu-base (= > 10.2.0-5ubuntu1~20.04cros

Re: [jdk17] RFR: 8269148: Update minor GCC version in GitHub Actions pipeline

2021-06-22 Thread Xin Liu
On Tue, 22 Jun 2021 17:20:14 GMT, Aleksey Shipilev wrote: > It seems Ubuntu had bumped the version for GCC, so GHA started to fail with > e.g.: > > > The following packages have unmet dependencies: > g++-10-s390x-linux-gnu : Depends: gcc-10-s390x-linux-gnu-base (= > 10.2.0-5ubuntu1~20.04cros

Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v6]

2021-06-22 Thread Scott Gibbons
> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration. > Also allows for performance improvement for non-AVX-512 enabled platforms. > Due to the nature of MIME-encoded inputs, modify the intrinsic signature to > accept an additional parameter (isMIME) for fast-path MIME d

Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v6]

2021-06-22 Thread Sandhya Viswanathan
On Tue, 22 Jun 2021 20:47:55 GMT, Scott Gibbons wrote: >> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration. >> Also allows for performance improvement for non-AVX-512 enabled platforms. >> Due to the nature of MIME-encoded inputs, modify the intrinsic signature to >

Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v6]

2021-06-22 Thread Sandhya Viswanathan
On Tue, 22 Jun 2021 20:47:55 GMT, Scott Gibbons wrote: >> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration. >> Also allows for performance improvement for non-AVX-512 enabled platforms. >> Due to the nature of MIME-encoded inputs, modify the intrinsic signature to >

Re: [jdk17] RFR: 8269148: Update minor GCC version in GitHub Actions pipeline

2021-06-22 Thread David Holmes
On 23/06/2021 5:38 am, Xin Liu wrote: On Tue, 22 Jun 2021 17:20:14 GMT, Aleksey Shipilev wrote: It seems Ubuntu had bumped the version for GCC, so GHA started to fail with e.g.: The following packages have unmet dependencies: g++-10-s390x-linux-gnu : Depends: gcc-10-s390x-linux-gnu-base (

Re: [jdk17] RFR: 8269148: Update minor GCC version in GitHub Actions pipeline

2021-06-22 Thread David Holmes
On Tue, 22 Jun 2021 17:20:14 GMT, Aleksey Shipilev wrote: > It seems Ubuntu had bumped the version for GCC, so GHA started to fail with > e.g.: > > > The following packages have unmet dependencies: > g++-10-s390x-linux-gnu : Depends: gcc-10-s390x-linux-gnu-base (= > 10.2.0-5ubuntu1~20.04cros

Re: [jdk17] RFR: 8269148: Update minor GCC version in GitHub Actions pipeline

2021-06-22 Thread Xin Liu
On Tue, 22 Jun 2021 17:20:14 GMT, Aleksey Shipilev wrote: > It seems Ubuntu had bumped the version for GCC, so GHA started to fail with > e.g.: > > > The following packages have unmet dependencies: > g++-10-s390x-linux-gnu : Depends: gcc-10-s390x-linux-gnu-base (= > 10.2.0-5ubuntu1~20.04cros

Re: [jdk17] RFR: 8269148: Update minor GCC version in GitHub Actions pipeline

2021-06-22 Thread David Holmes
On Tue, 22 Jun 2021 17:20:14 GMT, Aleksey Shipilev wrote: > It seems Ubuntu had bumped the version for GCC, so GHA started to fail with > e.g.: > > > The following packages have unmet dependencies: > g++-10-s390x-linux-gnu : Depends: gcc-10-s390x-linux-gnu-base (= > 10.2.0-5ubuntu1~20.04cros

Re: [jdk17] RFR: 8269148: Update minor GCC version in GitHub Actions pipeline

2021-06-22 Thread Xin Liu
On Tue, 22 Jun 2021 17:20:14 GMT, Aleksey Shipilev wrote: > It seems Ubuntu had bumped the version for GCC, so GHA started to fail with > e.g.: > > > The following packages have unmet dependencies: > g++-10-s390x-linux-gnu : Depends: gcc-10-s390x-linux-gnu-base (= > 10.2.0-5ubuntu1~20.04cros

Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v7]

2021-06-22 Thread Scott Gibbons
> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration. > Also allows for performance improvement for non-AVX-512 enabled platforms. > Due to the nature of MIME-encoded inputs, modify the intrinsic signature to > accept an additional parameter (isMIME) for fast-path MIME d

Re: [jdk17] RFR: 8269148: Update minor GCC version in GitHub Actions pipeline

2021-06-22 Thread David Holmes
On 23/06/2021 10:23 am, Xin Liu wrote: On Tue, 22 Jun 2021 17:20:14 GMT, Aleksey Shipilev wrote: It seems Ubuntu had bumped the version for GCC, so GHA started to fail with e.g.: The following packages have unmet dependencies: g++-10-s390x-linux-gnu : Depends: gcc-10-s390x-linux-gnu-base

Re: RFR: 8268276: Base64 Decoding optimization for x86 using AVX-512 [v7]

2021-06-22 Thread David Holmes
On Wed, 23 Jun 2021 00:31:55 GMT, Scott Gibbons wrote: >> Add the Base64 Decode intrinsic for x86 to utilize AVX-512 for acceleration. >> Also allows for performance improvement for non-AVX-512 enabled platforms. >> Due to the nature of MIME-encoded inputs, modify the intrinsic signature to >

RFR: 8268821: Split systemDictionaryShared.cpp

2021-06-22 Thread Yumin Qi
Hi, Please review systemDictionaryShared becomes fatter and fatter so it is time to split it into functional files. Moved security and jar operation related code into CDSProtectionDomain, and moved shared class info (DumpTime/RunTime) to sharedClassInfo.[ch]pp, also moved lambda proxy related to

Re: RFR: 8268821: Split systemDictionaryShared.cpp

2021-06-22 Thread David Holmes
Hi Yumin, On 23/06/2021 4:19 pm, Yumin Qi wrote: Hi, Please review systemDictionaryShared becomes fatter and fatter so it is time to split it into functional files. Moved security and jar operation related code into CDSProtectionDomain, and moved shared class info (DumpTime/RunTime) to shared