Integrated: 8269700: source level for IntelliJ JDK project is set incorrectly

2021-07-05 Thread Sergei Ustimenko
On Wed, 30 Jun 2021 11:43:38 GMT, Sergei Ustimenko wrote: > After generating an Intellij project with the `idea.sh` script, IDEA might > get confused > with the language level settings in generated .idea/misc.xml. This results in > a problem > with modules discussed in > https://mail.openjd

Re: RFR: 8269700: source level for IntelliJ JDK project is set incorrectly

2021-07-05 Thread Sergei Ustimenko
On Wed, 30 Jun 2021 11:43:38 GMT, Sergei Ustimenko wrote: > After generating an Intellij project with the `idea.sh` script, IDEA might > get confused > with the language level settings in generated .idea/misc.xml. This results in > a problem > with modules discussed in > https://mail.openjd

Integrated: JDK-8263389 IGV: Zooming changes the point that is currently centered

2021-07-05 Thread jtfuller111
On Tue, 1 Jun 2021 20:00:07 GMT, jtfuller111 wrote: > Fixing the zoom issue on IGV. I tested this on Windows and Linux and zooming > now works as expected. This pull request has now been integrated. Changeset: 164eff8c Author:James Fuller Committer: Tobias Hartmann URL: https://g

Integrated: 8269758: idea.sh doesn't work when there are multiple configurations available.

2021-07-05 Thread Jorn Vernee
On Thu, 1 Jul 2021 14:41:53 GMT, Jorn Vernee wrote: > From the JBS issue: > > The idea.sh script invokes `make`, but doesn't specify a configuration. So, > when multiple configurations are present, this results in an error like this: > > > $ bash bin/idea.sh java.base > Error: No CONF given,

Re: RFR: 8269760: idea.sh should not invoke cygpath directly [v2]

2021-07-05 Thread Jorn Vernee
> From the JBS issue: > > Currently idea.sh checks if `CYGPATH` is set, and then continues by invoking > `cygpath` directly. > > This doesn't work if `CYGPATH` is not actually set to `cygpath`, but to > something else, such as `wslpath`. > > Instead of invoking `cygpath` directly, the value of

Integrated: 8269760: idea.sh should not invoke cygpath directly

2021-07-05 Thread Jorn Vernee
On Thu, 1 Jul 2021 14:54:04 GMT, Jorn Vernee wrote: > From the JBS issue: > > Currently idea.sh checks if `CYGPATH` is set, and then continues by invoking > `cygpath` directly. > > This doesn't work if `CYGPATH` is not actually set to `cygpath`, but to > something else, such as `wslpath`. >

Re: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL

2021-07-05 Thread openjdk-notifier [bot]
On Thu, 1 Jul 2021 15:02:03 GMT, Jorn Vernee wrote: > From the JBS issue: > > At the end, idea.sh tries to invoke javac, but when running on WSL this > results in the following error: > > bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such > file or directory > > Adding

Re: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v2]

2021-07-05 Thread Jorn Vernee
On Mon, 5 Jul 2021 10:31:13 GMT, Jorn Vernee wrote: >> From the JBS issue: >> >> At the end, idea.sh tries to invoke javac, but when running on WSL this >> results in the following error: >> >> bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such >> file or directory >>

Re: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v3]

2021-07-05 Thread Jorn Vernee
> From the JBS issue: > > At the end, idea.sh tries to invoke javac, but when running on WSL this > results in the following error: > > bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such > file or directory > > Adding a .exe suffix to the javac path fixes this issue, whi

Re: RFR: 8269760: idea.sh should not invoke cygpath directly

2021-07-05 Thread openjdk-notifier [bot]
On Thu, 1 Jul 2021 14:54:04 GMT, Jorn Vernee wrote: > From the JBS issue: > > Currently idea.sh checks if `CYGPATH` is set, and then continues by invoking > `cygpath` directly. > > This doesn't work if `CYGPATH` is not actually set to `cygpath`, but to > something else, such as `wslpath`. >

Re: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v3]

2021-07-05 Thread Jorn Vernee
On Mon, 5 Jul 2021 10:40:15 GMT, Jorn Vernee wrote: >> From the JBS issue: >> >> At the end, idea.sh tries to invoke javac, but when running on WSL this >> results in the following error: >> >> bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such >> file or directory >>

Re: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v2]

2021-07-05 Thread Jorn Vernee
> From the JBS issue: > > At the end, idea.sh tries to invoke javac, but when running on WSL this > results in the following error: > > bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such > file or directory > > Adding a .exe suffix to the javac path fixes this issue, whi

RFR: 8268860: Windows-Aarch64 build is failing in GitHub actions

2021-07-05 Thread Magnus Ihse Bursie
GHA for Windows/aarch64 was disabled in [JDK-8268861](https://bugs.openjdk.java.net/browse/JDK-8268861). The problem with GHA for windows/aarch64 was due to using Visual Studio 14.28. (Why this suddenly *started* failing is a mystery for another time. Perhaps GitHub, or Microsoft, changed somet

Re: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v4]

2021-07-05 Thread Jorn Vernee
> From the JBS issue: > > At the end, idea.sh tries to invoke javac, but when running on WSL this > results in the following error: > > bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such > file or directory > > Adding a .exe suffix to the javac path fixes this issue, whi

Re: RFR: 8269761: idea.sh missing .exe suffix when invoking javac on WSL [v4]

2021-07-05 Thread Maurizio Cimadamore
On Mon, 5 Jul 2021 18:05:19 GMT, Jorn Vernee wrote: >> From the JBS issue: >> >> At the end, idea.sh tries to invoke javac, but when running on WSL this >> results in the following error: >> >> bin/idea.sh: line 249: /mnt/c/progra~1/java/jdk-16/bin/javac: No such >> file or directory >>

Re: RFR: 8268860: Windows-Aarch64 build is failing in GitHub actions

2021-07-05 Thread David Holmes
On Mon, 5 Jul 2021 13:10:36 GMT, Magnus Ihse Bursie wrote: > GHA for Windows/aarch64 was disabled in > [JDK-8268861](https://bugs.openjdk.java.net/browse/JDK-8268861). The problem > with GHA for windows/aarch64 was due to using Visual Studio 14.28. (Why this > suddenly *started* failing is a m

Re: RFR: 8268860: Windows-Aarch64 build is failing in GitHub actions

2021-07-05 Thread Magnus Ihse Bursie
On Mon, 5 Jul 2021 13:10:36 GMT, Magnus Ihse Bursie wrote: > GHA for Windows/aarch64 was disabled in > [JDK-8268861](https://bugs.openjdk.java.net/browse/JDK-8268861). The problem > with GHA for windows/aarch64 was due to using Visual Studio 14.28. (Why this > suddenly *started* failing is a m

Re: RFR: 8268860: Windows-Aarch64 build is failing in GitHub actions

2021-07-05 Thread David Holmes
On Mon, 5 Jul 2021 13:10:36 GMT, Magnus Ihse Bursie wrote: > GHA for Windows/aarch64 was disabled in > [JDK-8268861](https://bugs.openjdk.java.net/browse/JDK-8268861). The problem > with GHA for windows/aarch64 was due to using Visual Studio 14.28. (Why this > suddenly *started* failing is a m

Integrated: 8268860: Windows-Aarch64 build is failing in GitHub actions

2021-07-05 Thread Magnus Ihse Bursie
On Mon, 5 Jul 2021 13:10:36 GMT, Magnus Ihse Bursie wrote: > GHA for Windows/aarch64 was disabled in > [JDK-8268861](https://bugs.openjdk.java.net/browse/JDK-8268861). The problem > with GHA for windows/aarch64 was due to using Visual Studio 14.28. (Why this > suddenly *started* failing is a m

Re: RFR: 8268860: Windows-Aarch64 build is failing in GitHub actions

2021-07-05 Thread Magnus Ihse Bursie
On Mon, 5 Jul 2021 13:10:36 GMT, Magnus Ihse Bursie wrote: > GHA for Windows/aarch64 was disabled in > [JDK-8268861](https://bugs.openjdk.java.net/browse/JDK-8268861). The problem > with GHA for windows/aarch64 was due to using Visual Studio 14.28. (Why this > suddenly *started* failing is a m

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v3]

2021-07-05 Thread Denghui Dong
> Hi, > > Could I have a review of this improvement that eliminates 'is_large' check if > the event size range is certain? > > JDK-8246260 introduced event large checks to reduce the recording size. > This check could be eliminated at compile/build time when one of the > following conditions is

Re: RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v4]

2021-07-05 Thread Denghui Dong
> Hi, > > Could I have a review of this improvement that eliminates 'is_large' check if > the event size range is certain? > > JDK-8246260 introduced event large checks to reduce the recording size. > This check could be eliminated at compile/build time when one of the > following conditions is