Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Alan Bateman
On 04/11/2021 21:16, Andrew Leonard wrote: This PR enables reproducible Jars, Jmods and openjdk image zip files (eg.src.zip). It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying ZipOutputStream's. It fixes the following keys issues relating to reproducibility: - Jar and ZipOu

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v18]

2021-11-05 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull request

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Lance Andersen
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote: > This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to reproducib

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v19]

2021-11-05 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull request

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Andrew Leonard
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote: > This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to reproducib

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v20]

2021-11-05 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull request

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Magnus Ihse Bursie
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote: > This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to reproducib

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Magnus Ihse Bursie
On Fri, 5 Nov 2021 11:31:34 GMT, Andrew Leonard wrote: >> This PR enables reproducible Jars, Jmods and openjdk image zip files >> (eg.src.zip). >> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying >> ZipOutputStream's. >> It fixes the following keys issues relating to repro

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Magnus Ihse Bursie
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote: > This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to reproducib

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v12]

2021-11-05 Thread Maurizio Cimadamore
On Tue, 2 Nov 2021 15:40:45 GMT, Paul Sandoz wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Tweak javadoc of loaderLookup > > Marked as reviewed by psandoz (Reviewer). I have made some minor API changes (a

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Andrew Leonard
On Fri, 5 Nov 2021 11:16:45 GMT, Lance Andersen wrote: >> This PR enables reproducible Jars, Jmods and openjdk image zip files >> (eg.src.zip). >> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying >> ZipOutputStream's. >> It fixes the following keys issues relating to repro

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Alan Bateman
On 05/11/2021 11:39, Magnus Ihse Bursie wrote: : I agree with Alan's comment above. First of all, to be absolutely clear, I think this is a very worthy goal, and much overdue. I'll do my best to help get this implemented. One suggestion is to separate out the issue of ordering of entries (in

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Andrew Leonard
On Fri, 5 Nov 2021 11:31:34 GMT, Andrew Leonard wrote: >> This PR enables reproducible Jars, Jmods and openjdk image zip files >> (eg.src.zip). >> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying >> ZipOutputStream's. >> It fixes the following keys issues relating to repro

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Andrew Leonard
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote: > This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to reproducib

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Andrew Leonard
On Fri, 5 Nov 2021 11:19:16 GMT, Lance Andersen wrote: >> This PR enables reproducible Jars, Jmods and openjdk image zip files >> (eg.src.zip). >> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying >> ZipOutputStream's. >> It fixes the following keys issues relating to repro

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Magnus Ihse Bursie
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote: > This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to reproducib

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Andrew Leonard
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote: > This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to reproducib

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v18]

2021-11-05 Thread Jorn Vernee
On Fri, 5 Nov 2021 11:06:53 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-419 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjdk

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v18]

2021-11-05 Thread Maurizio Cimadamore
On Fri, 5 Nov 2021 14:25:35 GMT, Jorn Vernee wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> * Add two new CLinker static methods to compute upcall/downcall method >> types >> * Clarify section on CLinker

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v21]

2021-11-05 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull request

RFR: 8276654: element-list order is non deterministic

2021-11-05 Thread Andrew Leonard
Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 A intermittent problem with the make dependencies means the jdk.javadoc element-list-.txt generation can remove the src defined element|package-list-<7,8,9,10>.txt files. Recreatable by using --with-jobs=1 causing jdk.javadoc "gendata" to a

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v18]

2021-11-05 Thread Jorn Vernee
On Fri, 5 Nov 2021 14:33:44 GMT, Maurizio Cimadamore wrote: >> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java >> line 134: >> >>> 132: * >>> 133: * Upcall stubs are generally safer to work with, as the linker >>> runtime can validate the type of the target metho

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v22]

2021-11-05 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull request

Re: RFR: 8276654: element-list order is non deterministic

2021-11-05 Thread Erik Joelsson
On Fri, 5 Nov 2021 15:26:40 GMT, Andrew Leonard wrote: > Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 > > A intermittent problem with the make dependencies means the jdk.javadoc > element-list-.txt generation can remove the src defined > element|package-list-<7,8,9,10>.txt files. >

RFR: 8276746: Add section on reproducible builds in building.md

2021-11-05 Thread Magnus Ihse Bursie
Reproducible builds are all the vogue. The JDK has been making great strides in getting there, but still has some way to go. However, to get as close as possible, some special configuration is needed. This has been "tribal knowledge" of a few persons in the build team. It needs to be properly

Re: RFR: 8276672: Cannot build hsdis on WSL

2021-11-05 Thread Magnus Ihse Bursie
On Fri, 5 Nov 2021 03:03:55 GMT, Yasumasa Suenaga wrote: > JDK-8275128 introduced new Makefile for hsdis to integrate it to normal build > system, however it does not work on WSL 1 Ubuntu 20.04 and MinGW from Ubuntu. > > Hsdis.gmk has two problems: > > 1. MinGW version is fixed to "9.2.0" > 2.

Re: Does CDS archive generation work for crossbuilds?

2021-11-05 Thread Magnus Ihse Bursie
On 2021-10-29 21:35, Anton Kozlov wrote: QEMU user space emulation [1] works pretty fast. On my linux-x86 laptop native java -Xshare:dump completes in 0.4 sec, and with qemu-aarch64 it's about 2.3 sec. GHA now provides a runnable instruction on how to create the sysroot [2]. But that time excl

Re: RFR: 8276654: element-list order is non deterministic

2021-11-05 Thread Magnus Ihse Bursie
On Fri, 5 Nov 2021 16:15:02 GMT, Erik Joelsson wrote: >> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 >> >> A intermittent problem with the make dependencies means the jdk.javadoc >> element-list-.txt generation can remove the src defined >> element|package-list-<7,8,9,10>.txt files

Re: RFR: 8276746: Add section on reproducible builds in building.md

2021-11-05 Thread Erik Joelsson
On Fri, 5 Nov 2021 16:30:26 GMT, Magnus Ihse Bursie wrote: > Reproducible builds are all the vogue. The JDK has been making great strides > in getting there, but still has some way to go. However, to get as close as > possible, some special configuration is needed. > > This has been "tribal k

Re: RFR: 8276654: element-list order is non deterministic

2021-11-05 Thread Andrew Leonard
On Fri, 5 Nov 2021 16:15:02 GMT, Erik Joelsson wrote: >> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 >> >> A intermittent problem with the make dependencies means the jdk.javadoc >> element-list-.txt generation can remove the src defined >> element|package-list-<7,8,9,10>.txt files

Re: RFR: 8276746: Add section on reproducible builds in building.md

2021-11-05 Thread Magnus Ihse Bursie
On Fri, 5 Nov 2021 16:45:34 GMT, Erik Joelsson wrote: >> Reproducible builds are all the vogue. The JDK has been making great strides >> in getting there, but still has some way to go. However, to get as close as >> possible, some special configuration is needed. >> >> This has been "tribal k

Re: RFR: 8276746: Add section on reproducible builds in building.md

2021-11-05 Thread Severin Gehwolf
On Fri, 5 Nov 2021 16:30:26 GMT, Magnus Ihse Bursie wrote: > Reproducible builds are all the vogue. The JDK has been making great strides > in getting there, but still has some way to go. However, to get as close as > possible, some special configuration is needed. > > This has been "tribal k

Re: RFR: 8276654: element-list order is non deterministic

2021-11-05 Thread Andrew Leonard
On Fri, 5 Nov 2021 16:15:02 GMT, Erik Joelsson wrote: >> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 >> >> A intermittent problem with the make dependencies means the jdk.javadoc >> element-list-.txt generation can remove the src defined >> element|package-list-<7,8,9,10>.txt files

Re: RFR: 8276654: element-list order is non deterministic [v2]

2021-11-05 Thread Andrew Leonard
> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 > > A intermittent problem with the make dependencies means the jdk.javadoc > element-list-.txt generation can remove the src defined > element|package-list-<7,8,9,10>.txt files. > Recreatable by using --with-jobs=1 causing jdk.javadoc "g

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Andrew Leonard
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote: > This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to reproducib

Withdrawn: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Andrew Leonard
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote: > This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to reproducib

Re: RFR: 8276654: element-list order is non deterministic [v2]

2021-11-05 Thread Erik Joelsson
On Fri, 5 Nov 2021 18:46:26 GMT, Andrew Leonard wrote: >> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 >> >> A intermittent problem with the make dependencies means the jdk.javadoc >> element-list-.txt generation can remove the src defined >> element|package-list-<7,8,9,10>.txt file

Re: RFR: 8276746: Add section on reproducible builds in building.md

2021-11-05 Thread Andrew Leonard
On Fri, 5 Nov 2021 16:30:26 GMT, Magnus Ihse Bursie wrote: > Reproducible builds are all the vogue. The JDK has been making great strides > in getting there, but still has some way to go. However, to get as close as > possible, some special configuration is needed. > > This has been "tribal k

Re: RFR: 8276654: element-list order is non deterministic [v2]

2021-11-05 Thread Andrew Leonard
On Fri, 5 Nov 2021 19:20:10 GMT, Erik Joelsson wrote: >> Andrew Leonard has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. > > make/modules/jdk.javadoc/Gendata.gmk

Re: RFR: 8276654: element-list order is non deterministic [v3]

2021-11-05 Thread Andrew Leonard
> Fixes: https://bugs.openjdk.java.net/browse/JDK-8276654 > > A intermittent problem with the make dependencies means the jdk.javadoc > element-list-.txt generation can remove the src defined > element|package-list-<7,8,9,10>.txt files. > Recreatable by using --with-jobs=1 causing jdk.javadoc "g

Re: RFR: 8276654: element-list order is non deterministic [v2]

2021-11-05 Thread Andrew Leonard
On Fri, 5 Nov 2021 19:26:56 GMT, Andrew Leonard wrote: >> make/modules/jdk.javadoc/Gendata.gmk line 75: >> >>> 73: $(call MakeTargetDir) >>> 74: $(call LogInfo, Creating javadoc element lists) >>> 75: $(RM) $(ELEMENT_LISTS_DIR)/element-list-{$(call >>> CommaList,$(call

Re: RFR: 8276654: element-list order is non deterministic [v2]

2021-11-05 Thread Magnus Ihse Bursie
On Fri, 5 Nov 2021 19:36:34 GMT, Andrew Leonard wrote: >> yep, i'll have a look to see what I can do, not helped with existing >> variables being so long!! (GENERATE_SYMBOLS_FROM_JDK_VERSION) > > yep, split on CommaList seems better and works fine, see revision Does it work if you have space af

Re: RFR: 8276746: Add section on reproducible builds in building.md [v2]

2021-11-05 Thread Magnus Ihse Bursie
> Reproducible builds are all the vogue. The JDK has been making great strides > in getting there, but still has some way to go. However, to get as close as > possible, some special configuration is needed. > > This has been "tribal knowledge" of a few persons in the build team. It needs > to

Integrated: 8276746: Add section on reproducible builds in building.md

2021-11-05 Thread Magnus Ihse Bursie
On Fri, 5 Nov 2021 16:30:26 GMT, Magnus Ihse Bursie wrote: > Reproducible builds are all the vogue. The JDK has been making great strides > in getting there, but still has some way to go. However, to get as close as > possible, some special configuration is needed. > > This has been "tribal k