RFR: 8279834: Alpine Linux fails to build when --with-source-date enabled

2022-01-11 Thread Andrew Leonard
The new reproducible build jar & jmod feature exposed a problem on Alpline linux whereby when --with-source-date is specified the IS_GNU_DATE setting was actually wrong. It was assuming the BusyBox "date" tool on Alpine linux was BSD compatible, but it is actually GNU syntax compatible. This PR

Re: RFR: 8279834: Alpine Linux fails to build when --with-source-date enabled

2022-01-11 Thread Erik Joelsson
On Tue, 11 Jan 2022 10:25:31 GMT, Andrew Leonard wrote: > The new reproducible build jar & jmod feature exposed a problem on Alpline > linux whereby when --with-source-date is specified the IS_GNU_DATE setting > was actually wrong. It was assuming the BusyBox "date" tool on Alpine linux > was

Re: RFR: 8279834: Alpine Linux fails to build when --with-source-date enabled

2022-01-11 Thread Andrew Leonard
On Tue, 11 Jan 2022 13:53:49 GMT, Erik Joelsson wrote: >> The new reproducible build jar & jmod feature exposed a problem on Alpline >> linux whereby when --with-source-date is specified the IS_GNU_DATE setting >> was actually wrong. It was assuming the BusyBox "date" tool on Alpine linux >> w

Integrated: 8279834: Alpine Linux fails to build when --with-source-date enabled

2022-01-11 Thread Andrew Leonard
On Tue, 11 Jan 2022 10:25:31 GMT, Andrew Leonard wrote: > The new reproducible build jar & jmod feature exposed a problem on Alpline > linux whereby when --with-source-date is specified the IS_GNU_DATE setting > was actually wrong. It was assuming the BusyBox "date" tool on Alpine linux > was

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v5]

2022-01-11 Thread Tyler Steele
On Mon, 3 Jan 2022 13:57:59 GMT, Erik Joelsson wrote: >> Tyler Steele has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix issue where network_interface pointer is not updated to newly created >> list > > Build changes look ok. You will

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v7]

2022-01-11 Thread Tyler Steele
> Just in time for the holidays I have completed an implementation of the JFR > functionality for AIX. As a side note, this is my first submission to OpenJDK > 👋 > > ### Implementation notes and alternatives considered > > After modifying the build system to allow the --enable-jvm-feature-jfr t

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v5]

2022-01-11 Thread Erik Joelsson
On Mon, 3 Jan 2022 13:57:59 GMT, Erik Joelsson wrote: >> Tyler Steele has refreshed the contents of this pull request, and previous >> commits have been removed. Incremental views are not available. > > Build changes look ok. You will also need ok from someone in the component > team. > @erikj

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v7]

2022-01-11 Thread Tyler Steele
On Tue, 11 Jan 2022 16:53:05 GMT, Tyler Steele wrote: >> Just in time for the holidays I have completed an implementation of the JFR >> functionality for AIX. As a side note, this is my first submission to >> OpenJDK 👋 >> >> ### Implementation notes and alternatives considered >> >> After mod

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v5]

2022-01-11 Thread Tyler Steele
On Tue, 11 Jan 2022 17:10:13 GMT, Erik Joelsson wrote: > I can't really comment on any AIX specific compiler flags as I'm not familiar > with AIX and not representing a company that supports it. All I can say is > that the build changes look sane from a structural point of view. I don't > know

Re: RFR: 8253757: Add LLVM-based backend for hsdis

2022-01-11 Thread Saint Wesonga
On Wed, 17 Nov 2021 13:17:21 GMT, Magnus Ihse Bursie wrote: >> This patch expands the newly added system for hsdis backends to include LLVM. >> >> The actual code in hsdis-llvm.cpp is based heavily on the work by @luhenry, >> as published in the never integrated PR >> https://github.com/openjd

RFR: 8279884: Use better file for cygwin source permission check

2022-01-11 Thread Mikael Vidstedt
For sanity, configure tries to verify that source files have the right permissions by checking the LICENSE file in TOPDIR. That file may not always be available, and for builds where it isn't configure will generate a (harmless) error along the lines of: - Commit messages: - 82798

Re: RFR: 8279884: Use better file for cygwin source permission check

2022-01-11 Thread Erik Joelsson
On Tue, 11 Jan 2022 21:07:17 GMT, Mikael Vidstedt wrote: > For sanity, configure tries to verify that source files have the right > permissions by checking the LICENSE file in TOPDIR. That file may not always > be available, and for builds where it isn't configure will generate a > (harmless)

Integrated: 8279884: Use better file for cygwin source permission check

2022-01-11 Thread Mikael Vidstedt
On Tue, 11 Jan 2022 21:07:17 GMT, Mikael Vidstedt wrote: > For sanity, configure tries to verify that source files have the right > permissions by checking the LICENSE file in TOPDIR. That file may not always > be available, and for builds where it isn't configure will generate a > (harmless)

RFR: 8279877: Document IDEA IDE setup in docs/ide.md

2022-01-11 Thread Daniel Jelinski
Currently the information about using IDEA can only be found on mailing lists. Additionally fixed the documentation for Visual Studio; the target `ide-project` does not exist. - Commit messages: - Update IDEA and VS documentation Changes: https://git.openjdk.java.net/jdk/pull/7044