On Tue, 25 Jan 2022 15:06:41 GMT, Christian Hagedorn
wrote:
> Build changes look good.
Thanks Erik!
> Personally, I am in favor of this project. Actually, I were experimenting it
> with libdwarf.
>
> I would like to add some historical background on this topic, just for
> consideration.
T
Ever since [JDK-8257679](https://bugs.openjdk.java.net/browse/JDK-8257679) was
merged in 16, MSys 2 became capable of building a functional JDK on Windows.
This PR updates some outdated documentation in building.html and building.md to
reflect that change.
I appreciate any reviews, and would li
On Wed, 26 Jan 2022 08:26:27 GMT, Aleksey Shipilev wrote:
>> Thomas Stuefe has updated the pull request incrementally with 15 additional
>> commits since the last revision:
>>
>> - 8280377: MethodHandleProxies does not correctly invoke default methods
>> with varags
>>
>>Reviewed-by:
On Tue, 25 Jan 2022 10:57:14 GMT, Thomas Stuefe wrote:
> After discussing this on hotspot-runtime-dev [1], the general opinion seems
> to be that it would be worthwhile to get rid of INCLUDE_NMT and make NMT
> unconditional. This affects minimal builds only. As pointed out in the mail
> thread
On Tue, 25 Jan 2022 15:10:11 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x000
On Thu, 27 Jan 2022 00:17:17 GMT, Tyler Steele wrote:
>> src/hotspot/os/aix/os_perf_aix.cpp line 33:
>>
>>> 31: #include "runtime/os_perf.hpp"
>>> 32: #include "runtime/vm_version.hpp"
>>> 33: #include "utilities/globalDefinitions.hpp"
>>
>> include debug.hpp too (you use assert)
>
> Thanks! I
On Mon, 24 Jan 2022 22:23:33 GMT, Tyler Steele wrote:
>> Just in time for the holidays I have completed an implementation of the JFR
>> functionality for AIX. As a side note, this is my first submission to
>> OpenJDK 👋
>>
>> ### Implementation notes and alternatives considered
>>
>> After mod
On Thu, 27 Jan 2022 08:38:02 GMT, Christian Hagedorn
wrote:
> > Build changes look good.
>
> Thanks Erik!
>
> > Personally, I am in favor of this project. Actually, I were experimenting
> > it with libdwarf.
> > I would like to add some historical background on this topic, just for
> > consi
On Thu, 27 Jan 2022 08:49:08 GMT, TheShermanTanker
wrote:
> Ever since [JDK-8257679](https://bugs.openjdk.java.net/browse/JDK-8257679)
> was merged in 16, MSys 2 became capable of building a functional JDK on
> Windows. This PR updates some outdated documentation in building.html and
> buildi
On Thu, 27 Jan 2022 08:49:08 GMT, TheShermanTanker
wrote:
> Ever since [JDK-8257679](https://bugs.openjdk.java.net/browse/JDK-8257679)
> was merged in 16, MSys 2 became capable of building a functional JDK on
> Windows. This PR updates some outdated documentation in building.html and
> buildi
On Mon, 24 Jan 2022 22:23:33 GMT, Tyler Steele wrote:
>> Just in time for the holidays I have completed an implementation of the JFR
>> functionality for AIX. As a side note, this is my first submission to
>> OpenJDK 👋
>>
>> ### Implementation notes and alternatives considered
>>
>> After mod
On Tue, 25 Jan 2022 09:06:49 GMT, Thomas Stuefe wrote:
>> Tyler Steele has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains two commits:
>>
>> - Merge branch 'master' into JDK-8203290
>> - Implements JFR on AIX
>>
>>- Impleme
On Thu, 27 Jan 2022 00:15:52 GMT, Tyler Steele wrote:
>> src/hotspot/os/aix/loadlib_aix.hpp line 79:
>>
>>> 77: private:
>>> 78: const loaded_module_t _module;
>>> 79: const LoadedModuleList* _next;
>>
>> While looking at this code, I realized how old it is (the copyright is
>> wrong
On Tue, 25 Jan 2022 15:10:11 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x000
On 27/01/2022 9:01 pm, Goetz Lindenmaier wrote:
On Mon, 24 Jan 2022 22:23:33 GMT, Tyler Steele wrote:
Just in time for the holidays I have completed an implementation of the JFR
functionality for AIX. As a side note, this is my first submission to OpenJDK 👋
### Implementation notes and alter
On Thu, 27 Jan 2022 19:28:01 GMT, Tyler Steele wrote:
>
> This is a good suggestion. I thought about doing it before, but I am used to
> tamping down my functional programming instincts when writing C.
You are right, it's generally good to do things the way they are done. When in
Rome. But in
16 matches
Mail list logo
