Re: RFR: 8282322: AArch64: Provide a means to eliminate all STREX family of instructions

2022-05-19 Thread Andrew Haley
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote: > On AArch64 it is sometimes convenient to have LSE atomics right from the > start. Currently they are enabled after feature detection and RR reverse > debugger works incorrectly. > > New build configuration feature 'hardlse' is added. If

Re: RFR: 8282322: AArch64: Provide a means to eliminate all STREX family of instructions

2022-05-19 Thread Andrew Haley
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote: > On AArch64 it is sometimes convenient to have LSE atomics right from the > start. Currently they are enabled after feature detection and RR reverse > debugger works incorrectly. > > New build configuration feature 'hardlse' is added. If

Re: RFR: 8282322: AArch64: Provide a means to eliminate all STREX family of instructions

2022-05-19 Thread Andrew Haley
On Thu, 19 May 2022 07:59:56 GMT, Andrew Haley wrote: > This looks reasonable enough, but I take it that this would create an OpenJDK > build that would not run on AArch64 systems without LSE instructions. Forget that, we already do so with extra-cflags. - PR: https://git.openjdk.

Re: RFR: 8282322: AArch64: Provide a means to eliminate all STREX family of instructions

2022-05-19 Thread Nick Gasson
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote: > On AArch64 it is sometimes convenient to have LSE atomics right from the > start. Currently they are enabled after feature detection and RR reverse > debugger works incorrectly. > > New build configuration feature 'hardlse' is added. If

Re: RFR: 8282322: AArch64: Provide a means to eliminate all STREX family of instructions

2022-05-19 Thread Andrew Haley
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote: > On AArch64 it is sometimes convenient to have LSE atomics right from the > start. Currently they are enabled after feature detection and RR reverse > debugger works incorrectly. > > New build configuration feature 'hardlse' is added. If

Re: RFR: 8282322: AArch64: Provide a means to eliminate all STREX family of instructions

2022-05-19 Thread Andrew Haley
On Thu, 19 May 2022 08:43:55 GMT, Nick Gasson wrote: > What's the advantage of defining the new hardlse VM feature over using the > existing `__ARM_FEATURE_ATOMICS` preprocessor symbol? Both GCC and Clang will > define that with an appropriate `-march` value, which you're passing to > configur

Re: RFR: 8282322: AArch64: Provide a means to eliminate all STREX family of instructions

2022-05-19 Thread Dmitry Chuyko
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote: > On AArch64 it is sometimes convenient to have LSE atomics right from the > start. Currently they are enabled after feature detection and RR reverse > debugger works incorrectly. > > New build configuration feature 'hardlse' is added. If

Re: RFR: 8282322: AArch64: Provide a means to eliminate all STREX family of instructions

2022-05-19 Thread Andrew Haley
On Thu, 19 May 2022 10:05:41 GMT, Dmitry Chuyko wrote: > Some concerns: > > 1. It should work at least for Clang and GCC but still will require > checking all os-cpu/compiler variants. Really, no. Don't think that way. Just do Linux for now, and throw it over the wall for Windows people.

Re: RFR: 8282322: AArch64: Provide a means to eliminate all STREX family of instructions

2022-05-19 Thread Andrew Haley
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote: > On AArch64 it is sometimes convenient to have LSE atomics right from the > start. Currently they are enabled after feature detection and RR reverse > debugger works incorrectly. > > New build configuration feature 'hardlse' is added. If

Re: RFR: 8282322: AArch64: Provide a means to eliminate all STREX family of instructions

2022-05-19 Thread Andrew Haley
On Wed, 18 May 2022 19:05:03 GMT, Dmitry Chuyko wrote: > On AArch64 it is sometimes convenient to have LSE atomics right from the > start. Currently they are enabled after feature detection and RR reverse > debugger works incorrectly. > > New build configuration feature 'hardlse' is added. If

Re: RFR: 8282322: AArch64: Provide a means to eliminate all STREX family of instructions

2022-05-19 Thread Andrew Haley
On Thu, 19 May 2022 14:36:28 GMT, Andrew Haley wrote: > > Some concerns: > > ``` > > 1. It should work at least for Clang and GCC but still will require > > checking all os-cpu/compiler variants. Non-Linux systems don't use this stuff at all, so don't worry about it. - PR: https:/

Re: RFR: 8286262: Windows: Cleanup deprecation warning suppression

2022-05-19 Thread Kim Barrett
On Tue, 17 May 2022 06:30:03 GMT, David Holmes wrote: > Sorry Kim I'm having trouble seeing what change corresponds to (1) ?? The change to CompileJvm.gmk, removing 4996 (deprecation warnings) from the list of disabled warnings. > Also the PR talks only about hotspot, but you're changing the JD