Re: RFR: 8167600 jib make run-test for langtools and intermittent failures on windows-x86
Magnus:
Thank you for the feedback. See below:
On 2016-10-15 03:23, Tim Bell wrote:
Please review this rework of the langtools/test/Makefile fix done in
8166648. [1] ARCH_DATA_MODEL is not set in all test scenarios, so a
better approach is to check the VM about to be tested.
Bug report:
https://bugs.openjdk.java.net/browse/JDK-8167600
Webrev:
http://cr.openjdk.java.net/~tbell/8167600/webrev.00/
Testing:
Successful JPRT runs on all platforms. Inspected the
_.product-c2-langtools_jtreg.log files to verify the
expected flag was used only on 32-bit VMs.
Hi Tim,
Seems a bit complicated to create a temporary javascript and execute it.
Why not try something like:
DATA_MODEL=`${JT_JAVA}/bin/java -XshowSettings:properties -version 2>&1
| grep sun.arch.data.model | awk '{print $3}'`
?
Excellent idea. This is much simpler.
Here is an updated webrev. Tested as before, by submitting a JPRT job
and inspecting the .log files.
http://cr.openjdk.java.net/~tbell/8167600/webrev.01/
Tim
Thanks in advance-
Tim
[1] JDK-8166648 https://bugs.openjdk.java.net/browse/JDK-8166648
RFR: 8145471: javac changes for enhanced deprecation
Repeat, with subject line.
-- Jon
On 10/17/2016 03:03 PM, Jonathan Gibbons wrote:
Compiler folk, build folk,
Please review this update for javac and some build files, for JEP 277.
The work supports the enhanced Deprecation attribute, and generates a
new warning when items are referenced that are declared with
@Deprecated(forRemoval=true), in line with the proposals in JEP 277.
The warnings are on by default, and can be suppressed with
-Xlint:-removal or @SuppressWarnings("removal"). Because the warnings
are on by default, and because the warnings currently show up when
building JDK, some minor build changes are temporarily required to
suppress the warnings that get generated during the build.
-- Jon
JEP: http://openjdk.java.net/jeps/277
JBS: https://bugs.openjdk.java.net/browse/JDK-8145471
Webrev: http://cr.openjdk.java.net/~jjg/8145471/webrev.01/
RFR:
Compiler folk, build folk,
Please review this update for javac and some build files, for JEP 277.
The work supports the enhanced Deprecation attribute, and generates a
new warning when items are referenced that are declared with
@Deprecated(forRemoval=true), in line with the proposals in JEP 277.
The warnings are on by default, and can be suppressed with
-Xlint:-removal or @SuppressWarnings("removal"). Because the warnings
are on by default, and because the warnings currently show up when
building JDK, some minor build changes are temporarily required to
suppress the warnings that get generated during the build.
-- Jon
JEP: http://openjdk.java.net/jeps/277
JBS: https://bugs.openjdk.java.net/browse/JDK-8145471
Webrev: http://cr.openjdk.java.net/~jjg/8145471/webrev.01/
Re: RFR: 8167600 jib make run-test for langtools and intermittent failures on windows-x86
On 2016-10-15 03:23, Tim Bell wrote:
Please review this rework of the langtools/test/Makefile fix done in
8166648. [1] ARCH_DATA_MODEL is not set in all test scenarios, so a
better approach is to check the VM about to be tested.
Bug report:
https://bugs.openjdk.java.net/browse/JDK-8167600
Webrev:
http://cr.openjdk.java.net/~tbell/8167600/webrev.00/
Testing:
Successful JPRT runs on all platforms. Inspected the
_.product-c2-langtools_jtreg.log files to verify the
expected flag was used only on 32-bit VMs.
Hi Tim,
Seems a bit complicated to create a temporary javascript and execute it.
Why not try something like:
DATA_MODEL=`${JT_JAVA}/bin/java -XshowSettings:properties -version 2>&1
| grep sun.arch.data.model | awk '{print $3}'`
?
Thanks in advance-
Tim
[1] JDK-8166648 https://bugs.openjdk.java.net/browse/JDK-8166648
Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory
On 2016-10-14 17:51, Pete Brunet wrote: Please review the following. The .h files and .c file provided to allow Assistive Technology to interface to the Java Access Bridge API are being removed from the built JRE/JDK images. They are not used much and they can be obtained online via the OpenJDK web site. The pubs will be updated to mention the location of the files. Since there is a .c file in this group of files the directory structure has been changed slightly to remove the include directory. There was one file missing from the group of files needed by developers and that was moved from the common to the bridge directory. The make was updated in response to the above. Bug: https://bugs.openjdk.java.net/browse/JDK-8167213 Webrev: http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.00/ Build changes looks good to me. /Magnus
