Thanks for the quick fix Magnus!
* Derek White
On 2018-03-06 17:06, Erik Joelsson wrote:
In TestFilesCompilation.gmk we still add $(CFLAGS_WARNINGS_ARE_ERRORS)
explicitly to CFLAGS. This is both redundant and wrong since we are
now handling these flags automatically in the macro
SetupNativeCompilation. The consequence is that
On 2018-03-06 15:59, Erik Joelsson wrote:
Looks good.
When looking at this patch, I realized that topdir has a different
meaning depending on if you are in the HAS_SPEC conditional or not. In
the first section, topdir is always the open root dir, but in the else
section it is set to
In TestFilesCompilation.gmk we still add $(CFLAGS_WARNINGS_ARE_ERRORS)
explicitly to CFLAGS. This is both redundant and wrong since we are now
handling these flags automatically in the macro SetupNativeCompilation.
The consequence is that --disable-warnings-as-errors won't work for
jtreg
Looks good.
When looking at this patch, I realized that topdir has a different
meaning depending on if you are in the HAS_SPEC conditional or not. In
the first section, topdir is always the open root dir, but in the else
section it is set to CUSTOM_ROOT if available. This is rather confusing.
Looks good.
When looking at this patch, I realized that topdir has a different
meaning depending on if you are in the HAS_SPEC conditional or not. In
the first section, topdir is always the open root dir, but in the else
section it is set to CUSTOM_ROOT if available. This is rather confusing.
Looks good.
/Erik
On 2018-03-06 05:37, Magnus Ihse Bursie wrote:
The code in NativeCompilation.gmk that was supposed to filter out CL's
printing of the file being compiled has stopped working on modern
Cygwin, since Cygwin grep is broken and cannot handle Windows line
endings. We've seen
This fix will enable patch files for COMPARE_BUILD to be hosted in a
custom root.
Bug: https://bugs.openjdk.java.net/browse/JDK-8199103
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8199103-use-PATCH-in-COMPARE_BUILD-custom-root/webrev.01
/Magnus
