Re: RFR(M) 8152988: [AOT] Update test batch definitions to include aot-ed java.base module mode into hs-comp testing

yes, it is at the same location: http://cr.openjdk.java.net/~epavlova//8152988/webrev.01/ -katya On 11/1/18 3:15 PM, Magnus Ihse Bursie wrote: Do you have an updated webrev? /Magnus 1 nov. 2018 kl. 22:28 skrev Ekaterina Pavlova : Magnus, thanks for the review. I fixed everything you

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

Looks good. /Erik On 2018-11-01 16:37, Igor Ignatyev wrote: on a second though, removing these macros isn't that big, here is an incremental webrev: http://cr.openjdk.java.net/~iignatyev//8213058/webrev.0-1 . besides

Re: Stop using precompiled headers for Linux?

On 2/11/2018 9:53 AM, Ioi Lam wrote: Maybe precompiled.hpp can be periodically (weekly?) updated by a robot, which parses the dependencies files generated by gcc, and pick the most popular N files? Do we need to use precompiled.hpp at all? Can we not use the list of files contained in

Re: Stop using precompiled headers for Linux?

Maybe precompiled.hpp can be periodically (weekly?) updated by a robot, which parses the dependencies files generated by gcc, and pick the most popular N files? - Ioi On 11/1/18 4:38 PM, David Holmes wrote: It's not at all obvious to me that the way we use PCH is the right/best way to use

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

On 2/11/2018 9:37 AM, Igor Ignatyev wrote: on a second though, removing these macros isn't that big, here is an incremental webrev: http://cr.openjdk.java.net/~iignatyev//8213058/webrev.0-1 :) Thanks. Looks good! David

Re: Stop using precompiled headers for Linux?

It's not at all obvious to me that the way we use PCH is the right/best way to use it. We dump every header we think it would be good to precompile into precompiled.hpp and then only ask gcc to precompile it. That results in a ~250MB file that has to be read into and processed for every source

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

on a second though, removing these macros isn't that big, here is an incremental webrev: http://cr.openjdk.java.net/~iignatyev//8213058/webrev.0-1 . besides removing test_log, it also include fixes in build and doc needed due

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

Hi David, removing usage of test_log will just mix "unneeded" changes w/ this clean up. as TestReservedSpace_test, TestReserveMemorySpecial_test, TestVirtualSpace_test, and TestMetaspaceUtils_test are to be removed by 8213269[*], I don't think we need to pay much attention to their code. [*]

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

Hi Igor, There's no point having empty test_log macros that do nothing. The macro and all uses should just be deleted ... unless you plan on adding some other form of logging for this? Thanks, David On 2/11/2018 7:15 AM, Igor Ignatyev wrote:

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

Build changes look good. /Erik On 2018-11-01 14:15, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8213058/webrev.00/index.html 174 lines changed: 0 ins; 170 del; 4 mod; Hi all, could you please review this small clean up which removes ExecuteInternalVMTests and

Re: RFR(M) 8152988: [AOT] Update test batch definitions to include aot-ed java.base module mode into hs-comp testing

Do you have an updated webrev? /Magnus > 1 nov. 2018 kl. 22:28 skrev Ekaterina Pavlova : > > Magnus, > > thanks for the review. > I fixed everything you pointed to. > > thanks, > -katya > >> On 11/1/18 6:46 AM, Magnus Ihse Bursie wrote: >> Hi Katya, >> Sorry for the late response. :-( >>> On

Re: RFR(M) 8152988: [AOT] Update test batch definitions to include aot-ed java.base module mode into hs-comp testing

Magnus, thanks for the review. I fixed everything you pointed to. thanks, -katya On 11/1/18 6:46 AM, Magnus Ihse Bursie wrote: Hi Katya, Sorry for the late response. :-( On 2018-10-29 21:24, Ekaterina Pavlova wrote: Vladimir, I added "-XX:+UseAOTStrictLoading" to "java -version", see

RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

http://cr.openjdk.java.net/~iignatyev//8213058/webrev.00/index.html > 174 lines changed: 0 ins; 170 del; 4 mod; Hi all, could you please review this small clean up which removes ExecuteInternalVMTests and VerboseInternalVMTests flags and related make targets and tests? 8177708[1-3] is to

Re: Stop using precompiled headers for Linux?

> 1 nov. 2018 kl. 17:49 skrev Erik Joelsson : > >> On 2018-11-01 08:17, Magnus Ihse Bursie wrote: >>> On 2018-11-01 15:53, Ioi Lam wrote: >>> Just a stupid question. Does GCC have actual support for PCH? I know >>> windows can load pre-compiled information from a special binary file. Does >>>

Re: Stop using precompiled headers for Linux?

Hello, My point here, which wasn't very clear, is that Mac and Linux seem to lose just as much real compile time. The big difference in these tests was rather the number of cpus in the machine (32 threads in the linux box vs 8 on the mac). The total amount of work done was increased when PCH

Re: Stop using precompiled headers for Linux?

On 2018-11-01 08:17, Magnus Ihse Bursie wrote: On 2018-11-01 15:53, Ioi Lam wrote: Just a stupid question. Does GCC have actual support for PCH? I know windows can load pre-compiled information from a special binary file. Does GCC support that kind of functionality? Yes.

Re: RFR: JDK-8213237 Remove test-compile-commands from jib-profiles.js

Looks good. /Erik On 2018-11-01 03:06, Magnus Ihse Bursie wrote: In JDK-8210958, a broken version of jib-profiles.js was unfortunately checked in. The change at http://cr.openjdk.java.net/~ihse/JDK-8210958-rename-run-test-to-test/webrev.02/make/conf/jib-profiles.js.udiff.html, as

Re: Stop using precompiled headers for Linux?

On 2018-11-01 15:53, Ioi Lam wrote: Just a stupid question. Does GCC have actual support for PCH? I know windows can load pre-compiled information from a special binary file. Does GCC support that kind of functionality? Yes. https://gcc.gnu.org/onlinedocs/gcc/Precompiled-Headers.html

Re: Stop using precompiled headers for Linux?

Just a stupid question. Does GCC have actual support for PCH? I know windows can load pre-compiled information from a special binary file. Does GCC support that kind of functionality? Thanks Ioi > On Nov 1, 2018, at 5:09 AM, Magnus Ihse Bursie > wrote: > > > >> On 2018-11-01 12:51, Thomas

Re: RFR(M) 8152988: [AOT] Update test batch definitions to include aot-ed java.base module mode into hs-comp testing

Hi Katya, Sorry for the late response. :-( On 2018-10-29 21:24, Ekaterina Pavlova wrote: Vladimir, I added "-XX:+UseAOTStrictLoading" to "java -version", see make/RunTests.gmk. Also added "--compile-with-assertion" to jaotc flags in case "-ea" flag was present in vm options (otherwise AOTed

Re: RFR: JDK-8213227: Update jib src excludes to filter webrev and Jreg directories

On 2018-11-01 01:22, Erik Joelsson wrote: This patch adds some useful excludes for jib source bundle creation, which will help avoid sending in too much junk in Mach 5 jobs. The strings are rewritten as arrays, which are now supported, as well as using ** globs to match arbitrary directory

Re: Stop using precompiled headers for Linux?

I vote for disabling precompiled headers by default - they simply make the build less reliable. It seemed like precompiled headers did not work when using different optimization levels for different source files, which in turn was needed for building with clang, so I've been disabling precompiled

Re: Stop using precompiled headers for Linux?

On 2018-11-01 12:51, Thomas Stüfe wrote: On Thu, Nov 1, 2018 at 12:05 PM Magnus Ihse Bursie wrote: On 2018-11-01 11:54, Aleksey Shipilev wrote: On 11/01/2018 11:43 AM, Magnus Ihse Bursie wrote: But then again, it might just signal that the list of headers included in the PCH is no longer

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

On 2018-10-24 19:18, Erik Joelsson wrote: Hello, Nice to see this finally happening! Are we actually adding a new demo? I thought we were working towards getting rid of the demos completely. CompileJavaModules.gmk: The jdk.packager_CLEAN_FILES could be replaced with a simple

Re: Stop using precompiled headers for Linux?

On Thu, Nov 1, 2018 at 12:05 PM Magnus Ihse Bursie wrote: > > On 2018-11-01 11:54, Aleksey Shipilev wrote: > > On 11/01/2018 11:43 AM, Magnus Ihse Bursie wrote: > >> But then again, it might just signal that the list of headers included in > >> the PCH is no longer > >> optimal. If it used to be

Re: Build niceness

On 11/01/2018 12:41 PM, Magnus Ihse Bursie wrote: > I was about to suggest that you could achieve this by overriding NICE in the > configure command line, > by e.g. configure NICE="/usr/bin/nice -n0" (I presume -n0 is a no-op), but it > turned out that this > did not work! :( I opened

Re: Build niceness

On 2018-10-18 18:08, Erik Joelsson wrote: Hello Aleksey, We very deliberately added the automatic niceness for a better general user experience. This was back when build-infra was new and we started pushing the parallelism of the build to where the UIs of our development systems became

Re: Stop using precompiled headers for Linux?

> On 2018-11-01 11:54, Aleksey Shipilev wrote: >> On 11/01/2018 11:43 AM, Magnus Ihse Bursie wrote: >>> But then again, it might just signal that the list of headers >>> included in the PCH is no longer >>> optimal. If it used to be the case that ~100 header files were so >>> interlinked, that

What to include in the PCH list -- statistics on hotspot header files

Prompted by a discussion on build-dev if the current set of header files included in the PCH are optimal (which it most definitely is not!), I collected some statistics. Here's a list of the current set of header files in hotspot with the number of times it is included, directly or indirectly,

Re: Stop using precompiled headers for Linux?

On 2018-11-01 11:54, Aleksey Shipilev wrote: On 11/01/2018 11:43 AM, Magnus Ihse Bursie wrote: But then again, it might just signal that the list of headers included in the PCH is no longer optimal. If it used to be the case that ~100 header files were so interlinked, that changing any of

Re: Stop using precompiled headers for Linux?

On 11/01/2018 11:43 AM, Magnus Ihse Bursie wrote: > But then again, it might just signal that the list of headers included in the > PCH is no longer > optimal. If it used to be the case that ~100 header files were so > interlinked, that changing any of > them caused recompilation of all files

Re: Stop using precompiled headers for Linux?

On 2018-10-30 21:17, Aleksey Shipilev wrote: On 10/30/2018 06:26 PM, Ioi Lam wrote: Is there any advantage of using precompiled headers on Linux? I have measured it recently on shenandoah repositories, and fastdebug/release build times have not improved with or without PCH. Actually, it gets

Re: Stop using precompiled headers for Linux?

On 2018-10-31 00:54, Erik Joelsson wrote: Below are the corresponding numbers from a Mac, (Mac Pro (Late 2013), 3.7 GHz, Quad-Core Intel Xeon E5, 16 GB). To be clear, the -npch is without precompiled headers. Here we see a slight degradation when disabling on both user time and wall clock

Re: minimal gcc version for jdk/jdk and usage of -Wno-int-in-bool-context flag in HS build

On 2018-10-31 17:17, Baesken, Matthias wrote: Hi Aleksey , I tried with gcc 6.2 not 6.3 maybe this makes a difference . Unfortunately I cannot see your exact gcc/g++ compile calls from the logfile . Do you have "-Wall" set which seems to be necessary to enable the

Re: RFR: JDK-8213237 Remove test-compile-commands from jib-profiles.js

On 2018-11-01 11:26, Lance Andersen wrote: +1 Thanks, Lance! /Magnus On Nov 1, 2018, at 6:06 AM, Magnus Ihse Bursie > wrote: In JDK-8210958, a broken version of jib-profiles.js was unfortunately checked in. The change at

Re: RFR: JDK-8213237 Remove test-compile-commands from jib-profiles.js

+1 > On Nov 1, 2018, at 6:06 AM, Magnus Ihse Bursie > wrote: > > In JDK-8210958, a broken version of jib-profiles.js was unfortunately checked > in. > > The change at > http://cr.openjdk.java.net/~ihse/JDK-8210958-rename-run-test-to-test/webrev.02/make/conf/jib-profiles.js.udiff.html, > as

RFR: JDK-8213237 Remove test-compile-commands from jib-profiles.js

In JDK-8210958, a broken version of jib-profiles.js was unfortunately checked in. The change at http://cr.openjdk.java.net/~ihse/JDK-8210958-rename-run-test-to-test/webrev.02/make/conf/jib-profiles.js.udiff.html, as reviewed, was unfortunately reverted in the process. Without this fix, the