Yes, that would be great if you could sponsor.
Thanks,
-Andrew
-Original Message-
From: Erik Joelsson
Sent: Wednesday, June 19, 2019 3:06 PM
To: Andrew Luo ; build-dev@openjdk.java.net
Subject: Re: [PATCH] Detect WSL2 as WSL
Looks good to me. Do you need a sponsor for this?
/Erik
Looks good to me. Do you need a sponsor for this?
/Erik
On 2019-06-19 14:45, Andrew Luo wrote:
Hi Everyone,
Now that a preview of WSL2 is available for testing
(https://devblogs.microsoft.com/commandline/wsl-2-is-now-available-in-windows-insiders/), I decided
to experiment a little bit and
Hi Everyone,
Now that a preview of WSL2 is available for testing
(https://devblogs.microsoft.com/commandline/wsl-2-is-now-available-in-windows-insiders/),
I decided to experiment a little bit and tried compiling OpenJDK with WSL2.
To correctly detect WSL2, however, I had to make a minor
Looks good! Please push this version instead of mine :-)
- Ioi
On 6/19/19 12:35 PM, Erik Joelsson wrote:
Hello,
I would suggest this change instead. Then the bootcycle bootjdk is
free to use any CDS archive it happens to have (which it usually does
since we create it by default).
Hello,
I would suggest this change instead. Then the bootcycle bootjdk is free
to use any CDS archive it happens to have (which it usually does since
we create it by default).
http://cr.openjdk.java.net/~erikj/8226404/webrev.01/
/Erik
On 2019-06-19 10:41, Ioi Lam wrote:
Hello Dan,
Please at least add a comment above SPEC_FILTER explaining how it can be
used and the format it accepts.
Docs.gmk:492: I would recommend breaking after the =. We generally do
this for (at least) multi-line macro definitions to make them stand out
more. See make/common/Utils.gmk
https://bugs.openjdk.java.net/browse/JDK-8226404
When doing "make bootcycle-images", we would attempt to use the newly built
JDK with a CDS archive generated by the BOOT_JDK. This could cause the build
to fail (the underlying cause is JDK-8226406 "JVM fails to detect mismatched
or corrupt CDS
Are you sure it's 10.11 that is the problem and not the version of Xcode?
/Erik
On 2019-06-19 00:51, Baesken, Matthias wrote:
Hello, I noticed that we fail on OSX 10.11 in the build . Reason is that
NSWindowStyleMaskDocModalWindow is used since :
Looks good.
/Erik
On 2019-06-18 15:44, Alexandre (Shura) Iline wrote:
Hi,
Can you please take a look on a small change to switch to a newer JCov build.
This is the whole change:
$ hg diff
diff -r 17f24c0e2f01 make/conf/jib-profiles.js
--- a/make/conf/jib-profiles.js Tue Jun 18 18:38:53 2019
We could add a check for the existing OS_VERSION_MAJOR variable , this
shows the kernel version but from my understanding the kernel to OSX mapping
is pretty stable
e.g. something like :
diff -r 7cf925f385fe make/autoconf/toolchain.m4
--- a/make/autoconf/toolchain.m4Wed Jun
Hello, I noticed that we fail on OSX 10.11 in the build . Reason is that
NSWindowStyleMaskDocModalWindow is used since :
https://hg.openjdk.java.net/jdk/jdk/rev/6daafebf8189
8208543: [macos] Support for apple.awt.documentModalSheet incomplete
Which is 10.12+ functionality . See
11 matches
Mail list logo
