RE: [8u] RFR: 8210761: libjsig is being compiled without optimization
Hi Severin, as we have the Solaris infrastructure in-house, let me try to produce something for Solaris. I'll get back to you soon... Cheers Christoph > -Original Message- > From: Severin Gehwolf > Sent: Donnerstag, 4. Juli 2019 14:18 > To: Langer, Christoph ; Andrew John Hughes > ; jdk8u-dev > Cc: build-dev > Subject: Re: [8u] RFR: 8210761: libjsig is being compiled without optimization > > Hi Christoph, > > On Thu, 2019-07-04 at 10:24 +, Langer, Christoph wrote: > > Hi Severin, > > > > sorry, this item got drained down in my pile of work. > > > > AIX looks good. For Solaris, however, there is a problem. > > > > This is an excerpt of the logs: > > SS12u1/SUNWspro/bin/cc -g -xs -m64 -xarch=sparc -G -KPIC \ > > -M > > jdk8/hotspot/make/solaris/makefiles/mapfile-vers-jsig -mt > -xnolib -xO4 -g0 -xs -o libjsig.so > sun_64/nightly/jdk8/hotspot/src/os/solaris/vm/jsig.c -ldl > > cc: Warning: Option -0 passed to ld, if ld is invoked, ignored otherwise > > ld: fatal: unrecognized option '-0' > > ld: fatal: use the '-z help' option for usage information > > Thanks for this info! > > > Seems like the options don't work for Oracle Studio (12 u1) when > > compiling and linking in one go. A fix would be to split compilation > > and linking of the lib into 2 steps, I guess. > > As I don't have access to such a system and test a potential patch, > I've removed the solaris changes: > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK- > 8210761/jdk8/03/webrev/ > > If somebody is able to provide me with a solaris patch, I can happily > include it. Otherwise, solaris will stay as-is. > > Thoughts? OK to push? > > Thanks, > Severin > > > Best regards > > Christoph > > > > > > > -Original Message- > > > From: Severin Gehwolf > > > Sent: Donnerstag, 4. Juli 2019 11:39 > > > To: Langer, Christoph ; Andrew John Hughes > > > ; jdk8u-dev > > > Cc: build-dev > > > Subject: Re: [8u] RFR: 8210761: libjsig is being compiled without > optimization > > > > > > Hi Christoph, > > > > > > On Wed, 2019-06-26 at 13:11 +, Langer, Christoph wrote: > > > > > Here you go: > > > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK- > > > > > 8210761/jdk8/02/webrev/ > > > > > > > > > > I cannot really test on bsd, solaris or aix, though :( Appreciate any > > > > > testers for those platforms. > > > > > > > > I pulled the patch into our test environment. It will be run for AIX > > > > and solaris there. Will let you know the results... > > > > > > Any update? > > > > > > Thanks, > > > Severin
Re: [8u] RFR: 8210761: libjsig is being compiled without optimization
Hi Christoph, On Thu, 2019-07-04 at 10:24 +, Langer, Christoph wrote: > Hi Severin, > > sorry, this item got drained down in my pile of work. > > AIX looks good. For Solaris, however, there is a problem. > > This is an excerpt of the logs: > SS12u1/SUNWspro/bin/cc -g -xs -m64 -xarch=sparc -G -KPIC \ > -M > jdk8/hotspot/make/solaris/makefiles/mapfile-vers-jsig -mt -xnolib -xO4 -g0 > -xs -o libjsig.so sun_64/nightly/jdk8/hotspot/src/os/solaris/vm/jsig.c -ldl > cc: Warning: Option -0 passed to ld, if ld is invoked, ignored otherwise > ld: fatal: unrecognized option '-0' > ld: fatal: use the '-z help' option for usage information Thanks for this info! > Seems like the options don't work for Oracle Studio (12 u1) when > compiling and linking in one go. A fix would be to split compilation > and linking of the lib into 2 steps, I guess. As I don't have access to such a system and test a potential patch, I've removed the solaris changes: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210761/jdk8/03/webrev/ If somebody is able to provide me with a solaris patch, I can happily include it. Otherwise, solaris will stay as-is. Thoughts? OK to push? Thanks, Severin > Best regards > Christoph > > > > -Original Message- > > From: Severin Gehwolf > > Sent: Donnerstag, 4. Juli 2019 11:39 > > To: Langer, Christoph ; Andrew John Hughes > > ; jdk8u-dev > > Cc: build-dev > > Subject: Re: [8u] RFR: 8210761: libjsig is being compiled without > > optimization > > > > Hi Christoph, > > > > On Wed, 2019-06-26 at 13:11 +, Langer, Christoph wrote: > > > > Here you go: > > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK- > > > > 8210761/jdk8/02/webrev/ > > > > > > > > I cannot really test on bsd, solaris or aix, though :( Appreciate any > > > > testers for those platforms. > > > > > > I pulled the patch into our test environment. It will be run for AIX > > > and solaris there. Will let you know the results... > > > > Any update? > > > > Thanks, > > Severin
RE: [8u] RFR: 8210761: libjsig is being compiled without optimization
Hi Severin, sorry, this item got drained down in my pile of work. AIX looks good. For Solaris, however, there is a problem. This is an excerpt of the logs: SS12u1/SUNWspro/bin/cc -g -xs -m64 -xarch=sparc -G -KPIC \ -M jdk8/hotspot/make/solaris/makefiles/mapfile-vers-jsig -mt -xnolib -xO4 -g0 -xs -o libjsig.so sun_64/nightly/jdk8/hotspot/src/os/solaris/vm/jsig.c -ldl cc: Warning: Option -0 passed to ld, if ld is invoked, ignored otherwise ld: fatal: unrecognized option '-0' ld: fatal: use the '-z help' option for usage information Seems like the options don't work for Oracle Studio (12 u1) when compiling and linking in one go. A fix would be to split compilation and linking of the lib into 2 steps, I guess. Best regards Christoph > -Original Message- > From: Severin Gehwolf > Sent: Donnerstag, 4. Juli 2019 11:39 > To: Langer, Christoph ; Andrew John Hughes > ; jdk8u-dev > Cc: build-dev > Subject: Re: [8u] RFR: 8210761: libjsig is being compiled without optimization > > Hi Christoph, > > On Wed, 2019-06-26 at 13:11 +, Langer, Christoph wrote: > > > Here you go: > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK- > > > 8210761/jdk8/02/webrev/ > > > > > > I cannot really test on bsd, solaris or aix, though :( Appreciate any > > > testers for those platforms. > > > > I pulled the patch into our test environment. It will be run for AIX > > and solaris there. Will let you know the results... > > Any update? > > Thanks, > Severin
Re: [8u] RFR: 8210761: libjsig is being compiled without optimization
Hi Christoph, On Wed, 2019-06-26 at 13:11 +, Langer, Christoph wrote: > > Here you go: > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK- > > 8210761/jdk8/02/webrev/ > > > > I cannot really test on bsd, solaris or aix, though :( Appreciate any > > testers for those platforms. > > I pulled the patch into our test environment. It will be run for AIX > and solaris there. Will let you know the results... Any update? Thanks, Severin
Re: RFR: [XS] 8227171: provide function names in native stack trace on aix with xlc16
It's trivial IMHO. Ship it. On Thu, Jul 4, 2019, 09:30 Baesken, Matthias wrote: > Hello, any more reviews ? > > May I push the change ? > > > > Best regards, Matthias > > > > > > > > *From:* Thomas Stüfe > *Sent:* Mittwoch, 3. Juli 2019 14:09 > *To:* Baesken, Matthias > *Cc:* build-dev@openjdk.java.net; ppc-aix-port-...@openjdk.java.net > *Subject:* Re: RFR: [XS] 8227171: provide function names in native stack > trace on aix with xlc16 > > > > Looks good and trivial. Thanks for fixing. > > > > ..Thomas > > > > On Wed, Jul 3, 2019 at 2:02 PM Baesken, Matthias > wrote: > > Hello please review this small fix for AIX (needed with the new xlc16) . > > Currently we miss function names in the hs_err file : > > 0x000115098660 - 0x09000f629a4c libjvm.so:: function>+0x6c (C++ saves_lr stores_bc gpr_saved:4 ) > 0x0001150986f0 - 0x0900113594bc libjvm.so:: function>+0x95c (C++ saves_lr stores_bc gpr_saved:18 ) > > The output contains "nameless function" instead of the (member) function > names . > Looks like this unwanted behavior was introduced when switching to the > xlc16 compiler. > > With xlc16, it looks like we have to configure the traceback table > generation to get the output we need. > > The -qtbtable=full setting can be used for this _ > > > https://www.ibm.com/support/knowledgecenter/SSGH4D_16.1.0/com.ibm.xlf161.aix.doc/compiler_ref/tbtable.html > > > > Bug / webrev : > > https://bugs.openjdk.java.net/browse/JDK-8227171 > > http://cr.openjdk.java.net/~mbaesken/webrevs/8227171.0/ > > > Thanks, Matthias > >
RE: RFR: [XS] 8227171: provide function names in native stack trace on aix with xlc16
Hello, any more reviews ? May I push the change ? Best regards, Matthias From: Thomas Stüfe Sent: Mittwoch, 3. Juli 2019 14:09 To: Baesken, Matthias Cc: build-dev@openjdk.java.net; ppc-aix-port-...@openjdk.java.net Subject: Re: RFR: [XS] 8227171: provide function names in native stack trace on aix with xlc16 Looks good and trivial. Thanks for fixing. ..Thomas On Wed, Jul 3, 2019 at 2:02 PM Baesken, Matthias mailto:matthias.baes...@sap.com>> wrote: Hello please review this small fix for AIX (needed with the new xlc16) . Currently we miss function names in the hs_err file : 0x000115098660 - 0x09000f629a4c libjvm.so::+0x6c (C++ saves_lr stores_bc gpr_saved:4 ) 0x0001150986f0 - 0x0900113594bc libjvm.so::+0x95c (C++ saves_lr stores_bc gpr_saved:18 ) The output contains "nameless function" instead of the (member) function names . Looks like this unwanted behavior was introduced when switching to the xlc16 compiler. With xlc16, it looks like we have to configure the traceback table generation to get the output we need. The -qtbtable=full setting can be used for this _ https://www.ibm.com/support/knowledgecenter/SSGH4D_16.1.0/com.ibm.xlf161.aix.doc/compiler_ref/tbtable.html Bug / webrev : https://bugs.openjdk.java.net/browse/JDK-8227171 http://cr.openjdk.java.net/~mbaesken/webrevs/8227171.0/ Thanks, Matthias
