RFR 8234697: Generate sun.security.util.math.intpoly classes during build

Please review the change at http://cr.openjdk.java.net/~weijun/8234697/webrev.00/ The new lines in Gensrc-java.base.gmk mimics the one for CLDR_GEN_DONE at the beginning of the same file. I changed the BigInteger parameter in the FieldParams constructor (the one not reading terms) to its

Re: RFR: JEP 367: Remove the Pack200 Tools and API

Hello, On 2019-11-22 13:30, Vicente Romero wrote: Hi all, On 11/22/19 3:21 AM, Alan Bateman wrote: On 21/11/2019 19:53, Vicente Romero wrote: Hi, I think I have covered all the proposed fixes so far. This is the last iteration of the webrev [1], all the current changes are in this one,

Re: RFR: JEP 367: Remove the Pack200 Tools and API

Hi all, On 11/22/19 3:21 AM, Alan Bateman wrote: On 21/11/2019 19:53, Vicente Romero wrote: Hi, I think I have covered all the proposed fixes so far. This is the last iteration of the webrev [1], all the current changes are in this one, the code hasn't been split into different webrevs.

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

Hi! On 11/22/19 8:01 PM, Mikael Vidstedt wrote: > Erik/Tim, thanks for the reviews! > > On more small change: Update building.md (and .html) to reflect the > deprecation of the ports: > > http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.02.incr/open/webrev/ > >

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

Erik/Tim, thanks for the reviews! On more small change: Update building.md (and .html) to reflect the deprecation of the ports: http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.02.incr/open/webrev/ Let

Re: RFR: 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC

Hello Christoph, On 2019-11-20 10:22, christoph.goettsch...@microdoc.com wrote: Hi, please review the following change. Bug: https://bugs.openjdk.java.net/browse/JDK-8234535 Webrev: https://cr.openjdk.java.net/~cgo/8234535/webrev.00/ The removed lines are completely out of place and have no

Re: Fwd: RFR: 8233299: Implementation: JEP 365: ZGC on Windows

Thanks, Erik. StefanK On 2019-11-22 15:24, Erik Joelsson wrote: Build change looks good. /Erik On 2019-11-21 13:11, Stefan Karlsson wrote: Hi, I'm looking for a review for this tiny build change: https://cr.openjdk.java.net/~stefank/8233299/webrev.01/make/autoconf/hotspot.m4.udiff.html

RE: RFR: 8234525: enable link-time section-gc for linux s390x to remove unused code

Hi Erik, yes it makes the build more chatty - our linux s390 product build log of jdk/jdk goes from ~ 60.000 lines to ~ 123.000 lines with the patch. However the change is linux s390 only so I guess it will not disturb other people ( in case we bring it to more platforms

Re: Fwd: RFR: 8233299: Implementation: JEP 365: ZGC on Windows

Build change looks good. /Erik On 2019-11-21 13:11, Stefan Karlsson wrote: Hi, I'm looking for a review for this tiny build change: https://cr.openjdk.java.net/~stefank/8233299/webrev.01/make/autoconf/hotspot.m4.udiff.html Thanks, StefanK Forwarded Message Subject:

Re: RFR: 8234525: enable link-time section-gc for linux s390x to remove unused code

Hello Matthias, This looks like an interesting change. If you want to enable this for s390x, I'm ok with it. If it works out well, perhaps we can find a way to expand this to other architectures. Do you really want to set --print-gc-sections by default? I would assume that makes the build

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

Mikael: Looks good to me as well. Tim On 2019-11-22 06:10, Erik Joelsson wrote: Looks good. /Erik On 2019-11-20 12:03, Mikael Vidstedt wrote: I noticed that most of the configure options include the default value in the help string (in brackets), so here’s an updated webrev which does

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

Looks good. /Erik On 2019-11-20 12:03, Mikael Vidstedt wrote: I noticed that most of the configure options include the default value in the help string (in brackets), so here’s an updated webrev which does exactly that: Webrev:

Re: RFR: JEP 367: Remove the Pack200 Tools and API

On 21/11/2019 19:53, Vicente Romero wrote: Hi, I think I have covered all the proposed fixes so far. This is the last iteration of the webrev [1], all the current changes are in this one, the code hasn't been split into different webrevs. I'm also forwarding to build-dev as there are some