Re: RFR: 8235960: Zero should not trigger the deprecation warning for ports

2019-12-16 Thread John Paul Adrian Glaubitz
On 12/16/19 10:08 PM, Mikael Vidstedt wrote: > > I’m not actually sure, but just to be on the safe side I’d prefer to add the > grouping. Okay, will do. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin -

Re: RFR: 8235960: Zero should not trigger the deprecation warning for ports

2019-12-16 Thread Mikael Vidstedt
I’m not actually sure, but just to be on the safe side I’d prefer to add the grouping. Cheers, Mikael > On Dec 16, 2019, at 11:45 AM, John Paul Adrian Glaubitz > wrote: > > On 12/16/19 8:40 PM, John Paul Adrian Glaubitz wrote: >> Hi Mikael! >> >> On 12/16/19 8:38 PM, Mikael Vidstedt

Re: RFR: 8235960: Zero should not trigger the deprecation warning for ports

2019-12-16 Thread John Paul Adrian Glaubitz
On 12/16/19 8:40 PM, John Paul Adrian Glaubitz wrote: > Hi Mikael! > > On 12/16/19 8:38 PM, Mikael Vidstedt wrote: >> You need to group the OPENJDK_TARGET_CPU_ARCH and with_jvm_variants checks. >> The suggested change will incorrectly *not* produce a warning for >> solaris/*/zero. >> >>

Re: RFR: 8235960: Zero should not trigger the deprecation warning for ports

2019-12-16 Thread John Paul Adrian Glaubitz
Hi Mikael! On 12/16/19 8:38 PM, Mikael Vidstedt wrote: > You need to group the OPENJDK_TARGET_CPU_ARCH and with_jvm_variants checks. > The suggested change will incorrectly *not* produce a warning for > solaris/*/zero. > > Something like this should do the trick: > > if test

Re: RFR: 8235960: Zero should not trigger the deprecation warning for ports

2019-12-16 Thread Mikael Vidstedt
You need to group the OPENJDK_TARGET_CPU_ARCH and with_jvm_variants checks. The suggested change will incorrectly *not* produce a warning for solaris/*/zero. Something like this should do the trick: if test "x$OPENJDK_TARGET_OS" = xsolaris || (test "x$OPENJDK_TARGET_CPU_ARCH" = xsparc &&

RFR: 8235997: JMH test runner should quote VM_OPTIONS and JAVA_OPTIONS sent to -jvmArgs

2019-12-16 Thread Claes Redestad
Hi, please review this patch[1] which makes the JMH behave more in line with expectations when adding multiple flags using the VM_OPTIONS and JAVA_OPTIONS control variables. E.g., these fail before the patch: make test TEST=... MICRO="VM_OPTIONS=-Xmx4g -Xms4g" make test TEST=...