On Fri, 10 Jun 2022 17:11:41 GMT, Alexey Ivanov wrote:
> Update the link to JBS in `vcs.xml` template to https://bugs.openjdk.org/
>
> It will affect newly generated project files only.
> Edit `vcs.xml` manually or in UI to update in existing projects.
Marked as reviewed by ihse (Reviewer).
On Fri, 10 Jun 2022 17:11:41 GMT, Alexey Ivanov wrote:
> Update the link to JBS in `vcs.xml` template to https://bugs.openjdk.org/
>
> It will affect newly generated project files only.
> Edit `vcs.xml` manually or in UI to update in existing projects.
Looks good - thanks!
-
On Fri, 10 Jun 2022 07:29:49 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>> way.
>
> This all looks very
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
On Fri, 10 Jun 2022 11:23:57 GMT, Aleksey Shipilev wrote:
>> If I do that, there need to be some kind of if statement in the called
>> workflow, since if that input argument is left out, we'd get a command line
>> like `sudo dpkg --add-architecture` which I assume is illegal syntax (or,
>>
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
On Fri, 10 Jun 2022 11:22:00 GMT, Aleksey Shipilev wrote:
>> I can merge the two `apt-get install` lines, if you say that it is not
>> necessary to call `update-alternatives` before the second install line. (But
>> does it really speed things up?)
>
>> (But does it really speed things up?)
>
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
On Fri, 10 Jun 2022 09:54:36 GMT, Magnus Ihse Bursie wrote:
> A few changes to the build system is needed for the GHA rewrite
> ([JDK-8287906](https://bugs.openjdk.org/browse/JDK-8287906)).
This pull request has now been integrated.
Changeset: d0c8ff8f
Author:Magnus Ihse Bursie
URL:
On Fri, 10 Jun 2022 07:23:12 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>> way.
>
> make/InitSupport.gmk
Update the link to JBS in `vcs.xml` template to https://bugs.openjdk.org/
It will affect newly generated project files only.
Edit `vcs.xml` manually or in UI to update in existing projects.
-
Commit messages:
- 8288114: Update JIRA link in vcs.xml
Changes:
On Fri, 10 Jun 2022 09:34:53 GMT, Magnus Ihse Bursie wrote:
>> With project Skara, the ability to run a set of sanity build and test jobs
>> on selected platforms was added. This functionality was driven by
>> `.github/workflows/submit.yml`. This file unfortunately lacks any real
>>
On Fri, 10 Jun 2022 09:54:36 GMT, Magnus Ihse Bursie wrote:
> A few changes to the build system is needed for the GHA rewrite
> ([JDK-8287906](https://bugs.openjdk.org/browse/JDK-8287906)).
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9122
On Fri, 10 Jun 2022 09:45:15 GMT, Magnus Ihse Bursie wrote:
> (But does it really speed things up?)
Yes, I think it does: `apt` would read the package database once, and do the
post-install actions once. `update-alternatives` does not have to happen
between those two lines.
-
On Fri, 10 Jun 2022 09:39:29 GMT, Magnus Ihse Bursie wrote:
>> .github/actions/get-bootjdk/action.yml line 26:
>>
>>> 24: #
>>> 25:
>>> 26: name: 'Get BootJDK'
>>
>> Here and later, polishing: "BootJDK" -> "boot JDK"?
>
> I think we've mostly been using "BootJDK" as a specialized term in the
On Fri, 10 Jun 2022 09:54:36 GMT, Magnus Ihse Bursie wrote:
> A few changes to the build system is needed for the GHA rewrite
> ([JDK-8287906](https://bugs.openjdk.org/browse/JDK-8287906)).
Looks fine!
-
Marked as reviewed by shade (Reviewer).
PR:
A few changes to the build system is needed for the GHA rewrite
([JDK-8287906](https://bugs.openjdk.org/browse/JDK-8287906)).
-
Commit messages:
- 8288195: Prepare build system for GHA changes
Changes: https://git.openjdk.org/jdk/pull/9122/files
Webrev:
On Fri, 10 Jun 2022 07:18:34 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>> way.
>
>
On Fri, 10 Jun 2022 09:43:47 GMT, Magnus Ihse Bursie wrote:
>> Also, I think we can speed up this part by merging two `apt-get install`
>> invocation lines together. It was separate before, because it was two steps,
>> unnecessary now.
>
> Ideally, all version information should be centralized
On Fri, 10 Jun 2022 07:14:33 GMT, Aleksey Shipilev wrote:
>> .github/workflows/build-cross-compile.yml line 89:
>>
>>> 87: sudo apt-get install gcc-${{ inputs.apt-gcc-version }}
>>> g++-${{ inputs.apt-gcc-version }} libxrandr-dev${{ inputs.apt-architecture
>>> }} libxtst-dev${{
On Fri, 10 Jun 2022 07:09:28 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>> way.
>
>
On Fri, 10 Jun 2022 07:07:11 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>> way.
>
>
> With project Skara, the ability to run a set of sanity build and test jobs on
> selected platforms was added. This functionality was driven by
> `.github/workflows/submit.yml`. This file unfortunately lacks any real
> structure, and contains a lot of code duplication and redundancy. This has
On Thu, 9 Jun 2022 06:49:15 GMT, KIRIYAMA Takuya wrote:
> The description for the jtreg-failure-handler option is incorrect, so I fixed
> it to describe jtreg-failure-handler option.
> Would you please review this fix?
This pull request has now been integrated.
Changeset: 09015488
Author:
On Thu, 9 Jun 2022 12:57:05 GMT, Magnus Ihse Bursie wrote:
>> With project Skara, the ability to run a set of sanity build and test jobs
>> on selected platforms was added. This functionality was driven by
>> `.github/workflows/submit.yml`. This file unfortunately lacks any real
>> structure,
On Fri, 10 Jun 2022 07:13:32 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Apparently that was not a legal reference to actions/checkout. Try another
>> way.
>
>
On Thu, 9 Jun 2022 06:49:15 GMT, KIRIYAMA Takuya wrote:
> The description for the jtreg-failure-handler option is incorrect, so I fixed
> it to describe jtreg-failure-handler option.
> Would you please review this fix?
I appreciate all reviews. I hope this change is integrated.
29 matches
Mail list logo
