Changeset: a601faeb7172
Author:wetmore
Date: 2007-11-16 18:10 -0800
URL: http://hg.openjdk.java.net/jdk7/jsn/rev/a601faeb7172
Nothing to see here, daughter
! Makefile
Changeset: 51dc87a1de64
Author:weijun
Date: 2007-11-29 10:52 +0800
URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/51dc87a1de64
Second Try
! README
Changeset: 4cbbdfccc885
Author:weijun
Date: 2007-11-30 01:17 +0800
URL:
Changeset: ff6031bc8f2c
Author:wetmore
Date: 2007-11-16 17:57 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ff6031bc8f2c
Move along, nothing to see here in the open.
! make/Makefile
Changeset: 136e95de6f4a
Author:chegar
Date: 2007-11-28 16:18 +
URL:
Changeset: cbb2915931cd
Author:ohair
Date: 2007-11-09 15:47 -0800
URL: http://hg.openjdk.java.net/jdk7/jsn/rev/cbb2915931cd
Added junk
+ junk
Changeset: e1bdac1823a1
Author:xdono
Date: 2007-11-09 15:56 -0800
URL: http://hg.openjdk.java.net/jdk7/jsn/rev/e1bdac1823a1
Changeset: 8d2bb475b3dd
Author:wetmore
Date: 2007-11-12 16:37 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8d2bb475b3dd
Hello there, Duke!
! make/Makefile
Changeset: 3191daff8073
Author:wetmore
Date: 2007-11-12 17:07 -0800
URL:
Changeset: 4fbb76406145
Author:ohair
Date: 2007-11-09 15:47 -0800
URL: http://hg.openjdk.java.net/jdk7/jsn/hotspot/rev/4fbb76406145
Added junk
+ junk
Changeset: 036a6d4ba0ac
Author:ohair
Date: 2007-11-09 16:12 -0800
URL:
Changeset: fe61ef5aada9
Author:wetmore
Date: 2009-08-03 18:06 -0700
URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/fe61ef5aada9
6647452: Remove obfuscation, framework and provider self-verification checking
Reviewed-by: valeriep, vinnie
! make/com/sun/crypto/provider/Makefile
Kelly just wrote:
It's not clear...and slightly augmented by the openjdk bugzilla.
I think Andrew was referring to http://bugs.openjdk.java.net.
I was. I'm not sure what else the phrase OpenJDK bug database
would refer to.
There were several bug systems mentioned in Kelly's
As the submitter, I also agree with this part of the fix and all
comments made here. ;)
Erik, one thing I did not check is whether other .jars in j2re/j2sdk use
a different manifest template than the one you modified. Have you
checked them all?
You do not need to check these .jars, they
Offhand, no idea. Instance lives in sun.security.getInstance, and
you're finding that class. I haven't tried out sjavac, but given the
warning build/linux-x86-normal-server-release/jdk/classes/javac_state,
and that I've never seen this directory, might you be triggering a
sjavac bug?
If
It never worked like it did in Teamware.
Brad
On 10/11/2013 11:33 AM, Mike Duigou wrote:
I should also ask if anyone is using the -l option. I would like to delete it
as well as it offers no particular value for mercurial (that I can tell).
Mike
On Oct 10 2013, at 17:20 , Weijun Wang wrote:
http://cr.openjdk.java.net/~wetmore/8026762/webrev/
The JDK build broke because the JDK couldn't find the CORBA inbound files.
Needs to be quoted due to Windows separator being a semi-colon:
JAVAC: is path separator
CYGWIN: is statement/command separator
I also did two minor indention
:10 AM, Bradford Wetmore wrote:
http://cr.openjdk.java.net/~wetmore/8026762/webrev/
The JDK build broke because the JDK couldn't find the CORBA inbound
files.
Needs to be quoted due to Windows separator being a semi-colon:
JAVAC: is path separator
CYGWIN: is statement/command separator
I
Updated webrev:
http://cr.openjdk.java.net/~wetmore/8026762/
Brad
On 10/16/2013 6:35 PM, Bradford Wetmore wrote:
Ok, David Holmes, I will back out the indention changes.
Thanks, David Katleman, my build just died with the issue you and Tim
Bell found.
So Windows TL is still broken. I'll
On 10/16/2013 7:00 PM, David Holmes wrote:
On 17/10/2013 11:55 AM, Bradford Wetmore wrote:
Updated webrev:
http://cr.openjdk.java.net/~wetmore/8026762/
Assuming this gets through a full JPRT build SHIP IT! :)
Yes, that is my SOP!
Brad
Thanks,
David
Brad
On 10/16/2013 6:35 PM
Have not researched how 4.01 is different from 3.82.90-1. Has anyone
tried it?
As an FYI, 3.81 is no longer available from the normal Cygwin setup
distribution. The previous version is now 3.82.90-1.
Brad
Bell wrote:
On 10/20/13 09:49 AM, Bradford Wetmore wrote:
Have not researched how 4.01 is different from 3.82.90-1. Has anyone
tried it?
As an FYI, 3.81 is no longer available from the normal Cygwin setup
distribution. The previous version is now 3.82.90-1.
See bug # JDK-8026528 [build
Looks good to me also.
Brad
On 10/22/2013 3:19 PM, Magnus Ihse Bursie wrote:
On 2013-10-23 00:14, David Katleman wrote:
Please review this simple fix, addressing a problem with yesterday's
integration of JDK-8026528.
NewMakefile.gmk was extended to recognize version 4 of make, but in
the
On 10/22/2013 7:52 AM, Erik Joelsson wrote:
Trying this again. Here is a new webrev against jdk8/build. Again, this
solves the issue detailed by Alan in this bug.
http://cr.openjdk.java.net/~erikj/8009280/webrev.04/
There will probably be more issues in JDK-8006350 [build] JCE unusable
using
I just rebuilt my CYGWIN, and got ccache 3.1.9-2, which enables ccache
in the new build environment. fixpath.exe does not play well with it.
Please see:
https://bugs.openjdk.java.net/browse/JDK-8027683
JDK-8027683: New version of CYGWIN includes ccache 3.1.9-2, breaks the
windows build.
P.S. This version of ccache was added two days ago.
Brad
On 10/31/2013 3:42 PM, Bradford Wetmore wrote:
I just rebuilt my CYGWIN, and got ccache 3.1.9-2, which enables ccache
in the new build environment. fixpath.exe does not play well with it.
Please see:
https://bugs.openjdk.java.net
/31/2013 4:51 PM, Mike Duigou wrote:
Magnus indicated in another thread earlier today that ccache doesn't do
anything on windows since we use the microsoft compilers.
--disable-ccache or uninstall it.
I filed an RFE to disable ccache on windows.
Mike
On Oct 31 2013, at 15:50 , Bradford Wetmore
On 11/1/2013 3:34 AM, Erik Joelsson wrote:
Please review this simple fix, adding sunmscapi.jar and ucrypto.jar to
the list of jars to be signed by the sign-jars target. Since these jars
are platform dependent, they aren't always present.
Bug: https://bugs.openjdk.java.net/browse/JDK-8027698
On 11/5/2013 1:31 AM, Erik Joelsson wrote:
On 2013-11-04 20:57, Bradford Wetmore wrote:
Hi Erik,
Thanks for the update! Looks good, but one minor comment:
SignJars.gmk
78:100:106:111-116 80 chars per line.
Thanks. We have not enforced 80 chars in any other file in the new
Erik,
Thanks so much for handling much of the build work here. I was planning
on doing it, but you've got the background in the new build-infra so
this probably much easier for you. I've enjoyed learning new GnuMake
techniques.
I've reviewed this pretty well, but didn't hit the previous 2
Erik,
Given the name of your workspace /localhome/hg/jdk8-tl, I'm assuming
this will be going through the TL gate instead of build? Please do use
tl, as there will be some parallel changes to the RE scripts that I need
to make, and we won't be surprised when the changes hit the gate weeks
IIRC, and in case it wasn't clear from reading the responses, the
permission changes are done by the Makefiles (e.g.
jdk/test/Makefile:193), and not by JTREG itself.
I agree with Jon's comment, perhaps a .dll copy to the temporary working
directory is in order. That would save people trying
This is blocking JDK-8030823 (JCE prebuilt jar files), so I looked at it
also.
Ditto the comments from Erik. The plan is these @ignores will be pulled
out when 8030656 is fixed?
Brad
On 12/19/2013 1:38 AM, Erik Joelsson wrote:
Build change looks good to me. I'm not familiar with the
On 1/9/2014 12:34 AM, Alan Bateman wrote:
On 09/01/2014 08:07, Anthony Scarpino wrote:
As an aside, I think we should strike while the iron is hot and get the
changes required to move major versions written down somewhere (maybe
checked into the forest). I see Joe has updated the
P.S. Forgot to mention, this looks good to me. Thanks for jumping in
on this one. ;)
Brad
On 1/9/2014 12:07 AM, Anthony Scarpino wrote:
Hi,
I have a change that needs a review to the manifest.mf file for the
Specification-Version from 1.8 to 1.9. This is needed as part of the
build
For quite some time I've been building on my Windows 7 laptop using
something like this:
% bash configure --enable-debug \
--with-boot-jdk=/cygdrive/d/java/bootdirs/i586/jdk1.7.0_XX
As of Wed, my builds started dying in the big compile the JDK world
javac part [1] of the jdk repo with :
Phil,
That looks exactly like my problem.
http://mail.openjdk.java.net/pipermail/build-dev/2014-March/012089.html
Subject: Heads Up: OutOfMemoryError when building a 64-bit JDK 9 using
a 32-bit bootdir.
Yes, 32 bit it appears, although I didn't supply the boot dir option,
it chose it all
Looks good.
Brad
On 3/18/2014 8:04 AM, Tim Bell wrote:
Hi Erik:
On 2014-03-18 11:42, Erik Joelsson wrote:
Please review this very simple fix to unzipping pre built security
classes. When building incrementally, unzip will go into interactive
mode and ask if it should overwrite files. The
I've noticed in various repos that the .hgignore files include
variations on webrev, ^webrev/, or leave it out completely. In other
words, it's inconsistent.
Mark offered:
http://mail.openjdk.java.net/pipermail/build-dev/2008-February/000742.html
which add your own personal .hgignore
I created:
https://bugs.openjdk.java.net/browse/JDK-8058180
The code review is:
http://cr.openjdk.java.net/~wetmore/8058180/open/
Brad
On 9/10/2014 12:00 PM, Bradford Wetmore wrote:
I've noticed in various repos that the .hgignore files include
variations on webrev, ^webrev
.
Brad
On 9/10/2014 4:18 PM, Jonathan Gibbons wrote:
The langtools/ change is OK by me.
-- Jon
On 09/10/2014 04:11 PM, Bradford Wetmore wrote:
I created:
https://bugs.openjdk.java.net/browse/JDK-8058180
The code review is:
http://cr.openjdk.java.net/~wetmore/8058180/open/
Brad
but many directories have that pattern:
./hotspot/test/runtime/7162488
./hotspot/test/runtime/7162488/Test7162488.sh
so decided against it.
[1]
On 9/10/2014 7:21 PM, John Rose wrote:
On Sep 10, 2014, at 4:22 PM, Bradford Wetmore
bradford.wetm...@oracle.com mailto:bradford.wetm...@oracle.com
Hi Sean/Mandy/Erik/Magnus/Alan/David/others,
Please review:
JDK-8058845 : Update JCE environment for build improvements
http://cr.openjdk.java.net/~wetmore/8058845/
This change is to alleviate some of the overly-complicated steps we
(Oracle) have in building and maintaining the JCE
javax/crypto/JceSecurity.java
line 79: this could be (PrivilegedExceptionActionVoid) as the
return value is ignored
Good catch.
It may be better to rename URLVerifier to ProviderVerifier as it verifies
the security provider of the given codebase. URLVerifier might give
an
Is there a bug id yet? I haven't seen one showing up in a quick search
for dd_fd or perfMemory_solaris.cpp.
For the record, I'm on what I think is the required platform/compilers:
% uname -a
SunOS sca00bkv 5.11 11.1 sun4v sparc sun4v
% more /etc/release
Oracle
Looks good, thanks for fixing this!
Brad
On 1/15/2015 3:05 AM, Erik Joelsson wrote:
Hello,
Please review the open part of this patch, which changes the building of
policy jars to happen even if BUILD_CRYPTO is false. Previously these
weren't built as there were signed versions of these
Hi Jiri,
This is open issue #2 from JEP-220 [1] that we still need to address for
JDK 9, so your patch will likely be moot soon. It's possible that the
jar will be going away.
If you would like to watch the progress, please add yourself to:
JDK-8061842: Package jurisdiction policy files as
Jesper,
This is not a review comment, but could you tell us how these netbeans
projects are supposed to be used? To do my JDK debugging, I usually
create an exploded JDK build using the normal make files, then in
Netbeans created a new platform that pointed at the build/*/jdk
directory,
P.S. It fixed the problem on my Windows build. Thanks!
Brad
On 9/2/2016 1:13 PM, Bradford Wetmore wrote:
Looks good to me.
Ditto. Always learn something new about gmake reading the build code.
Thanks for adding the ReportBuildTimes. That's a nice thing to have.
Brad
On 9/2/2016 8
> Looks good to me.
Ditto. Always learn something new about gmake reading the build code.
Thanks for adding the ReportBuildTimes. That's a nice thing to have.
Brad
On 9/2/2016 8:02 AM, Tim Bell wrote:
On 09/02/16 05:16, Erik:
The symptom of this problem is that if the build fails,
Forwarding from security-dev to build-dev, as there is a change proposed
for the way the cryptographic policy files are built.
https://bugs.openjdk.java.net/browse/JDK-8061842
http://cr.openjdk.java.net/~wetmore/8061842/webrev.01/
The proposal is to move the configuration files from the jar
Looks ok to me...
I had to look at the C declaration one twice. Too much Java, not enough
C lately.
Brad
On 8/25/2016 2:20 PM, Anthony Scarpino wrote:
Hi,
Can I get a review of this change to remove the warning suppression and
fix the minor compiler issues that it was hiding in the
I didn't see anything majorly different in what I looked at earlier, I
didn't check java.security or the test case.
CryptoLevel.java
49: Your usage mentions only unlimited|limited. Do you want to include
a check for that?
JceSecurity.java
300: Indention
eys/webrev.8157561.8u.jdk.v5/webrev/
Regards,
Sean.
On 04/11/16 22:56, Bradford Wetmore wrote:
I didn't see anything majorly different in what I looked at earlier, I
didn't check java.security or the test case.
CryptoLevel.java
49: Your usage mentions only unlimited|limited. Do you want
Hi,
I need reviewers for these related bugs:
https://bugs.openjdk.java.net/browse/JDK-8170157
Enable unlimited cryptographic policy by default in OracleJDK
https://bugs.openjdk.java.net/browse/JDK-8169335
Add a crypto policy fallback in case Security Property
'crypto.policy' does not
Looks ok to me too, but I see it's already been pushed.
Since I doubt the JPRG machines are new enough, I will reload the new
grep onto my machine and ensure it works. Unless you hear from me,
assume we're ok.
Brad
On 3/1/2017 9:24 AM, Magnus Ihse Bursie wrote:
Looks good to me.
Jan,
What is your current recommended technique to use NetBeans to
build/edit/test OpenJDK for normal OpenJDK library developers?
After many versions of Netbeans, my current setup is to:
1. Do an external "exploded" build
2. Run Netbeans, open the src/java.base module project and any
On 4/30/2020 12:28 AM, Jan Lahoda wrote:
Hi Brad,
This is very similar to what I do. Some small comments inline.
On 29. 04. 20 21:02, Bradford Wetmore wrote:
Jan,
What is your current recommended technique to use NetBeans to
build/edit/test OpenJDK for normal OpenJDK library developers
Thanks again Jan for looking into and fixing this.
I looked over the new entries last week, and the new MR3 ALPN/PSS items
looked good.
My only comment is that as a newbie to this area, the "header" attribute
includes the "innerclass" parameters: innerclass isn't an attribute on
its own
On Fri, 11 Sep 2020 07:15:26 GMT, Dmitriy Dumanskiy
wrote:
>> 1) This is un-necessary churn.
>> 2) I can't even be sure I am finding the ones in my area because there's so
>> much here
>> 3) The ones I can find have no need of whatever performance improvement this
>> might bring.
>> I think
On Wed, 16 Jun 2021 16:16:51 GMT, Bradford Wetmore wrote:
> JDK-8268768 reverted a couple putbacks that changed the way the idea projects
> are generated.
>
> Two new template files from JDK-8267706 were missed, and will be removed in
> this fix.
>
> See original bu
JDK-8268768 reverted a couple putbacks that changed the way the idea projects
are generated.
Two new template files from JDK-8267706 were missed, and will be removed in
this fix.
See original bug for further details.
-
Commit messages:
- 8268901: JDK-8268768 missed removing
On Thu, 11 Mar 2021 14:53:22 GMT, Roger Riggs wrote:
>> Disable the "missing" target for java.smartcardio from doclint.
>
> Please assign a new bug and title to ignore/suppress the warnings.
> The original issue 8252833 should be left open.
> Thanks
Closing, as it's unclear which approach
On Thu, 11 Mar 2021 01:13:12 GMT, Bradford Wetmore wrote:
> Disable the "missing" target for java.smartcardio from doclint.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/2930
Build change only. This is to prevent javadoc build failures in
java.smartcardio when "missing" is eventually removed from the doclint exclude
target list.
This is a follow-on to JDK-8252833, which is a subtask of JDK-8251202.
-
Commit messages:
- jcheck/whitespace problem
-
On Thu, 18 Mar 2021 18:49:22 GMT, Bradford Wetmore wrote:
> Build change only. This is to prevent javadoc build failures in
> java.smartcardio when "missing" is eventually removed from the doclint
> exclude target list.
>
> This is a follow-on to JDK-8252833, which is
Disable the "missing" target for java.smartcardio from doclint.
-
Commit messages:
- Forgot copyright date update
- 8252833: Correct "no comment" warnings from javadoc in java.smartcardio
module
Changes: https://git.openjdk.java.net/jdk/pull/2930/files
Webrev:
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
LGTM also.
Similar suggestion for updating copyrights.
-
Marked as reviewed by wetmore (Reviewer).
PR:
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Looked at
-java.security.jgss.
LGTM
Andrey/Christoph,
This may be a little late, but...
Maybe this gives a hint on how to fix it?
I (and others in my group) typically use the root c:/cygwin and avoid
this whole issue.
Brad
On 6/3/2022 12:09 AM, Langer, Christoph wrote:
Hi,
I see the same on my windows build. I verified
65 matches
Mail list logo
