Re: RFR 8043937: Drop support for the IIOP transport from the JMX RMIConnector

2015-08-24 Thread Jaroslav Bachorik
On 24.8.2015 08:52, Alan Bateman wrote: On 21/08/2015 12:49, Jaroslav Bachorik wrote: Updated webrev top-level: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.03 Updated webrev jdk: http://cr.openjdk.java.net/~jbachorik/8043937/webrev.03/jdk Contains changes to the top level repo as

RFR 8140481: NoClassDefFoundError thrown by ManagementFactory.getPlatformMBeanServer

2015-11-02 Thread Jaroslav Bachorik
Please, review the following build change Issue : https://bugs.openjdk.java.net/browse/JDK-8140481 Webrev: http://cr.openjdk.java.net/~jbachorik/8140481/webrev.00 Currently, the 'jdk.management' module is not a part of the JRE image even though it should be. This patch adds 'jdk.management' to

Re: RFR 8140481: NoClassDefFoundError thrown by ManagementFactory.getPlatformMBeanServer

2015-11-02 Thread Jaroslav Bachorik
On 2.11.2015 09:28, Alan Bateman wrote: On 02/11/2015 08:08, Jaroslav Bachorik wrote: Please, review the following build change Issue : https://bugs.openjdk.java.net/browse/JDK-8140481 Webrev: http://cr.openjdk.java.net/~jbachorik/8140481/webrev.00 Currently, the 'jdk.management'

Re: RFR 8140481: NoClassDefFoundError thrown by ManagementFactory.getPlatformMBeanServer

2015-11-02 Thread Jaroslav Bachorik
On 2.11.2015 09:28, Alan Bateman wrote: On 02/11/2015 08:08, Jaroslav Bachorik wrote: Please, review the following build change Issue : https://bugs.openjdk.java.net/browse/JDK-8140481 Webrev: http://cr.openjdk.java.net/~jbachorik/8140481/webrev.00 Currently, the 'jdk.management'

RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-24 Thread Jaroslav Bachorik
Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top * jdk: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/jdk This patch splits up the jdk.jvmstat module to jdk.jvm

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-25 Thread Jaroslav Bachorik
On 25.11.2015 10:02, Alan Bateman wrote: On 24/11/2015 16:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top * jdk: http

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-25 Thread Jaroslav Bachorik
On 25.11.2015 11:36, Magnus Ihse Bursie wrote: On 2015-11-25 10:39, Alan Bateman wrote: On 25/11/2015 09:25, Jaroslav Bachorik wrote: I don't think we can just repackage these interfaces - they are remote API and we would break compatibility (eg. JDK 8 jvmstat would not be able to quer

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-25 Thread Jaroslav Bachorik
On 25.11.2015 09:37, Erik Joelsson wrote: On 2015-11-25 09:11, Staffan Larsen wrote: On 24 nov. 2015, at 17:03, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8043138 Webrevs: * top level: http://cr.openjdk.java.net/~jbachorik

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-26 Thread Jaroslav Bachorik
Mandy, On 25.11.2015 18:22, Mandy Chung wrote: On Nov 25, 2015, at 8:53 AM, Jaroslav Bachorik wrote: Updated webrevs: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/top http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/jdk This looks fine to me. Is there any test

RFR 8142398: IllegalAccessException Class sun.usagetracker.UsageTrackerClient$4 (module java.base) can not access a member of class java.lang.management.ManagementFactory (module java.management)

2015-12-14 Thread Jaroslav Bachorik
Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8138677 Webrev: http://cr.openjdk.java.net/~jbachorik/8138677/webrev.00 The problem is that the class UsageTrackerClient is accessing RuntimeMXBean.getInputArguments() method via reflection to avoid static dep

Re: RFR 8142398: IllegalAccessException Class sun.usagetracker.UsageTrackerClient$4 (module java.base) can not access a member of class java.lang.management.ManagementFactory (module java.management)

2015-12-15 Thread Jaroslav Bachorik
On 15.12.2015 08:03, Alan Bateman wrote: On 14/12/2015 16:55, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8138677 Webrev: http://cr.openjdk.java.net/~jbachorik/8138677/webrev.00 The problem is that the class

Re: RFR(L): JDK-8067194 Restructure hotspot/agent/src to conform the modular source layout

2015-12-22 Thread Jaroslav Bachorik
Hi, looks good, modulo the problems you are mentioning (docs will need update to refer to correct locations; the same might be true for the textual output from scripts). I believe the tests are still passing. Supposing the remaining problems are covered by CR you can consider this reviewed.

Re: RFR(L): JDK-8067194 Restructure hotspot/agent/src to conform the modular source layout

2015-12-22 Thread Jaroslav Bachorik
Hi, looks good, modulo the problems you are mentioning (docs will need update to refer to correct locations; the same might be true for the textual output from scripts). I believe the tests are still passing. Supposing the remaining problems are covered by CR you can consider this reviewed.