Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

2018-11-02 Thread Magnus Ihse Bursie
> 2 nov. 2018 kl. 18:03 skrev Igor Ignatyev : > > Hi Magnus, > >> You still need to fix FindTests.gmk, though. > thanks for spotting that. is [*] enough, or did I miss something else? This looks enough. Thanks! /Magnus > > -- Igor > > [*] >> diff -r c6d128f60997 make/common/FindTests.gmk

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

2018-11-02 Thread Igor Ignatyev
Hi Magnus, > You still need to fix FindTests.gmk, though. thanks for spotting that. is [*] enough, or did I miss something else? -- Igor [*] > diff -r c6d128f60997 make/common/FindTests.gmk > --- a/make/common/FindTests.gmk Thu Nov 01 16:33:43 2018 -0700 > +++ b/make/common/FindTests.gmk Fri

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

2018-11-02 Thread Magnus Ihse Bursie
On 2018-11-02 00:37, Igor Ignatyev wrote: on a second though, removing these macros isn't that big, here is an incremental webrev: http://cr.openjdk.java.net/~iignatyev//8213058/webrev.0-1 . besides removing test_log, it

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

2018-11-02 Thread Magnus Ihse Bursie
Hi Igor, On 2018-11-01 22:15, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8213058/webrev.00/index.html What release are you targeting? This does not look like a patch that can be applied to jdk/jdk, at least not after JDK-8210958. When removing the "hotspot-internal" test,

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

2018-11-01 Thread Erik Joelsson
Looks good. /Erik On 2018-11-01 16:37, Igor Ignatyev wrote: on a second though, removing these macros isn't that big, here is an incremental webrev: http://cr.openjdk.java.net/~iignatyev//8213058/webrev.0-1 . besides

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

2018-11-01 Thread David Holmes
On 2/11/2018 9:37 AM, Igor Ignatyev wrote: on a second though, removing these macros isn't that big, here is an incremental webrev: http://cr.openjdk.java.net/~iignatyev//8213058/webrev.0-1 :) Thanks. Looks good! David

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

2018-11-01 Thread Igor Ignatyev
on a second though, removing these macros isn't that big, here is an incremental webrev: http://cr.openjdk.java.net/~iignatyev//8213058/webrev.0-1 . besides removing test_log, it also include fixes in build and doc needed due

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

2018-11-01 Thread Igor Ignatyev
Hi David, removing usage of test_log will just mix "unneeded" changes w/ this clean up. as TestReservedSpace_test, TestReserveMemorySpecial_test, TestVirtualSpace_test, and TestMetaspaceUtils_test are to be removed by 8213269[*], I don't think we need to pay much attention to their code. [*]

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

2018-11-01 Thread David Holmes
Hi Igor, There's no point having empty test_log macros that do nothing. The macro and all uses should just be deleted ... unless you plan on adding some other form of logging for this? Thanks, David On 2/11/2018 7:15 AM, Igor Ignatyev wrote:

Re: RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

2018-11-01 Thread Erik Joelsson
Build changes look good. /Erik On 2018-11-01 14:15, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8213058/webrev.00/index.html 174 lines changed: 0 ins; 170 del; 4 mod; Hi all, could you please review this small clean up which removes ExecuteInternalVMTests and

RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

2018-11-01 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8213058/webrev.00/index.html > 174 lines changed: 0 ins; 170 del; 4 mod; Hi all, could you please review this small clean up which removes ExecuteInternalVMTests and VerboseInternalVMTests flags and related make targets and tests? 8177708[1-3] is to