Re: RFR: 8201360: Zero fails to build on linux-sparc after 8201236

2018-04-17 Thread John Paul Adrian Glaubitz
Hi Magnus! On 04/10/2018 10:01 PM, Magnus Ihse Bursie wrote: > The regression you noted was not caused by JDK-8201236, but by JDK-8198862 > "Stop doing funky compilation stuff for dtrace". In fact, JDK-8201236 (which > is > pushed to jdk/jdk but not yet integrated into jdk/hs, apparently) will

Re: RFR: 8201360: Zero fails to build on linux-sparc after 8201236

2018-04-10 Thread John Paul Adrian Glaubitz
Hi Magnus! On 04/10/2018 10:01 PM, Magnus Ihse Bursie wrote: The regression you noted was not caused by JDK-8201236, but by JDK-8198862 "Stop doing funky compilation stuff for dtrace". In fact, JDK-8201236 (which is pushed to jdk/jdk but not yet integrated into jdk/hs, apparently) will once

Re: RFR: 8201360: Zero fails to build on linux-sparc after 8201236

2018-04-10 Thread Magnus Ihse Bursie
On 2018-04-10 20:22, John Paul Adrian Glaubitz wrote: Hi! Please review this minor change which fixes the Zero build on linux-sparc which got broken after "JDK-8201236 Straighten out dtrace build logic". While I agree that the fix solves your problems, maybe you could delay pushing this for a

Re: RFR: 8201360: Zero fails to build on linux-sparc after 8201236

2018-04-10 Thread John Paul Adrian Glaubitz
On 04/10/2018 08:51 PM, Gary Adams wrote: Is any update needed for EXTRA_OBJECT_FILES? No. I just made the single change Erik suggested and it builds fine for me. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin -

Re: RFR: 8201360: Zero fails to build on linux-sparc after 8201236

2018-04-10 Thread Gary Adams
Is any update needed for EXTRA_OBJECT_FILES? On 4/10/18, 2:32 PM, Erik Joelsson wrote: Looks good. /Erik On 2018-04-10 11:22, John Paul Adrian Glaubitz wrote: Hi! Please review this minor change which fixes the Zero build on linux-sparc which got broken after "JDK-8201236 Straighten out

Re: RFR: 8201360: Zero fails to build on linux-sparc after 8201236

2018-04-10 Thread Erik Joelsson
Looks good. /Erik On 2018-04-10 11:22, John Paul Adrian Glaubitz wrote: Hi! Please review this minor change which fixes the Zero build on linux-sparc which got broken after "JDK-8201236 Straighten out dtrace build logic". The change affects the Zero build on linux-sparc only since SPARC has

RFR: 8201360: Zero fails to build on linux-sparc after 8201236

2018-04-10 Thread John Paul Adrian Glaubitz
Hi! Please review this minor change which fixes the Zero build on linux-sparc which got broken after "JDK-8201236 Straighten out dtrace build logic". The change affects the Zero build on linux-sparc only since SPARC has its own implementation of memset_with_concurrent_readers() in memset_with_\